devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/5] Add PWM and TPU support to r8a7743
@ 2017-12-19 13:34 Fabrizio Castro
       [not found] ` <1513690500-12165-1-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Fabrizio Castro @ 2017-12-19 13:34 UTC (permalink / raw)
  To: Thierry Reding, Rob Herring, Mark Rutland, Russell King
  Cc: Fabrizio Castro, Simon Horman, Magnus Damm,
	linux-pwm-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Geert Uytterhoeven, Chris Paterson, Biju Das

Dear All,

this series includes all that is required to add PWM and TPU SoC specific
support for the r8a7743.

Thanks,

Fabrizio Castro (5):
  ARM: shmobile: defconfig: Enable PWM
  dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
  ARM: dts: r8a7743: Add PWM SoC support
  dt-bindings: pwm: renesas-tpu: Document r8a774[35] support
  ARM: dts: r8a7743: Add TPU support

 .../devicetree/bindings/pwm/renesas,pwm-rcar.txt   | 10 ++-
 .../devicetree/bindings/pwm/renesas,tpu-pwm.txt    |  4 +-
 arch/arm/boot/dts/r8a7743.dtsi                     | 80 ++++++++++++++++++++++
 arch/arm/configs/shmobile_defconfig                |  1 +
 4 files changed, 91 insertions(+), 4 deletions(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
       [not found] ` <1513690500-12165-1-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
@ 2017-12-19 13:34   ` Fabrizio Castro
  2017-12-20  8:31     ` Simon Horman
  2017-12-19 13:34   ` [PATCH v3 3/5] ARM: dts: r8a7743: Add PWM SoC support Fabrizio Castro
  1 sibling, 1 reply; 15+ messages in thread
From: Fabrizio Castro @ 2017-12-19 13:34 UTC (permalink / raw)
  To: Thierry Reding, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, linux-pwm-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA

This patch adds compatible strings specific to r8a774[35], no driver
change is needed as the fallback compatible string will activate the
right code. Also, this patch replaces the example with a DT snippet used
for adding PWM0 support to an r8a7743 based platform.

Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
v2->v3:
* No change

 Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
index 74c1180..f3bba59 100644
--- a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
+++ b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
@@ -2,6 +2,8 @@
 
 Required Properties:
 - compatible: should be "renesas,pwm-rcar" and one of the following.
+ - "renesas,pwm-r8a7743": for RZ/G1M
+ - "renesas,pwm-r8a7745": for RZ/G1E
  - "renesas,pwm-r8a7778": for R-Car M1A
  - "renesas,pwm-r8a7779": for R-Car H1
  - "renesas,pwm-r8a7790": for R-Car H2
@@ -17,13 +19,15 @@ Required Properties:
 - pinctrl-0: phandle, referring to a default pin configuration node.
 - pinctrl-names: Set to "default".
 
-Example: R8A7790 (R-Car H2) PWM Timer node
+Example: R8A7743 (RZ/G1M) PWM Timer node
 
 	pwm0: pwm@e6e30000 {
-		compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
+		compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
 		reg = <0 0xe6e30000 0 0x8>;
+		clocks = <&cpg CPG_MOD 523>;
+		power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+		resets = <&cpg 523>;
 		#pwm-cells = <2>;
-		clocks = <&mstp5_clks R8A7790_CLK_PWM>;
 		pinctrl-0 = <&pwm0_pins>;
 		pinctrl-names = "default";
 	};
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v3 3/5] ARM: dts: r8a7743: Add PWM SoC support
       [not found] ` <1513690500-12165-1-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
  2017-12-19 13:34   ` [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings Fabrizio Castro
@ 2017-12-19 13:34   ` Fabrizio Castro
  2017-12-20  8:45     ` Simon Horman
  1 sibling, 1 reply; 15+ messages in thread
From: Fabrizio Castro @ 2017-12-19 13:34 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Russell King
  Cc: Fabrizio Castro, Simon Horman, Magnus Damm,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Geert Uytterhoeven, Chris Paterson, Biju Das

Add the definitions for pwm[0123456] to the SoC .dtsi.

Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
v2->v3:
* pwm[0123456] compatible definitions don't wrap anymore

 arch/arm/boot/dts/r8a7743.dtsi | 70 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 6a6c40c..282ba5a 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -1082,6 +1082,76 @@
 			status = "disabled";
 		};
 
+		pwm0: pwm@e6e30000 {
+			compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
+			reg = <0 0xe6e30000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm1: pwm@e6e31000 {
+			compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
+			reg = <0 0xe6e31000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm2: pwm@e6e32000 {
+			compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
+			reg = <0 0xe6e32000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm3: pwm@e6e33000 {
+			compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
+			reg = <0 0xe6e33000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm4: pwm@e6e34000 {
+			compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
+			reg = <0 0xe6e34000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm5: pwm@e6e35000 {
+			compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
+			reg = <0 0xe6e35000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
+		pwm6: pwm@e6e36000 {
+			compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
+			reg = <0 0xe6e36000 0 0x8>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+			resets = <&cpg 523>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
 		sdhi0: sd@ee100000 {
 			compatible = "renesas,sdhi-r8a7743",
 				     "renesas,rcar-gen2-sdhi";
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support
  2017-12-19 13:34 [PATCH v3 0/5] Add PWM and TPU support to r8a7743 Fabrizio Castro
       [not found] ` <1513690500-12165-1-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
@ 2017-12-19 13:34 ` Fabrizio Castro
       [not found]   ` <1513690500-12165-5-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
                     ` (2 more replies)
  2017-12-19 13:35 ` [PATCH v3 5/5] ARM: dts: r8a7743: Add TPU support Fabrizio Castro
  2 siblings, 3 replies; 15+ messages in thread
From: Fabrizio Castro @ 2017-12-19 13:34 UTC (permalink / raw)
  To: Thierry Reding, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, linux-pwm, devicetree, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

Document r8a774[35] specific compatible strings. No driver change is
needed as the fallback compatible string "renesas,tpu" activates the
right code in the driver.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2->v3:
* No change

 Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
index 1aadc80..16e5748 100644
--- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
+++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
@@ -5,8 +5,10 @@ Required Properties:
   - compatible: should be one of the following.
     - "renesas,tpu-r8a73a4": for R8A77A4 (R-Mobile APE6) compatible PWM controller.
     - "renesas,tpu-r8a7740": for R8A7740 (R-Mobile A1) compatible PWM controller.
+    - "renesas,tpu-r8a7743": for R8A7743 (RZ/G1M) compatible PWM controller.
+    - "renesas,tpu-r8a7745": for R8A7745 (RZ/G1E) compatible PWM controller.
     - "renesas,tpu-r8a7790": for R8A7790 (R-Car H2) compatible PWM controller.
-    - "renesas,tpu": for generic R-Car TPU PWM controller.
+    - "renesas,tpu": for generic R-Car and RZ/G1 TPU PWM controller.
 
   - reg: Base address and length of each memory resource used by the PWM
     controller hardware module.
-- 
2.7.4

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v3 5/5] ARM: dts: r8a7743: Add TPU support
  2017-12-19 13:34 [PATCH v3 0/5] Add PWM and TPU support to r8a7743 Fabrizio Castro
       [not found] ` <1513690500-12165-1-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
  2017-12-19 13:34 ` [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support Fabrizio Castro
@ 2017-12-19 13:35 ` Fabrizio Castro
  2017-12-20  8:47   ` Simon Horman
  2 siblings, 1 reply; 15+ messages in thread
From: Fabrizio Castro @ 2017-12-19 13:35 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Russell King
  Cc: Fabrizio Castro, Simon Horman, Magnus Damm, linux-renesas-soc,
	devicetree, linux-arm-kernel, Geert Uytterhoeven, Chris Paterson,
	Biju Das

Add TPU support to SoC DT.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2->v3:
* No change

 arch/arm/boot/dts/r8a7743.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 282ba5a..f24f36d 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -1152,6 +1152,16 @@
 			status = "disabled";
 		};
 
+		tpu: pwm@e60f0000 {
+			compatible = "renesas,tpu-r8a7743", "renesas,tpu";
+			reg = <0 0xe60f0000 0 0x148>;
+			clocks = <&cpg CPG_MOD 304>;
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+			resets = <&cpg 304>;
+			#pwm-cells = <3>;
+			status = "disabled";
+		};
+
 		sdhi0: sd@ee100000 {
 			compatible = "renesas,sdhi-r8a7743",
 				     "renesas,rcar-gen2-sdhi";
-- 
2.7.4

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
  2017-12-19 13:34   ` [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings Fabrizio Castro
@ 2017-12-20  8:31     ` Simon Horman
  2017-12-20  9:54       ` Fabrizio Castro
  0 siblings, 1 reply; 15+ messages in thread
From: Simon Horman @ 2017-12-20  8:31 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Thierry Reding, Rob Herring, Mark Rutland, linux-pwm, devicetree,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

On Tue, Dec 19, 2017 at 01:34:57PM +0000, Fabrizio Castro wrote:
> This patch adds compatible strings specific to r8a774[35], no driver
> change is needed as the fallback compatible string will activate the
> right code. Also, this patch replaces the example with a DT snippet used
> for adding PWM0 support to an r8a7743 based platform.

What is the motivation for updating the example?
Could it be stated here?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v3 3/5] ARM: dts: r8a7743: Add PWM SoC support
  2017-12-19 13:34   ` [PATCH v3 3/5] ARM: dts: r8a7743: Add PWM SoC support Fabrizio Castro
@ 2017-12-20  8:45     ` Simon Horman
  0 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2017-12-20  8:45 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm,
	linux-renesas-soc, devicetree, linux-arm-kernel,
	Geert Uytterhoeven, Chris Paterson, Biju Das

On Tue, Dec 19, 2017 at 01:34:58PM +0000, Fabrizio Castro wrote:
> Add the definitions for pwm[0123456] to the SoC .dtsi.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2->v3:
> * pwm[0123456] compatible definitions don't wrap anymore

Thanks, applied.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support
       [not found]   ` <1513690500-12165-5-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
@ 2017-12-20  8:46     ` Simon Horman
  0 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2017-12-20  8:46 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Thierry Reding, Rob Herring, Mark Rutland,
	linux-pwm-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven,
	Chris Paterson, Biju Das,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA

On Tue, Dec 19, 2017 at 01:34:59PM +0000, Fabrizio Castro wrote:
> Document r8a774[35] specific compatible strings. No driver change is
> needed as the fallback compatible string "renesas,tpu" activates the
> right code in the driver.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> ---
> v2->v3:
> * No change

Reviewed-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v3 5/5] ARM: dts: r8a7743: Add TPU support
  2017-12-19 13:35 ` [PATCH v3 5/5] ARM: dts: r8a7743: Add TPU support Fabrizio Castro
@ 2017-12-20  8:47   ` Simon Horman
  0 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2017-12-20  8:47 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm,
	linux-renesas-soc, devicetree, linux-arm-kernel,
	Geert Uytterhoeven, Chris Paterson, Biju Das

On Tue, Dec 19, 2017 at 01:35:00PM +0000, Fabrizio Castro wrote:
> Add TPU support to SoC DT.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2->v3:
> * No change

Thanks, applied.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
  2017-12-20  8:31     ` Simon Horman
@ 2017-12-20  9:54       ` Fabrizio Castro
  2017-12-20 10:12         ` Simon Horman
  0 siblings, 1 reply; 15+ messages in thread
From: Fabrizio Castro @ 2017-12-20  9:54 UTC (permalink / raw)
  To: Simon Horman
  Cc: Thierry Reding, Rob Herring, Mark Rutland, linux-pwm, devicetree,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

Hello Simon,

> Subject: Re: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
>
> On Tue, Dec 19, 2017 at 01:34:57PM +0000, Fabrizio Castro wrote:
> > This patch adds compatible strings specific to r8a774[35], no driver
> > change is needed as the fallback compatible string will activate the
> > right code. Also, this patch replaces the example with a DT snippet used
> > for adding PWM0 support to an r8a7743 based platform.
>
> What is the motivation for updating the example?

I am sorry I forgot to copy the explanation across from the first version of the patch:
https://patchwork.kernel.org/patch/10111831/

"the reason for replacing the example with one of a different SoC is that
the new example refers to recent code from a real use case. I hope that's ok."

Basically the r8a7743 will be the first platform with full upstream support, and I believe it is better to have up-to-date examples proven to work in the documentation.

> Could it be stated here?

Shall I send a new version for this?


Thanks,
Fab


[https://www2.renesas.eu/media/email/unicef_2017.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
  2017-12-20  9:54       ` Fabrizio Castro
@ 2017-12-20 10:12         ` Simon Horman
  2017-12-20 11:15           ` Fabrizio Castro
  0 siblings, 1 reply; 15+ messages in thread
From: Simon Horman @ 2017-12-20 10:12 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Thierry Reding, Rob Herring, Mark Rutland, linux-pwm, devicetree,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

On Wed, Dec 20, 2017 at 09:54:14AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> > Subject: Re: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
> >
> > On Tue, Dec 19, 2017 at 01:34:57PM +0000, Fabrizio Castro wrote:
> > > This patch adds compatible strings specific to r8a774[35], no driver
> > > change is needed as the fallback compatible string will activate the
> > > right code. Also, this patch replaces the example with a DT snippet used
> > > for adding PWM0 support to an r8a7743 based platform.
> >
> > What is the motivation for updating the example?
> 
> I am sorry I forgot to copy the explanation across from the first version of the patch:
> https://patchwork.kernel.org/patch/10111831/
> 
> "the reason for replacing the example with one of a different SoC is that
> the new example refers to recent code from a real use case. I hope that's ok."
> 
> Basically the r8a7743 will be the first platform with full upstream support, and I believe it is better to have up-to-date examples proven to work in the documentation.

Thanks, that sounds reasonable.

> 
> > Could it be stated here?
> 
> Shall I send a new version for this?

That would be best in my opinion.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
  2017-12-20 10:12         ` Simon Horman
@ 2017-12-20 11:15           ` Fabrizio Castro
  0 siblings, 0 replies; 15+ messages in thread
From: Fabrizio Castro @ 2017-12-20 11:15 UTC (permalink / raw)
  To: Simon Horman
  Cc: Thierry Reding, Rob Herring, Mark Rutland, linux-pwm, devicetree,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

Hello Simon,

> Subject: Re: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
>
> On Wed, Dec 20, 2017 at 09:54:14AM +0000, Fabrizio Castro wrote:
> > Hello Simon,
> >
> > > Subject: Re: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
> > >
> > > On Tue, Dec 19, 2017 at 01:34:57PM +0000, Fabrizio Castro wrote:
> > > > This patch adds compatible strings specific to r8a774[35], no driver
> > > > change is needed as the fallback compatible string will activate the
> > > > right code. Also, this patch replaces the example with a DT snippet used
> > > > for adding PWM0 support to an r8a7743 based platform.
> > >
> > > What is the motivation for updating the example?
> >
> > I am sorry I forgot to copy the explanation across from the first version of the patch:
> > https://patchwork.kernel.org/patch/10111831/
> >
> > "the reason for replacing the example with one of a different SoC is that
> > the new example refers to recent code from a real use case. I hope that's ok."
> >
> > Basically the r8a7743 will be the first platform with full upstream support, and I believe it is better to have up-to-date examples
> proven to work in the documentation.
>
> Thanks, that sounds reasonable.
>
> >
> > > Could it be stated here?
> >
> > Shall I send a new version for this?
>
> That would be best in my opinion.

Thank you for your feedback, I'll send a new version separately (not in the context of this series anymore as the pending patches from this series are dt-bindings related) to enhance the changelog.

Cheers,
Fab


[https://www2.renesas.eu/media/email/unicef_2017.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support
  2017-12-19 13:34 ` [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support Fabrizio Castro
       [not found]   ` <1513690500-12165-5-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
@ 2018-01-24 17:16   ` Fabrizio Castro
  2018-03-06 16:52     ` Fabrizio Castro
  2018-03-27 21:52   ` Thierry Reding
  2 siblings, 1 reply; 15+ messages in thread
From: Fabrizio Castro @ 2018-01-24 17:16 UTC (permalink / raw)
  To: Thierry Reding
  Cc: linux-pwm, devicetree, Simon Horman, Geert Uytterhoeven,
	Chris Paterson, Biju Das, linux-renesas-soc, Fabrizio Castro,
	Mark Rutland, Rob Herring

Hello Thierry,

I am sorry to bother you,  just wondering if this patch has any chance to end up in v4.16?

Thanks,
Fabrizio

> Subject: [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support
>
> Document r8a774[35] specific compatible strings. No driver change is
> needed as the fallback compatible string "renesas,tpu" activates the
> right code in the driver.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2->v3:
> * No change
>
>  Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> index 1aadc80..16e5748 100644
> --- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> @@ -5,8 +5,10 @@ Required Properties:
>    - compatible: should be one of the following.
>      - "renesas,tpu-r8a73a4": for R8A77A4 (R-Mobile APE6) compatible PWM controller.
>      - "renesas,tpu-r8a7740": for R8A7740 (R-Mobile A1) compatible PWM controller.
> +    - "renesas,tpu-r8a7743": for R8A7743 (RZ/G1M) compatible PWM controller.
> +    - "renesas,tpu-r8a7745": for R8A7745 (RZ/G1E) compatible PWM controller.
>      - "renesas,tpu-r8a7790": for R8A7790 (R-Car H2) compatible PWM controller.
> -    - "renesas,tpu": for generic R-Car TPU PWM controller.
> +    - "renesas,tpu": for generic R-Car and RZ/G1 TPU PWM controller.
>
>    - reg: Base address and length of each memory resource used by the PWM
>      controller hardware module.
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support
  2018-01-24 17:16   ` Fabrizio Castro
@ 2018-03-06 16:52     ` Fabrizio Castro
  0 siblings, 0 replies; 15+ messages in thread
From: Fabrizio Castro @ 2018-03-06 16:52 UTC (permalink / raw)
  To: Thierry Reding, Mark Rutland, Rob Herring
  Cc: linux-pwm, devicetree, Simon Horman, Geert Uytterhoeven,
	Chris Paterson  <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	linux-renesas-soc@vger.kernel.org

Dear All,

same thing for this one, can someone take this patch?

Thanks,
Fab

> -----Original Message-----
> From: Fabrizio Castro
> Sent: 24 January 2018 17:17
> To: Thierry Reding <thierry.reding@gmail.com>
> Cc: linux-pwm@vger.kernel.org; devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>; Geert Uytterhoeven
> <geert+renesas@glider.be>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das <biju.das@bp.renesas.com>; linux-renesas-
> soc@vger.kernel.org; Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Mark Rutland <mark.rutland@arm.com>; Rob Herring
> <robh+dt@kernel.org>
> Subject: RE: [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support
>
> Hello Thierry,
>
> I am sorry to bother you,  just wondering if this patch has any chance to end up in v4.16?
>
> Thanks,
> Fabrizio
>
> > Subject: [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support
> >
> > Document r8a774[35] specific compatible strings. No driver change is
> > needed as the fallback compatible string "renesas,tpu" activates the
> > right code in the driver.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v2->v3:
> > * No change
> >
> >  Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> > b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> > index 1aadc80..16e5748 100644
> > --- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> > +++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> > @@ -5,8 +5,10 @@ Required Properties:
> >    - compatible: should be one of the following.
> >      - "renesas,tpu-r8a73a4": for R8A77A4 (R-Mobile APE6) compatible PWM controller.
> >      - "renesas,tpu-r8a7740": for R8A7740 (R-Mobile A1) compatible PWM controller.
> > +    - "renesas,tpu-r8a7743": for R8A7743 (RZ/G1M) compatible PWM controller.
> > +    - "renesas,tpu-r8a7745": for R8A7745 (RZ/G1E) compatible PWM controller.
> >      - "renesas,tpu-r8a7790": for R8A7790 (R-Car H2) compatible PWM controller.
> > -    - "renesas,tpu": for generic R-Car TPU PWM controller.
> > +    - "renesas,tpu": for generic R-Car and RZ/G1 TPU PWM controller.
> >
> >    - reg: Base address and length of each memory resource used by the PWM
> >      controller hardware module.
> > --
> > 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support
  2017-12-19 13:34 ` [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support Fabrizio Castro
       [not found]   ` <1513690500-12165-5-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
  2018-01-24 17:16   ` Fabrizio Castro
@ 2018-03-27 21:52   ` Thierry Reding
  2 siblings, 0 replies; 15+ messages in thread
From: Thierry Reding @ 2018-03-27 21:52 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Rob Herring, Mark Rutland, linux-pwm, devicetree, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

On Tue, Dec 19, 2017 at 01:34:59PM +0000, Fabrizio Castro wrote:
> Document r8a774[35] specific compatible strings. No driver change is
> needed as the fallback compatible string "renesas,tpu" activates the
> right code in the driver.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2->v3:
> * No change
> 
>  Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2018-03-27 21:52 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-19 13:34 [PATCH v3 0/5] Add PWM and TPU support to r8a7743 Fabrizio Castro
     [not found] ` <1513690500-12165-1-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-12-19 13:34   ` [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings Fabrizio Castro
2017-12-20  8:31     ` Simon Horman
2017-12-20  9:54       ` Fabrizio Castro
2017-12-20 10:12         ` Simon Horman
2017-12-20 11:15           ` Fabrizio Castro
2017-12-19 13:34   ` [PATCH v3 3/5] ARM: dts: r8a7743: Add PWM SoC support Fabrizio Castro
2017-12-20  8:45     ` Simon Horman
2017-12-19 13:34 ` [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support Fabrizio Castro
     [not found]   ` <1513690500-12165-5-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-12-20  8:46     ` Simon Horman
2018-01-24 17:16   ` Fabrizio Castro
2018-03-06 16:52     ` Fabrizio Castro
2018-03-27 21:52   ` Thierry Reding
2017-12-19 13:35 ` [PATCH v3 5/5] ARM: dts: r8a7743: Add TPU support Fabrizio Castro
2017-12-20  8:47   ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).