devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/5] R-Car D3 (r8a77995) I2C integration
@ 2018-01-29 15:45 Ulrich Hecht
       [not found] ` <1517240748-14780-1-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
                   ` (3 more replies)
  0 siblings, 4 replies; 19+ messages in thread
From: Ulrich Hecht @ 2018-01-29 15:45 UTC (permalink / raw)
  To: linux-renesas-soc, horms, geert, kieran.bingham
  Cc: wsa, magnus.damm, linux-i2c, devicetree, Ulrich Hecht

Hi!

This adds I2C controllers to the D3 device tree and enables I2C busses 0
and 1 on the Draak board. (I2C2 is not connected on that board.)

This revision addresses Geert's review comments and adds Reviewed-Bys.
See below for details.

CU
Uli


Changes since v1:
- pinctrl: patch dropped, has been picked up
- i2c-rcar: patch dropped, redundant
- dtsi: added dmac2 for i2c0-2
- dtsi: fixed internal SCL delays
- dts: fixed EEPROM compatible string
- bindings: added Rohm EEPROM
- bindings: fixed typo in i2c-rcar bindings


Ulrich Hecht (5):
  arm64: renesas: r8a77995: add I2C support
  arm64: renesas: draak: enable I2C controller 0 and EEPROM
  arm64: renesas: draak: enable I2C controller 1
  i2c: rcar: document R8A77995 bindings
  dt-bindings: at24: add bindings for Rohm BR24T01

 Documentation/devicetree/bindings/eeprom/at24.txt  |  2 +
 Documentation/devicetree/bindings/i2c/i2c-rcar.txt |  1 +
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts     | 28 +++++++++
 arch/arm64/boot/dts/renesas/r8a77995.dtsi          | 67 ++++++++++++++++++++++
 4 files changed, 98 insertions(+)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH v2 1/5] arm64: renesas: r8a77995: add I2C support
       [not found] ` <1517240748-14780-1-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-01-29 15:45   ` Ulrich Hecht
  2018-01-30 10:42     ` Wolfram Sang
  2018-01-29 15:45   ` [PATCH v2 3/5] arm64: renesas: draak: enable I2C controller 1 Ulrich Hecht
  2018-01-30  9:26   ` [PATCH v2 0/5] R-Car D3 (r8a77995) I2C integration Simon Horman
  2 siblings, 1 reply; 19+ messages in thread
From: Ulrich Hecht @ 2018-01-29 15:45 UTC (permalink / raw)
  To: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	horms-/R6kz+dDXgpPR4JQBCEnsQ, geert-Td1EMuHUCqxL1ZNQvxDV9g,
	kieran.bingham-ryLnwIuWjnjg/C1BVhZhaw
  Cc: wsa-z923LK4zBo2bacvFa/9K2g, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Ulrich Hecht

Defines R-Car D3 I2C controllers 0-3.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/r8a77995.dtsi | 67 +++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
index 23f763b..22e633c 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -536,6 +536,73 @@
 			status = "disabled";
 		};
 
+		i2c0: i2c@e6500000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a77995",
+				     "renesas,rcar-gen3-i2c";
+			reg = <0 0xe6500000 0 0x40>;
+			interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 931>;
+			power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
+			resets = <&cpg 931>;
+			dmas = <&dmac1 0x91>, <&dmac1 0x90>,
+			       <&dmac2 0x91>, <&dmac2 0x90>;
+			dma-names = "tx", "rx", "tx", "rx";
+			i2c-scl-internal-delay-ns = <6>;
+			status = "disabled";
+		};
+
+		i2c1: i2c@e6508000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a77995",
+				     "renesas,rcar-gen3-i2c";
+			reg = <0 0xe6508000 0 0x40>;
+			interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 930>;
+			power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
+			resets = <&cpg 930>;
+			dmas = <&dmac1 0x93>, <&dmac1 0x92>,
+			       <&dmac2 0x93>, <&dmac2 0x92>;
+			dma-names = "tx", "rx", "tx", "rx";
+			i2c-scl-internal-delay-ns = <6>;
+			status = "disabled";
+		};
+
+		i2c2: i2c@e6510000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a77995",
+				     "renesas,rcar-gen3-i2c";
+			reg = <0 0xe6510000 0 0x40>;
+			interrupts = <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 929>;
+			power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
+			resets = <&cpg 929>;
+			dmas = <&dmac1 0x95>, <&dmac1 0x94>,
+			       <&dmac2 0x95>, <&dmac2 0x94>;
+			dma-names = "tx", "rx", "tx", "rx";
+			i2c-scl-internal-delay-ns = <6>;
+			status = "disabled";
+		};
+
+		i2c3: i2c@e66d0000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a77995",
+				     "renesas,rcar-gen3-i2c";
+			reg = <0 0xe66d0000 0 0x40>;
+			interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 928>;
+			power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
+			resets = <&cpg 928>;
+			dmas = <&dmac0 0x97>, <&dmac0 0x96>;
+			dma-names = "tx", "rx";
+			i2c-scl-internal-delay-ns = <6>;
+			status = "disabled";
+		};
+
 		pwm0: pwm@e6e30000 {
 			compatible = "renesas,pwm-r8a77995", "renesas,pwm-rcar";
 			reg = <0 0xe6e30000 0 0x8>;
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 2/5] arm64: renesas: draak: enable I2C controller 0 and EEPROM
  2018-01-29 15:45 [PATCH v2 0/5] R-Car D3 (r8a77995) I2C integration Ulrich Hecht
       [not found] ` <1517240748-14780-1-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-01-29 15:45 ` Ulrich Hecht
  2018-01-30 10:43   ` Wolfram Sang
  2018-01-29 15:45 ` [PATCH v2 4/5] i2c: rcar: document R8A77995 bindings Ulrich Hecht
  2018-01-29 15:45 ` [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01 Ulrich Hecht
  3 siblings, 1 reply; 19+ messages in thread
From: Ulrich Hecht @ 2018-01-29 15:45 UTC (permalink / raw)
  To: linux-renesas-soc, horms, geert, kieran.bingham
  Cc: wsa, magnus.damm, linux-i2c, devicetree, Ulrich Hecht

Enables EEPROM on I2C0 on the Draak board.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index 09de73b..6ff9d3e 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -46,6 +46,11 @@
 		};
 	};
 
+	i2c0_pins: i2c0 {
+		groups = "i2c0";
+		function = "i2c0";
+	};
+
 	pwm0_pins: pwm0 {
 		groups = "pwm0_c";
 		function = "pwm0";
@@ -67,6 +72,18 @@
 	};
 };
 
+&i2c0 {
+	pinctrl-0 = <&i2c0_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	eeprom@50 {
+		compatible = "rohm,br24t01", "atmel,24c01";
+		reg = <0x50>;
+		pagesize = <8>;
+	};
+};
+
 &ehci0 {
 	status = "okay";
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 3/5] arm64: renesas: draak: enable I2C controller 1
       [not found] ` <1517240748-14780-1-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-01-29 15:45   ` [PATCH v2 1/5] arm64: renesas: r8a77995: add I2C support Ulrich Hecht
@ 2018-01-29 15:45   ` Ulrich Hecht
  2018-01-30 10:43     ` Wolfram Sang
  2018-01-30  9:26   ` [PATCH v2 0/5] R-Car D3 (r8a77995) I2C integration Simon Horman
  2 siblings, 1 reply; 19+ messages in thread
From: Ulrich Hecht @ 2018-01-29 15:45 UTC (permalink / raw)
  To: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	horms-/R6kz+dDXgpPR4JQBCEnsQ, geert-Td1EMuHUCqxL1ZNQvxDV9g,
	kieran.bingham-ryLnwIuWjnjg/C1BVhZhaw
  Cc: wsa-z923LK4zBo2bacvFa/9K2g, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Ulrich Hecht

No devices to add, I2C1 has an external connector only.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index 6ff9d3e..af07da2 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -51,6 +51,11 @@
 		function = "i2c0";
 	};
 
+	i2c1_pins: i2c1 {
+		groups = "i2c1";
+		function = "i2c1";
+	};
+
 	pwm0_pins: pwm0 {
 		groups = "pwm0_c";
 		function = "pwm0";
@@ -84,6 +89,12 @@
 	};
 };
 
+&i2c1 {
+	pinctrl-0 = <&i2c1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
 &ehci0 {
 	status = "okay";
 };
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 4/5] i2c: rcar: document R8A77995 bindings
  2018-01-29 15:45 [PATCH v2 0/5] R-Car D3 (r8a77995) I2C integration Ulrich Hecht
       [not found] ` <1517240748-14780-1-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-01-29 15:45 ` [PATCH v2 2/5] arm64: renesas: draak: enable I2C controller 0 and EEPROM Ulrich Hecht
@ 2018-01-29 15:45 ` Ulrich Hecht
       [not found]   ` <1517240748-14780-5-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
                     ` (2 more replies)
  2018-01-29 15:45 ` [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01 Ulrich Hecht
  3 siblings, 3 replies; 19+ messages in thread
From: Ulrich Hecht @ 2018-01-29 15:45 UTC (permalink / raw)
  To: linux-renesas-soc, horms, geert, kieran.bingham
  Cc: wsa, magnus.damm, linux-i2c, devicetree, Ulrich Hecht

R-Car D3 (R8A77995) SoC has a R-Car Gen3-compatible I2C controller.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
index a777477..e91dbaf 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
@@ -14,6 +14,7 @@ Required properties:
 	"renesas,i2c-r8a7795" if the device is a part of a R8A7795 SoC.
 	"renesas,i2c-r8a7796" if the device is a part of a R8A7796 SoC.
 	"renesas,i2c-r8a77970" if the device is a part of a R8A77970 SoC.
+	"renesas,i2c-r8a77995" if the device is a part of a R8A77995 SoC.
 	"renesas,rcar-gen1-i2c" for a generic R-Car Gen1 compatible device.
 	"renesas,rcar-gen2-i2c" for a generic R-Car Gen2 or RZ/G1 compatible
 				device.
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01
  2018-01-29 15:45 [PATCH v2 0/5] R-Car D3 (r8a77995) I2C integration Ulrich Hecht
                   ` (2 preceding siblings ...)
  2018-01-29 15:45 ` [PATCH v2 4/5] i2c: rcar: document R8A77995 bindings Ulrich Hecht
@ 2018-01-29 15:45 ` Ulrich Hecht
  2018-01-29 16:06   ` Geert Uytterhoeven
                     ` (3 more replies)
  3 siblings, 4 replies; 19+ messages in thread
From: Ulrich Hecht @ 2018-01-29 15:45 UTC (permalink / raw)
  To: linux-renesas-soc, horms, geert, kieran.bingham
  Cc: wsa, magnus.damm, linux-i2c, devicetree, Ulrich Hecht

Both manufacturer and name variant.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index 1812c84..dd29937 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -40,6 +40,7 @@ Required properties:
                 "microchip",
                 "ramtron",
                 "renesas",
+                "rohm",
                 "nxp",
                 "st",
 
@@ -47,6 +48,7 @@ Required properties:
                 variants of the above. Known such exceptions are listed below:
 
                 "renesas,r1ex24002" - the fallback is "atmel,24c02"
+                "rohm,br24t01" - the fallback is "atmel,24c01"
 
   - reg: The I2C address of the EEPROM.
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01
  2018-01-29 15:45 ` [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01 Ulrich Hecht
@ 2018-01-29 16:06   ` Geert Uytterhoeven
  2018-01-30 10:44   ` Wolfram Sang
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 19+ messages in thread
From: Geert Uytterhoeven @ 2018-01-29 16:06 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: Linux-Renesas, Simon Horman, Kieran Bingham, Wolfram Sang,
	Magnus Damm, Linux I2C,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

On Mon, Jan 29, 2018 at 4:45 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Both manufacturer and name variant.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 4/5] i2c: rcar: document R8A77995 bindings
       [not found]   ` <1517240748-14780-5-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-01-30  9:18     ` Simon Horman
  0 siblings, 0 replies; 19+ messages in thread
From: Simon Horman @ 2018-01-30  9:18 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	geert-Td1EMuHUCqxL1ZNQvxDV9g,
	kieran.bingham-ryLnwIuWjnjg/C1BVhZhaw,
	wsa-z923LK4zBo2bacvFa/9K2g, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Mon, Jan 29, 2018 at 04:45:47PM +0100, Ulrich Hecht wrote:
> R-Car D3 (R8A77995) SoC has a R-Car Gen3-compatible I2C controller.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Reviewed-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>

> ---
>  Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> index a777477..e91dbaf 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> @@ -14,6 +14,7 @@ Required properties:
>  	"renesas,i2c-r8a7795" if the device is a part of a R8A7795 SoC.
>  	"renesas,i2c-r8a7796" if the device is a part of a R8A7796 SoC.
>  	"renesas,i2c-r8a77970" if the device is a part of a R8A77970 SoC.
> +	"renesas,i2c-r8a77995" if the device is a part of a R8A77995 SoC.
>  	"renesas,rcar-gen1-i2c" for a generic R-Car Gen1 compatible device.
>  	"renesas,rcar-gen2-i2c" for a generic R-Car Gen2 or RZ/G1 compatible
>  				device.
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 0/5] R-Car D3 (r8a77995) I2C integration
       [not found] ` <1517240748-14780-1-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-01-29 15:45   ` [PATCH v2 1/5] arm64: renesas: r8a77995: add I2C support Ulrich Hecht
  2018-01-29 15:45   ` [PATCH v2 3/5] arm64: renesas: draak: enable I2C controller 1 Ulrich Hecht
@ 2018-01-30  9:26   ` Simon Horman
  2 siblings, 0 replies; 19+ messages in thread
From: Simon Horman @ 2018-01-30  9:26 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	geert-Td1EMuHUCqxL1ZNQvxDV9g,
	kieran.bingham-ryLnwIuWjnjg/C1BVhZhaw,
	wsa-z923LK4zBo2bacvFa/9K2g, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Mon, Jan 29, 2018 at 04:45:43PM +0100, Ulrich Hecht wrote:
> Hi!
> 
> This adds I2C controllers to the D3 device tree and enables I2C busses 0
> and 1 on the Draak board. (I2C2 is not connected on that board.)
> 
> This revision addresses Geert's review comments and adds Reviewed-Bys.
> See below for details.
> 
> CU
> Uli
> 
> 
> Changes since v1:
> - pinctrl: patch dropped, has been picked up
> - i2c-rcar: patch dropped, redundant
> - dtsi: added dmac2 for i2c0-2
> - dtsi: fixed internal SCL delays
> - dts: fixed EEPROM compatible string
> - bindings: added Rohm EEPROM
> - bindings: fixed typo in i2c-rcar bindings
> 
> 
> Ulrich Hecht (5):
>   arm64: renesas: r8a77995: add I2C support
>   arm64: renesas: draak: enable I2C controller 0 and EEPROM
>   arm64: renesas: draak: enable I2C controller 1

Thanks, I have applied the arm64 patches after updating their prefix to
"arm64: dts: renesas:".

>   i2c: rcar: document R8A77995 bindings
>   dt-bindings: at24: add bindings for Rohm BR24T01
> 
>  Documentation/devicetree/bindings/eeprom/at24.txt  |  2 +
>  Documentation/devicetree/bindings/i2c/i2c-rcar.txt |  1 +
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts     | 28 +++++++++
>  arch/arm64/boot/dts/renesas/r8a77995.dtsi          | 67 ++++++++++++++++++++++
>  4 files changed, 98 insertions(+)
> 
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 1/5] arm64: renesas: r8a77995: add I2C support
  2018-01-29 15:45   ` [PATCH v2 1/5] arm64: renesas: r8a77995: add I2C support Ulrich Hecht
@ 2018-01-30 10:42     ` Wolfram Sang
  0 siblings, 0 replies; 19+ messages in thread
From: Wolfram Sang @ 2018-01-30 10:42 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: linux-renesas-soc, horms, geert, kieran.bingham, magnus.damm,
	linux-i2c, devicetree

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

On Mon, Jan 29, 2018 at 04:45:44PM +0100, Ulrich Hecht wrote:
> Defines R-Car D3 I2C controllers 0-3.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 2/5] arm64: renesas: draak: enable I2C controller 0 and EEPROM
  2018-01-29 15:45 ` [PATCH v2 2/5] arm64: renesas: draak: enable I2C controller 0 and EEPROM Ulrich Hecht
@ 2018-01-30 10:43   ` Wolfram Sang
  0 siblings, 0 replies; 19+ messages in thread
From: Wolfram Sang @ 2018-01-30 10:43 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: linux-renesas-soc, horms, geert, kieran.bingham, magnus.damm,
	linux-i2c, devicetree

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

On Mon, Jan 29, 2018 at 04:45:45PM +0100, Ulrich Hecht wrote:
> Enables EEPROM on I2C0 on the Draak board.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 3/5] arm64: renesas: draak: enable I2C controller 1
  2018-01-29 15:45   ` [PATCH v2 3/5] arm64: renesas: draak: enable I2C controller 1 Ulrich Hecht
@ 2018-01-30 10:43     ` Wolfram Sang
  0 siblings, 0 replies; 19+ messages in thread
From: Wolfram Sang @ 2018-01-30 10:43 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: linux-renesas-soc, horms, geert, kieran.bingham, magnus.damm,
	linux-i2c, devicetree

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

On Mon, Jan 29, 2018 at 04:45:46PM +0100, Ulrich Hecht wrote:
> No devices to add, I2C1 has an external connector only.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01
  2018-01-29 15:45 ` [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01 Ulrich Hecht
  2018-01-29 16:06   ` Geert Uytterhoeven
@ 2018-01-30 10:44   ` Wolfram Sang
  2018-02-02  9:02     ` Bartosz Golaszewski
  2018-02-05  6:07   ` Rob Herring
  2018-03-02 10:17   ` Bartosz Golaszewski
  3 siblings, 1 reply; 19+ messages in thread
From: Wolfram Sang @ 2018-01-30 10:44 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: linux-renesas-soc, horms, geert, kieran.bingham, magnus.damm,
	linux-i2c, devicetree

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

On Mon, Jan 29, 2018 at 04:45:48PM +0100, Ulrich Hecht wrote:
> Both manufacturer and name variant.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01
  2018-01-30 10:44   ` Wolfram Sang
@ 2018-02-02  9:02     ` Bartosz Golaszewski
  0 siblings, 0 replies; 19+ messages in thread
From: Bartosz Golaszewski @ 2018-02-02  9:02 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Ulrich Hecht, linux-renesas-soc, horms, geert, kieran.bingham,
	magnus.damm, linux-i2c, devicetree

2018-01-30 11:44 GMT+01:00 Wolfram Sang <wsa@the-dreams.de>:
> On Mon, Jan 29, 2018 at 04:45:48PM +0100, Ulrich Hecht wrote:
>> Both manufacturer and name variant.
>>
>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>

Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 4/5] i2c: rcar: document R8A77995 bindings
  2018-01-29 15:45 ` [PATCH v2 4/5] i2c: rcar: document R8A77995 bindings Ulrich Hecht
       [not found]   ` <1517240748-14780-5-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-02-05  6:07   ` Rob Herring
  2018-02-26 20:01   ` Wolfram Sang
  2 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2018-02-05  6:07 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: linux-renesas-soc, horms, geert, kieran.bingham, wsa,
	magnus.damm, linux-i2c, devicetree

On Mon, Jan 29, 2018 at 04:45:47PM +0100, Ulrich Hecht wrote:
> R-Car D3 (R8A77995) SoC has a R-Car Gen3-compatible I2C controller.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
>  1 file changed, 1 insertion(+)

"dt-bindings: i2c: " for the subject. Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01
  2018-01-29 15:45 ` [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01 Ulrich Hecht
  2018-01-29 16:06   ` Geert Uytterhoeven
  2018-01-30 10:44   ` Wolfram Sang
@ 2018-02-05  6:07   ` Rob Herring
  2018-02-05  7:56     ` Bartosz Golaszewski
  2018-03-02 10:17   ` Bartosz Golaszewski
  3 siblings, 1 reply; 19+ messages in thread
From: Rob Herring @ 2018-02-05  6:07 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: linux-renesas-soc, horms, geert, kieran.bingham, wsa,
	magnus.damm, linux-i2c, devicetree

On Mon, Jan 29, 2018 at 04:45:48PM +0100, Ulrich Hecht wrote:
> Both manufacturer and name variant.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index 1812c84..dd29937 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -40,6 +40,7 @@ Required properties:
>                  "microchip",
>                  "ramtron",
>                  "renesas",
> +                "rohm",

This is going to comflict with a patch sorting these IIRC. So they 
should go thru the same tree.

>                  "nxp",
>                  "st",
>  
> @@ -47,6 +48,7 @@ Required properties:
>                  variants of the above. Known such exceptions are listed below:
>  
>                  "renesas,r1ex24002" - the fallback is "atmel,24c02"
> +                "rohm,br24t01" - the fallback is "atmel,24c01"
>  
>    - reg: The I2C address of the EEPROM.
>  
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01
  2018-02-05  6:07   ` Rob Herring
@ 2018-02-05  7:56     ` Bartosz Golaszewski
  0 siblings, 0 replies; 19+ messages in thread
From: Bartosz Golaszewski @ 2018-02-05  7:56 UTC (permalink / raw)
  To: Rob Herring
  Cc: Ulrich Hecht, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	Simon Horman, geert-Td1EMuHUCqxL1ZNQvxDV9g,
	kieran.bingham-ryLnwIuWjnjg/C1BVhZhaw, Wolfram Sang, Magnus Damm,
	linux-i2c, devicetree

2018-02-05 7:07 GMT+01:00 Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
> On Mon, Jan 29, 2018 at 04:45:48PM +0100, Ulrich Hecht wrote:
>> Both manufacturer and name variant.
>>
>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>  Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
>>  1 file changed, 2 insertions(+)
>
> Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
>>
>> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
>> index 1812c84..dd29937 100644
>> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
>> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
>> @@ -40,6 +40,7 @@ Required properties:
>>                  "microchip",
>>                  "ramtron",
>>                  "renesas",
>> +                "rohm",
>
> This is going to comflict with a patch sorting these IIRC. So they
> should go thru the same tree.
>
>>                  "nxp",
>>                  "st",
>>
>> @@ -47,6 +48,7 @@ Required properties:
>>                  variants of the above. Known such exceptions are listed below:
>>
>>                  "renesas,r1ex24002" - the fallback is "atmel,24c02"
>> +                "rohm,br24t01" - the fallback is "atmel,24c01"
>>
>>    - reg: The I2C address of the EEPROM.
>>
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

AT24 patches go through Wolfram's tree, but since he already sent his
PR for 4.16, I can pick them up for 4.17 (except for Peter's sorting
patch which should go in after 4.16-rc1).

Thanks,
Bartosz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 4/5] i2c: rcar: document R8A77995 bindings
  2018-01-29 15:45 ` [PATCH v2 4/5] i2c: rcar: document R8A77995 bindings Ulrich Hecht
       [not found]   ` <1517240748-14780-5-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-02-05  6:07   ` Rob Herring
@ 2018-02-26 20:01   ` Wolfram Sang
  2 siblings, 0 replies; 19+ messages in thread
From: Wolfram Sang @ 2018-02-26 20:01 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: linux-renesas-soc, horms, geert, kieran.bingham, magnus.damm,
	linux-i2c, devicetree

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

On Mon, Jan 29, 2018 at 04:45:47PM +0100, Ulrich Hecht wrote:
> R-Car D3 (R8A77995) SoC has a R-Car Gen3-compatible I2C controller.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Fixed $subject according to Rob's request and applied to for-next,
thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01
  2018-01-29 15:45 ` [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01 Ulrich Hecht
                     ` (2 preceding siblings ...)
  2018-02-05  6:07   ` Rob Herring
@ 2018-03-02 10:17   ` Bartosz Golaszewski
  3 siblings, 0 replies; 19+ messages in thread
From: Bartosz Golaszewski @ 2018-03-02 10:17 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: linux-renesas-soc, Simon Horman, geert, kieran.bingham,
	Wolfram Sang, Magnus Damm, linux-i2c, devicetree

2018-01-29 16:45 GMT+01:00 Ulrich Hecht <ulrich.hecht+renesas@gmail.com>:
> Both manufacturer and name variant.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index 1812c84..dd29937 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -40,6 +40,7 @@ Required properties:
>                  "microchip",
>                  "ramtron",
>                  "renesas",
> +                "rohm",
>                  "nxp",
>                  "st",
>
> @@ -47,6 +48,7 @@ Required properties:
>                  variants of the above. Known such exceptions are listed below:
>
>                  "renesas,r1ex24002" - the fallback is "atmel,24c02"
> +                "rohm,br24t01" - the fallback is "atmel,24c01"
>
>    - reg: The I2C address of the EEPROM.
>
> --
> 2.7.4
>

Applied to for-next, thanks.

Bart

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2018-03-02 10:17 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-29 15:45 [PATCH v2 0/5] R-Car D3 (r8a77995) I2C integration Ulrich Hecht
     [not found] ` <1517240748-14780-1-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-29 15:45   ` [PATCH v2 1/5] arm64: renesas: r8a77995: add I2C support Ulrich Hecht
2018-01-30 10:42     ` Wolfram Sang
2018-01-29 15:45   ` [PATCH v2 3/5] arm64: renesas: draak: enable I2C controller 1 Ulrich Hecht
2018-01-30 10:43     ` Wolfram Sang
2018-01-30  9:26   ` [PATCH v2 0/5] R-Car D3 (r8a77995) I2C integration Simon Horman
2018-01-29 15:45 ` [PATCH v2 2/5] arm64: renesas: draak: enable I2C controller 0 and EEPROM Ulrich Hecht
2018-01-30 10:43   ` Wolfram Sang
2018-01-29 15:45 ` [PATCH v2 4/5] i2c: rcar: document R8A77995 bindings Ulrich Hecht
     [not found]   ` <1517240748-14780-5-git-send-email-ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-30  9:18     ` Simon Horman
2018-02-05  6:07   ` Rob Herring
2018-02-26 20:01   ` Wolfram Sang
2018-01-29 15:45 ` [PATCH v2 5/5] dt-bindings: at24: add bindings for Rohm BR24T01 Ulrich Hecht
2018-01-29 16:06   ` Geert Uytterhoeven
2018-01-30 10:44   ` Wolfram Sang
2018-02-02  9:02     ` Bartosz Golaszewski
2018-02-05  6:07   ` Rob Herring
2018-02-05  7:56     ` Bartosz Golaszewski
2018-03-02 10:17   ` Bartosz Golaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).