From: Alexey Brodkin <Alexey.Brodkin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
To: "brgl-ARrdPY/1zhM@public.gmane.org" <brgl-ARrdPY/1zhM@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"mark.rutland-5wv7dgnIgG8@public.gmane.org"
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org"
<Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
Date: Tue, 6 Feb 2018 12:25:24 +0000 [thread overview]
Message-ID: <1517919923.6726.13.camel@synopsys.com> (raw)
In-Reply-To: <20180206110810.9093-1-brgl-ARrdPY/1zhM@public.gmane.org>
Hi Bartosz,
On Tue, 2018-02-06 at 12:08 +0100, Bartosz Golaszewski wrote:
> Using compatible strings without the <manufacturer> part for at24 is
> deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently
> document the compatible property"). Use a correct 'atmel,<model>'
> value.
>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
So my further input might be a bit unexpected :)
I took a look at the real board and understood that we specified in .dts
wrong ICs. Those Atmel parts are not connected to the CPU at all (used by some
external device) and instead I2C EEPROM we really have connected (but not yet
obviously used in the Linux kernel) is NXP's PCF8594C-2.
That said we may accept your change because it doesn't break anything
and then I'll send an update to axs10x_mb.dts with replacement of EEPROM nodes.
Or we may drop your change at all since I'm going to replace corresponding nodes.
-Alexey
next prev parent reply other threads:[~2018-02-06 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 11:08 [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb Bartosz Golaszewski
[not found] ` <20180206110810.9093-1-brgl-ARrdPY/1zhM@public.gmane.org>
2018-02-06 12:25 ` Alexey Brodkin [this message]
2018-02-06 18:01 ` Bartosz Golaszewski
[not found] ` <CAMRc=MfgLA2KDMFLM_GrbSb6MfQeAdHfVJXbnx-ss+S4xm72uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-06 21:04 ` Alexey Brodkin
[not found] ` <4881796E12491D4BB15146FE0209CE646802AACB-okAzG6w2b9vBRDCkatnZjvufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2018-02-06 22:39 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517919923.6726.13.camel@synopsys.com \
--to=alexey.brodkin-hkixbcoqz3hwk0htik3j/w@public.gmane.org \
--cc=Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=brgl-ARrdPY/1zhM@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).