From: Biao Huang <biao.huang@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<srv_heupstream@mediatek.com>, <macpaul.lin@mediatek.com>,
<angelogioacchino.delregno@collabora.com>, <dkirjanov@suse.de>
Subject: Re: [PATCH net-next v9 6/6] net: dt-bindings: dwmac: add support for mt8195
Date: Thu, 16 Dec 2021 10:34:04 +0800 [thread overview]
Message-ID: <151fc4556ba03703dffa30aeb8f24aee489c855c.camel@mediatek.com> (raw)
In-Reply-To: <YbpobIscSDPKuxxY@robh.at.kernel.org>
Dear Rob,
Thanks for your comments~
On Wed, 2021-12-15 at 16:13 -0600, Rob Herring wrote:
> On Wed, Dec 15, 2021 at 10:16:52AM +0800, Biao Huang wrote:
> > Add binding document for the ethernet on mt8195.
> >
> > Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> > ---
> > .../bindings/net/mediatek-dwmac.yaml | 42 ++++++++++++++-
> > ----
> > 1 file changed, 32 insertions(+), 10 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/mediatek-
> > dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-
> > dwmac.yaml
> > index 8ad6e19661b8..44d55146def4 100644
> > --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> > @@ -19,6 +19,7 @@ select:
> > contains:
> > enum:
> > - mediatek,mt2712-gmac
> > + - mediatek,mt8195-gmac
> > required:
> > - compatible
> >
> > @@ -27,26 +28,37 @@ allOf:
> >
> > properties:
> > compatible:
> > - items:
> > - - enum:
> > - - mediatek,mt2712-gmac
> > - - const: snps,dwmac-4.20a
> > + oneOf:
> > + - items:
> > + - enum:
> > + - mediatek,mt2712-gmac
> > + - const: snps,dwmac-4.20a
> > + - items:
> > + - enum:
> > + - mediatek,mt8195-gmac
> > + - const: snps,dwmac-5.10a
> >
> > clocks:
> > + minItems: 5
>
> As before, you need 'minItems: 4' in the previous patch.
>
> If you aren't clear what's needed, run 'make dtbs_checks' yourself
> before submitting again.
But as modified in "[PATCH net-next v9 3/6] arm64: dts: mt2712: update
ethernet device node", we expect "minItems: 5".
run 'make dtbs_checks' with "[PATCH net-next v9 3/6] arm64: dts:
mt2712: update ethernet device node" applied, will not report logs such
as "ethernet@1101c000: clock-names: ['axi', 'apb', 'mac_main',
'ptp_ref'] is too short".
Should it be fine if I keep "minItems:5"?
>
> > items:
> > - description: AXI clock
> > - description: APB clock
> > - description: MAC Main clock
> > - description: PTP clock
> > - description: RMII reference clock provided by MAC
> > + - description: MAC clock gate
> >
> > clock-names:
> > - items:
> > - - const: axi
> > - - const: apb
> > - - const: mac_main
> > - - const: ptp_ref
> > - - const: rmii_internal
> > + minItems: 5
> > + maxItems: 6
> > + contains:
>
> No, you just threw out the order requirements. And this schema will
> be
> true with just 1 of the strings below plus any other strings. For
> example, this will pass:
>
> clock-names = "foo", "bar", "axi", "baz", "rob";
I misunderstood this schema,
and how about the following description:
clock-names:
minItems: 5
maxItems: 6
items:
- const: axi
- const: apb
- const: mac_main
- const: ptp_ref
- const: rmii_internal
- const: mac_cg
Regards!
>
> > + enum:
> > + - axi
> > + - apb
> > + - mac_main
> > + - ptp_ref
> > + - rmii_internal
> > + - mac_cg
> >
> > mediatek,pericfg:
> > $ref: /schemas/types.yaml#/definitions/phandle
> > @@ -61,6 +73,8 @@ properties:
> > or will round down. Range 0~31*170.
> > For MT2712 RMII/MII interface, Allowed value need to be a
> > multiple of 550,
> > or will round down. Range 0~31*550.
> > + For MT8195 RGMII/RMII/MII interface, Allowed value need to
> > be a multiple of 290,
> > + or will round down. Range 0~31*290.
> >
> > mediatek,rx-delay-ps:
> > description:
> > @@ -69,6 +83,8 @@ properties:
> > or will round down. Range 0~31*170.
> > For MT2712 RMII/MII interface, Allowed value need to be a
> > multiple of 550,
> > or will round down. Range 0~31*550.
> > + For MT8195 RGMII/RMII/MII interface, Allowed value need to
> > be a multiple
> > + of 290, or will round down. Range 0~31*290.
> >
> > mediatek,rmii-rxc:
> > type: boolean
> > @@ -102,6 +118,12 @@ properties:
> > 3. the inside clock, which be sent to MAC, will be inversed
> > in RMII case when
> > the reference clock is from MAC.
> >
> > + mediatek,mac-wol:
> > + type: boolean
> > + description:
> > + If present, indicates that MAC supports WOL(Wake-On-LAN),
> > and MAC WOL will be enabled.
> > + Otherwise, PHY WOL is perferred.
> > +
> > required:
> > - compatible
> > - reg
> > --
> > 2.25.1
> >
> >
prev parent reply other threads:[~2021-12-16 2:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 2:16 [PATCH net-next v9 0/6] MediaTek Ethernet Patches on MT8195 Biao Huang
2021-12-15 2:16 ` [PATCH net-next v9 1/6] stmmac: dwmac-mediatek: add platform level clocks management Biao Huang
2021-12-15 2:16 ` [PATCH net-next v9 2/6] stmmac: dwmac-mediatek: Reuse more common features Biao Huang
2021-12-15 2:16 ` [PATCH net-next v9 3/6] arm64: dts: mt2712: update ethernet device node Biao Huang
2021-12-15 2:16 ` [PATCH net-next v9 4/6] net: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema Biao Huang
2021-12-15 14:01 ` Rob Herring
2021-12-15 2:16 ` [PATCH net-next v9 5/6] stmmac: dwmac-mediatek: add support for mt8195 Biao Huang
2021-12-15 2:16 ` [PATCH net-next v9 6/6] net: dt-bindings: dwmac: " Biao Huang
2021-12-15 22:13 ` Rob Herring
2021-12-16 2:34 ` Biao Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151fc4556ba03703dffa30aeb8f24aee489c855c.camel@mediatek.com \
--to=biao.huang@mediatek.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dkirjanov@suse.de \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).