From: Li Jun <jun.li@nxp.com>
To: robh+dt@kernel.org, gregkh@linuxfoundation.org,
heikki.krogerus@linux.intel.com, linux@roeck-us.net
Cc: jun.li@nxp.com, a.hajda@samsung.com, cw00.choi@samsung.com,
shufan_lee@richtek.com, peter.chen@nxp.com, gsomlo@gmail.com,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-imx@nxp.com
Subject: [PATCH v5 12/14] staging: typec: tcpci: keep the not connecting cc line open
Date: Thu, 3 May 2018 08:24:52 +0800 [thread overview]
Message-ID: <1525307094-27402-13-git-send-email-jun.li@nxp.com> (raw)
In-Reply-To: <1525307094-27402-1-git-send-email-jun.li@nxp.com>
While set polarity, we should keep the not connecting cc line to be
open.
Signed-off-by: Li Jun <jun.li@nxp.com>
---
drivers/staging/typec/tcpci.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 5c48810..5c0c5e3 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c
@@ -185,15 +185,25 @@ static int tcpci_set_polarity(struct tcpc_dev *tcpc,
enum typec_cc_polarity polarity)
{
struct tcpci *tcpci = tcpc_to_tcpci(tcpc);
+ unsigned int reg;
int ret;
- ret = regmap_write(tcpci->regmap, TCPC_TCPC_CTRL,
- (polarity == TYPEC_POLARITY_CC2) ?
- TCPC_TCPC_CTRL_ORIENTATION : 0);
+ /* Keep the disconnect cc line open */
+ ret = regmap_read(tcpci->regmap, TCPC_ROLE_CTRL, ®);
if (ret < 0)
return ret;
- return 0;
+ if (polarity == TYPEC_POLARITY_CC2)
+ reg |= TCPC_ROLE_CTRL_CC_OPEN << TCPC_ROLE_CTRL_CC1_SHIFT;
+ else
+ reg |= TCPC_ROLE_CTRL_CC_OPEN << TCPC_ROLE_CTRL_CC2_SHIFT;
+ ret = regmap_write(tcpci->regmap, TCPC_ROLE_CTRL, reg);
+ if (ret < 0)
+ return ret;
+
+ return regmap_write(tcpci->regmap, TCPC_TCPC_CTRL,
+ (polarity == TYPEC_POLARITY_CC2) ?
+ TCPC_TCPC_CTRL_ORIENTATION : 0);
}
static int tcpci_set_vconn(struct tcpc_dev *tcpc, bool enable)
--
2.7.4
next prev parent reply other threads:[~2018-05-03 0:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 0:24 [PATCH v5 00/14] staging: typec: tcpci: move out of staging Li Jun
2018-05-03 0:24 ` [PATCH v5 01/14] dt-bindings: connector: add properties for typec Li Jun
2018-05-03 7:27 ` Oliver Neukum
2018-05-03 8:35 ` Jun Li
2018-05-03 9:17 ` Oliver Neukum
2018-05-04 8:59 ` Jun Li
2018-05-08 10:03 ` Oliver Neukum
2018-05-10 0:43 ` Jun Li
2018-05-07 15:58 ` Rob Herring
2018-05-08 5:36 ` Jun Li
2018-05-11 19:49 ` Mats Karrman
2018-05-14 9:06 ` Jun Li
2018-05-16 7:21 ` Peter Chen
2018-05-17 13:16 ` Jun Li
2018-05-03 0:24 ` [PATCH v5 02/14] dt-bindings: usb: add documentation for typec port controller(TCPCI) Li Jun
2018-05-07 16:01 ` Rob Herring
2018-05-03 0:24 ` [PATCH v5 03/14] staging: typec: tcpci: add compatible string for nxp ptn5110 Li Jun
2018-05-11 19:51 ` Mats Karrman
2018-05-14 9:15 ` Jun Li
2018-05-03 0:24 ` [PATCH v5 04/14] usb: typec: add fwnode to tcpc Li Jun
2018-05-03 0:24 ` [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config Li Jun
2018-05-11 19:55 ` Mats Karrman
2018-05-14 9:36 ` Jun Li
2018-05-15 20:52 ` Mats Karrman
2018-05-16 12:25 ` Heikki Krogerus
2018-05-16 20:55 ` Mats Karrman
2018-05-17 12:35 ` Heikki Krogerus
2018-05-17 14:05 ` Jun Li
2018-05-17 14:24 ` Heikki Krogerus
2018-05-17 14:41 ` Jun Li
2018-05-21 13:12 ` Heikki Krogerus
2018-05-22 14:19 ` Jun Li
2018-05-17 13:53 ` Jun Li
2018-05-17 13:26 ` Jun Li
2018-05-17 13:16 ` Jun Li
2018-05-03 0:24 ` [PATCH v5 06/14] usb: typec: tcpm: support get typec and pd config from device properties Li Jun
2018-05-03 0:24 ` [PATCH v5 07/14] staging: typec: tcpci: remove unused tcpci_tcpc_config Li Jun
2018-05-03 0:24 ` [PATCH v5 08/14] staging: typec: tcpci: register port before request irq Li Jun
2018-05-03 8:29 ` Sergei Shtylyov
2018-05-03 8:34 ` Sergei Shtylyov
2018-05-03 0:24 ` [PATCH v5 09/14] staging: typec: tcpci: enable vbus detection Li Jun
2018-05-03 0:24 ` [PATCH v5 10/14] typec: tcpm: add starting value for drp toggling Li Jun
2018-05-03 0:24 ` [PATCH v5 11/14] usb: typec: tcpm: set cc for drp toggling attach Li Jun
2018-05-03 0:24 ` Li Jun [this message]
2018-05-16 8:35 ` [PATCH v5 12/14] staging: typec: tcpci: keep the not connecting cc line open Peter Chen
2018-05-17 13:17 ` Jun Li
2018-05-03 0:24 ` [PATCH v5 13/14] staging: typec: tcpci: Only touch target bit when enable vconn Li Jun
2018-05-03 0:24 ` [PATCH v5 14/14] staging: typec: tcpci: move tcpci driver out of staging Li Jun
2018-05-11 21:37 ` Mats Karrman
2018-05-14 9:38 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525307094-27402-13-git-send-email-jun.li@nxp.com \
--to=jun.li@nxp.com \
--cc=a.hajda@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gsomlo@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).