From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v5 04/12] drm/mediatek: Add support for mmsys through a pdev Date: Mon, 19 Nov 2018 13:54:59 +0800 Message-ID: <1542606899.32082.15.camel@mtksdaap41> References: <20181116125449.23581-1-matthias.bgg@kernel.org> <20181116125449.23581-5-matthias.bgg@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181116125449.23581-5-matthias.bgg@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: matthias.bgg@kernel.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, sean.wang@kernel.org, Matthias Brugger , airlied@linux.ie, mturquette@baylibre.com, sean.wang@mediatek.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, matthias.bgg@gmail.com, wens@csie.org, robh+dt@kernel.org, rdunlap@infradead.org, laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGksIE1hdHRoaWFzOgoKT24gRnJpLCAyMDE4LTExLTE2IGF0IDEzOjU0ICswMTAwLCBtYXR0aGlh cy5iZ2dAa2VybmVsLm9yZyB3cm90ZToKPiBGcm9tOiBNYXR0aGlhcyBCcnVnZ2VyIDxtYnJ1Z2dl ckBzdXNlLmNvbT4KPiAKPiBUaGUgTU1TWVMgc3Vic3lzdGVtIGluY2x1ZGVzIGNsb2NrcyBhbmQg ZHJtIGNvbXBvbmVudHMuCj4gVGhpcyBwYXRjaCBhZGRzIGFuIGluaXRhaWxpemF0aW9uIHBhdGgg dGhyb3VnaCBhIHBsYXRmb3JtIGRldmljZQo+IGZvciB0aGUgY2xvY2sgcGFydCwgc28gdGhhdCBi b3RoIGRyaXZlcnMgZ2V0IHByb2JlZCBmcm9tIHRoZSBzYW1lCj4gZGV2aWNlIHRyZWUgY29tcGF0 aWJsZS4KCkxvb2tzIGdvb2QgdG8gbWUgZXhjZXB0IG9uZSBjb2Rpbmcgc3R5bGUgcHJlZmVyZW5j ZS4KClJldmlld2VkLWJ5OiBDSyBIdSA8Y2suaHVAbWVkaWF0ZWsuY29tPgoKPiAKPiBTaWduZWQt b2ZmLWJ5OiBNYXR0aGlhcyBCcnVnZ2VyIDxtYnJ1Z2dlckBzdXNlLmNvbT4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMgfCAyMyArKysrKysrKysrKysrKysr KysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuaCB8ICAyICsr Cj4gIDIgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9t ZWRpYXRlay9tdGtfZHJtX2Rydi5jCj4gaW5kZXggOTlkZDYxMmE2NjgzLi4xOGZjNzYxYmE5NGYg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYwo+IEBAIC0xOTksNiAr MTk5LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBtdGtfbW1zeXNfZHJpdmVyX2RhdGEgbXQyNzAx X21tc3lzX2RyaXZlcl9kYXRhID0gewo+ICAJLmV4dF9wYXRoID0gbXQyNzAxX210a19kZHBfZXh0 LAo+ICAJLmV4dF9sZW4gPSBBUlJBWV9TSVpFKG10MjcwMV9tdGtfZGRwX2V4dCksCj4gIAkuc2hh ZG93X3JlZ2lzdGVyID0gdHJ1ZSwKPiArCS5jbGtfZHJ2X25hbWUgPSAiY2xrLW10MjcwMS1tbSIs Cj4gIH07Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG10a19tbXN5c19kcml2ZXJfZGF0YSBt dDI3MTJfbW1zeXNfZHJpdmVyX2RhdGEgPSB7Cj4gQEAgLTIxNSw2ICsyMTYsNyBAQCBzdGF0aWMg Y29uc3Qgc3RydWN0IG10a19tbXN5c19kcml2ZXJfZGF0YSBtdDgxNzNfbW1zeXNfZHJpdmVyX2Rh dGEgPSB7Cj4gIAkubWFpbl9sZW4gPSBBUlJBWV9TSVpFKG10ODE3M19tdGtfZGRwX21haW4pLAo+ ICAJLmV4dF9wYXRoID0gbXQ4MTczX210a19kZHBfZXh0LAo+ICAJLmV4dF9sZW4gPSBBUlJBWV9T SVpFKG10ODE3M19tdGtfZGRwX2V4dCksCj4gKwkuY2xrX2Rydl9uYW1lID0gImNsay1tdDgxNzMt bW0iLAo+ICB9Owo+ICAKPiAgc3RhdGljIGludCBtdGtfZHJtX2ttc19pbml0KHN0cnVjdCBkcm1f ZGV2aWNlICpkcm0pCj4gQEAgLTQ3Myw2ICs0NzUsMjQgQEAgc3RhdGljIGludCBtdGtfZHJtX3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAlpZiAoSVNfRVJSKHByaXZhdGUt PmNvbmZpZ19yZWdzKSkKPiAgCQlyZXR1cm4gUFRSX0VSUihwcml2YXRlLT5jb25maWdfcmVncyk7 Cj4gIAo+ICsJLyoKPiArCSAqIEZvciBsZWdhY3kgcmVhc29ucyB3ZSBuZWVkIHRvIHByb2JlIHRo ZSBjbG9jayBkcml2ZXIgdmlhCj4gKwkgKiBhIHBsYXRmb21yIGRldmljZS4gVGhpcyBpcyBvdXRk YXRlZCBhbmQgc2hvdWxkIG5vdCBiZSB1c2VkCj4gKwkgKiBpbiBuZXdlciBTb0NzLgo+ICsJICov Cj4gKwlpZiAocHJpdmF0ZS0+ZGF0YS0+Y2xrX2Rydl9uYW1lKSB7Cj4gKwkJcHJpdmF0ZS0+Y2xr X2RldiA9IHBsYXRmb3JtX2RldmljZV9yZWdpc3Rlcl9kYXRhKGRldiwKPiArCQkJCQkJcHJpdmF0 ZS0+ZGF0YS0+Y2xrX2Rydl9uYW1lLCAtMSwKPiArCQkJCQkJTlVMTCwgMCk7Cj4gKwo+ICsJCWlm IChJU19FUlIocHJpdmF0ZS0+Y2xrX2RldikpIHsKPiArCQkJcHJfZXJyKCJmYWlsZWQgdG8gcmVn aXN0ZXIgJXMgcGxhdGZvcm0gZGV2aWNlXG4iLAo+ICsJCQkJCQlwcml2YXRlLT5kYXRhLT5jbGtf ZHJ2X25hbWUpOwoKSSB3b3VsZCBsaWtlIHRvIGFsaWduIHRvIHRoZSByaWdodCBvZiAnKCcuCgpS ZWdhcmRzLApDSwoKPiArCj4gKwkJCXJldHVybiBQVFJfRVJSKHByaXZhdGUtPmNsa19kZXYpOwo+ ICsJCX0KPiArCX0KPiArCj4gIAkvKiBJdGVyYXRlIG92ZXIgc2libGluZyBESVNQIGZ1bmN0aW9u IGJsb2NrcyAqLwo+ICAJZm9yX2VhY2hfY2hpbGRfb2Zfbm9kZShkZXYtPm9mX25vZGUtPnBhcmVu dCwgbm9kZSkgewo+ICAJCWNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgKm9mX2lkOwo+IEBAIC01 NzcsNiArNTk3LDkgQEAgc3RhdGljIGludCBtdGtfZHJtX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQo+ICAJZm9yIChpID0gMDsgaSA8IEREUF9DT01QT05FTlRfSURfTUFYOyBp KyspCj4gIAkJb2Zfbm9kZV9wdXQocHJpdmF0ZS0+Y29tcF9ub2RlW2ldKTsKPiAgCj4gKwlpZiAo cHJpdmF0ZS0+Y2xrX2RldikKPiArCQlwbGF0Zm9ybV9kZXZpY2VfdW5yZWdpc3Rlcihwcml2YXRl LT5jbGtfZGV2KTsKPiArCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vbWVk aWF0ZWsvbXRrX2RybV9kcnYuaAo+IGluZGV4IGFiMGFkYmQ3ZDRlZS4uNTE1YWM0Y2FlOTIyIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmgKPiBAQCAtMzcsMTEgKzM3 LDEzIEBAIHN0cnVjdCBtdGtfbW1zeXNfZHJpdmVyX2RhdGEgewo+ICAJdW5zaWduZWQgaW50IHRo aXJkX2xlbjsKPiAgCj4gIAlib29sIHNoYWRvd19yZWdpc3RlcjsKPiArCWNvbnN0IGNoYXIgKmNs a19kcnZfbmFtZTsKPiAgfTsKPiAgCj4gIHN0cnVjdCBtdGtfZHJtX3ByaXZhdGUgewo+ICAJc3Ry dWN0IGRybV9kZXZpY2UgKmRybTsKPiAgCXN0cnVjdCBkZXZpY2UgKmRtYV9kZXY7Cj4gKwlzdHJ1 Y3QgcGxhdGZvcm1fZGV2aWNlICpjbGtfZGV2Owo+ICAKPiAgCXVuc2lnbmVkIGludCBudW1fcGlw ZXM7Cj4gIAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=