From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [v5 1/7] drm/mediatek: move mipi_dsi_host_register to probe Date: Fri, 28 Jun 2019 14:10:59 +0800 Message-ID: <1561702259.18399.7.camel@mtksdaap41> References: <20190627080116.40264-1-jitao.shi@mediatek.com> <20190627080116.40264-2-jitao.shi@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190627080116.40264-2-jitao.shi@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jitao Shi Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , stonea168@163.com, dri-devel@lists.freedesktop.org, yingjoe.chen@mediatek.com, Ajay Kumar , Vincent Palatin , cawa.cheng@mediatek.com, Russell King , Thierry Reding , linux-pwm@vger.kernel.org, Sascha Hauer , Pawel Moll , Ian Campbell , Rob Herring , linux-mediatek@lists.infradead.org, Andy Yan , Matthias Brugger , eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org, Rahul Sharma , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Sean Paul List-Id: devicetree@vger.kernel.org SGksIEppdGFvOgoKT24gVGh1LCAyMDE5LTA2LTI3IGF0IDE2OjAxICswODAwLCBKaXRhbyBTaGkg d3JvdGU6Cj4gRFNJIHBhbmVsIGRyaXZlciBuZWVkIGF0dGFjaCBmdW5jdGlvbiB3aGljaCBpcyBp bmN1bGRlIGluCj4gbWlwaV9kc2lfaG9zdF9vcHMuCj4gCj4gSWYgbWlwaV9kc2lfaG9zdF9yZWdp c3RlciBpcyBub3QgaW4gcHJvYmUsIGRzaSBwYW5lbCB3aWxsCj4gcHJvYmUgbW9yZSBkZWxheS4K PiAKPiBTbyBtb3ZlIHRoZSBtaXBpX2RzaV9ob3N0X3JlZ2lzdGVyIHRvIHByb2JlIGZyb20gYmlu ZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKaXRhbyBTaGkgPGppdGFvLnNoaUBtZWRpYXRlay5jb20+ Cj4gUmV2aWV3ZWQtYnk6IENLIEh1IDxjay5odUBtZWRpYXRlay5jb20+CgpUaGlzIHZlcnNpb24g aXMgZGlmZmVyZW50IHRoYW4gdjQsIHNvIHBsZWFzZSByZW1vdmUgcmV2aWV3ZWQtYnkgdGFnIHdo ZW4KdGhpcyBwYXRjaCBjaGFuZ2UuIFdoZW4gSSBzZWUgYSByZXZpZXdlZC1ieSB0YWcgb2YgbWlu ZSwgSSB3b3VsZCBqdXN0CnNraXAgcmV2aWV3IGl0IGFnYWluIGJlY2F1c2UgSSBhc3N1bWUgdGhp cyBwYXRjaCBpcyB0aGUgc2FtZSBhcyBwcmV2aW91cwp2ZXJzaW9uLgoKRm9yIHRoaXMgdmVyc2lv biwgSSBnaXZlIHN0aWxsIGdpdmUgaXQgYQoKUmV2aWV3ZWQtYnk6IENLIEh1IDxjay5odUBtZWRp YXRlay5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RzaS5jIHwg NTMgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMSBp bnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL21lZGlhdGVrL210a19kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHNpLmMKPiBpbmRleCBiMDBlYjJkMmUwODYuLjU5NWIzYjA0N2M3YiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RzaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kc2kuYwo+IEBAIC01MjgsNyArNTI4LDcgQEAgc3RhdGljIHMzMiBtdGtf ZHNpX3N3aXRjaF90b19jbWRfbW9kZShzdHJ1Y3QgbXRrX2RzaSAqZHNpLCB1OCBpcnFfZmxhZywg dTMyIHQpCj4gIAo+ICBzdGF0aWMgaW50IG10a19kc2lfcG93ZXJvbihzdHJ1Y3QgbXRrX2RzaSAq ZHNpKQo+ICB7Cj4gLQlzdHJ1Y3QgZGV2aWNlICpkZXYgPSBkc2ktPmRldjsKPiArCXN0cnVjdCBk ZXZpY2UgKmRldiA9IGRzaS0+LT5ob3N0LmRldjsKPiAgCWludCByZXQ7Cj4gIAl1NjQgcGl4ZWxf Y2xvY2ssIHRvdGFsX2JpdHM7Cj4gIAl1MzIgaHRvdGFsLCBodG90YWxfYml0cywgYml0X3Blcl9w aXhlbCwgb3ZlcmhlYWRfY3ljbGVzLCBvdmVyaGVhZF9iaXRzOwo+IEBAIC0xMDQ1LDEyICsxMDQ1 LDYgQEAgc3RhdGljIGludCBtdGtfZHNpX2JpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3Qg ZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRhdGEpCj4gIAkJcmV0dXJuIHJldDsKPiAgCX0KPiAgCj4g LQlyZXQgPSBtaXBpX2RzaV9ob3N0X3JlZ2lzdGVyKCZkc2ktPmhvc3QpOwo+IC0JaWYgKHJldCA8 IDApIHsKPiAtCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byByZWdpc3RlciBEU0kgaG9zdDogJWRc biIsIHJldCk7Cj4gLQkJZ290byBlcnJfZGRwX2NvbXBfdW5yZWdpc3RlcjsKPiAtCX0KPiAtCj4g IAlyZXQgPSBtdGtfZHNpX2NyZWF0ZV9jb25uX2VuYyhkcm0sIGRzaSk7Cj4gIAlpZiAocmV0KSB7 Cj4gIAkJRFJNX0VSUk9SKCJFbmNvZGVyIGNyZWF0ZSBmYWlsZWQgd2l0aCAlZFxuIiwgcmV0KTsK PiBAQCAtMTA2MCw4ICsxMDU0LDYgQEAgc3RhdGljIGludCBtdGtfZHNpX2JpbmQoc3RydWN0IGRl dmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRhdGEpCj4gIAlyZXR1cm4g MDsKPiAgCj4gIGVycl91bnJlZ2lzdGVyOgo+IC0JbWlwaV9kc2lfaG9zdF91bnJlZ2lzdGVyKCZk c2ktPmhvc3QpOwo+IC1lcnJfZGRwX2NvbXBfdW5yZWdpc3RlcjoKPiAgCW10a19kZHBfY29tcF91 bnJlZ2lzdGVyKGRybSwgJmRzaS0+ZGRwX2NvbXApOwo+ICAJcmV0dXJuIHJldDsKPiAgfQo+IEBA IC0xMDczLDcgKzEwNjUsNiBAQCBzdGF0aWMgdm9pZCBtdGtfZHNpX3VuYmluZChzdHJ1Y3QgZGV2 aWNlICpkZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3RlciwKPiAgCXN0cnVjdCBtdGtfZHNpICpkc2kg PSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKPiAgCj4gIAltdGtfZHNpX2Rlc3Ryb3lfY29ubl9lbmMo ZHNpKTsKPiAtCW1pcGlfZHNpX2hvc3RfdW5yZWdpc3RlcigmZHNpLT5ob3N0KTsKPiAgCW10a19k ZHBfY29tcF91bnJlZ2lzdGVyKGRybSwgJmRzaS0+ZGRwX2NvbXApOwo+ICB9Cj4gIAo+IEBAIC0x MDk3LDMxICsxMDg4LDM2IEBAIHN0YXRpYyBpbnQgbXRrX2RzaV9wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQo+ICAKPiAgCWRzaS0+aG9zdC5vcHMgPSAmbXRrX2RzaV9vcHM7Cj4g IAlkc2ktPmhvc3QuZGV2ID0gZGV2Owo+ICsJcmV0ID0gbWlwaV9kc2lfaG9zdF9yZWdpc3Rlcigm ZHNpLT5ob3N0KTsKPiArCWlmIChyZXQgPCAwKSB7Cj4gKwkJZGV2X2VycihkZXYsICJmYWlsZWQg dG8gcmVnaXN0ZXIgRFNJIGhvc3Q6ICVkXG4iLCByZXQpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9 Cj4gIAo+ICAJcmV0ID0gZHJtX29mX2ZpbmRfcGFuZWxfb3JfYnJpZGdlKGRldi0+b2Zfbm9kZSwg MCwgMCwKPiAgCQkJCQkgICZkc2ktPnBhbmVsLCAmZHNpLT5icmlkZ2UpOwo+ICAJaWYgKHJldCkK PiAtCQlyZXR1cm4gcmV0Owo+ICsJCWdvdG8gZXJyX3VucmVnaXN0ZXJfaG9zdDsKPiAgCj4gIAlk c2ktPmVuZ2luZV9jbGsgPSBkZXZtX2Nsa19nZXQoZGV2LCAiZW5naW5lIik7Cj4gIAlpZiAoSVNf RVJSKGRzaS0+ZW5naW5lX2NsaykpIHsKPiAgCQlyZXQgPSBQVFJfRVJSKGRzaS0+ZW5naW5lX2Ns ayk7Cj4gIAkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0IGVuZ2luZSBjbG9jazogJWRcbiIs IHJldCk7Cj4gLQkJcmV0dXJuIHJldDsKPiArCQlnb3RvIGVycl91bnJlZ2lzdGVyX2hvc3Q7Cj4g IAl9Cj4gIAo+ICAJZHNpLT5kaWdpdGFsX2NsayA9IGRldm1fY2xrX2dldChkZXYsICJkaWdpdGFs Iik7Cj4gIAlpZiAoSVNfRVJSKGRzaS0+ZGlnaXRhbF9jbGspKSB7Cj4gIAkJcmV0ID0gUFRSX0VS Uihkc2ktPmRpZ2l0YWxfY2xrKTsKPiAgCQlkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBnZXQgZGln aXRhbCBjbG9jazogJWRcbiIsIHJldCk7Cj4gLQkJcmV0dXJuIHJldDsKPiArCQlnb3RvIGVycl91 bnJlZ2lzdGVyX2hvc3Q7Cj4gIAl9Cj4gIAo+ICAJZHNpLT5oc19jbGsgPSBkZXZtX2Nsa19nZXQo ZGV2LCAiaHMiKTsKPiAgCWlmIChJU19FUlIoZHNpLT5oc19jbGspKSB7Cj4gIAkJcmV0ID0gUFRS X0VSUihkc2ktPmhzX2Nsayk7Cj4gIAkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0IGhzIGNs b2NrOiAlZFxuIiwgcmV0KTsKPiAtCQlyZXR1cm4gcmV0Owo+ICsJCWdvdG8gZXJyX3VucmVnaXN0 ZXJfaG9zdDsKPiAgCX0KPiAgCj4gIAlyZWdzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYs IElPUkVTT1VSQ0VfTUVNLCAwKTsKPiBAQCAtMTEyOSwzMyArMTEyNSwzNSBAQCBzdGF0aWMgaW50 IG10a19kc2lfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCWlmIChJU19F UlIoZHNpLT5yZWdzKSkgewo+ICAJCXJldCA9IFBUUl9FUlIoZHNpLT5yZWdzKTsKPiAgCQlkZXZf ZXJyKGRldiwgIkZhaWxlZCB0byBpb3JlbWFwIG1lbW9yeTogJWRcbiIsIHJldCk7Cj4gLQkJcmV0 dXJuIHJldDsKPiArCQlnb3RvIGVycl91bnJlZ2lzdGVyX2hvc3Q7Cj4gIAl9Cj4gIAo+ICAJZHNp LT5waHkgPSBkZXZtX3BoeV9nZXQoZGV2LCAiZHBoeSIpOwo+ICAJaWYgKElTX0VSUihkc2ktPnBo eSkpIHsKPiAgCQlyZXQgPSBQVFJfRVJSKGRzaS0+cGh5KTsKPiAgCQlkZXZfZXJyKGRldiwgIkZh aWxlZCB0byBnZXQgTUlQSS1EUEhZOiAlZFxuIiwgcmV0KTsKPiAtCQlyZXR1cm4gcmV0Owo+ICsJ CWdvdG8gZXJyX3VucmVnaXN0ZXJfaG9zdDsKPiAgCX0KPiAgCj4gIAljb21wX2lkID0gbXRrX2Rk cF9jb21wX2dldF9pZChkZXYtPm9mX25vZGUsIE1US19EU0kpOwo+ICAJaWYgKGNvbXBfaWQgPCAw KSB7Cj4gIAkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gaWRlbnRpZnkgYnkgYWxpYXM6ICVkXG4i LCBjb21wX2lkKTsKPiAtCQlyZXR1cm4gY29tcF9pZDsKPiArCQlyZXQgPSBjb21wX2lkOwo+ICsJ CWdvdG8gZXJyX3VucmVnaXN0ZXJfaG9zdDsKPiAgCX0KPiAgCj4gIAlyZXQgPSBtdGtfZGRwX2Nv bXBfaW5pdChkZXYsIGRldi0+b2Zfbm9kZSwgJmRzaS0+ZGRwX2NvbXAsIGNvbXBfaWQsCj4gIAkJ CQkmbXRrX2RzaV9mdW5jcyk7Cj4gIAlpZiAocmV0KSB7Cj4gIAkJZGV2X2VycihkZXYsICJGYWls ZWQgdG8gaW5pdGlhbGl6ZSBjb21wb25lbnQ6ICVkXG4iLCByZXQpOwo+IC0JCXJldHVybiByZXQ7 Cj4gKwkJZ290byBlcnJfdW5yZWdpc3Rlcl9ob3N0Owo+ICAJfQo+ICAKPiAgCWlycV9udW0gPSBw bGF0Zm9ybV9nZXRfaXJxKHBkZXYsIDApOwo+ICAJaWYgKGlycV9udW0gPCAwKSB7Cj4gLQkJZGV2 X2VycigmcGRldi0+ZGV2LCAiZmFpbGVkIHRvIHJlcXVlc3QgZHNpIGlycSByZXNvdXJjZVxuIik7 Cj4gLQkJcmV0dXJuIC1FUFJPQkVfREVGRVI7Cj4gKwkJZGV2X2VycigmcGRldi0+ZGV2LCAiZmFp bGVkIHRvIGdldCBkc2kgaXJxX251bTogJWRcbiIsIGlycV9udW0pOwo+ICsJCXJldCA9IGlycV9u dW07Cj4gKwkJZ290byBlcnJfdW5yZWdpc3Rlcl9ob3N0Owo+ICAJfQo+ICAKPiAgCWlycV9zZXRf c3RhdHVzX2ZsYWdzKGlycV9udW0sIElSUV9UWVBFX0xFVkVMX0xPVyk7Cj4gQEAgLTExNjMsMTQg KzExNjEsMjQgQEAgc3RhdGljIGludCBtdGtfZHNpX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKnBkZXYpCj4gIAkJCSAgICAgICBJUlFGX1RSSUdHRVJfTE9XLCBkZXZfbmFtZSgmcGRldi0+ ZGV2KSwgZHNpKTsKPiAgCWlmIChyZXQpIHsKPiAgCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJmYWls ZWQgdG8gcmVxdWVzdCBtZWRpYXRlayBkc2kgaXJxXG4iKTsKPiAtCQlyZXR1cm4gLUVQUk9CRV9E RUZFUjsKPiArCQlnb3RvIGVycl91bnJlZ2lzdGVyX2hvc3Q7Cj4gIAl9Cj4gIAo+ICAJaW5pdF93 YWl0cXVldWVfaGVhZCgmZHNpLT5pcnFfd2FpdF9xdWV1ZSk7Cj4gIAo+ICAJcGxhdGZvcm1fc2V0 X2RydmRhdGEocGRldiwgZHNpKTsKPiAgCj4gLQlyZXR1cm4gY29tcG9uZW50X2FkZCgmcGRldi0+ ZGV2LCAmbXRrX2RzaV9jb21wb25lbnRfb3BzKTsKPiArCXJldCA9IGNvbXBvbmVudF9hZGQoJnBk ZXYtPmRldiwgJm10a19kc2lfY29tcG9uZW50X29wcyk7Cj4gKwlpZiAocmV0KSB7Cj4gKwkJZGV2 X2VycigmcGRldi0+ZGV2LCAiZmFpbGVkIHRvIGFkZCBjb21wb25lbnQ6ICVkXG4iLCByZXQpOwo+ ICsJCWdvdG8gZXJyX3VucmVnaXN0ZXJfaG9zdDsKPiArCX0KPiArCj4gKwlyZXR1cm4gMDsKPiAr Cj4gK2Vycl91bnJlZ2lzdGVyX2hvc3Q6Cj4gKwltaXBpX2RzaV9ob3N0X3VucmVnaXN0ZXIoJmRz aS0+aG9zdCk7Cj4gKwlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IG10a19kc2lf cmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gQEAgLTExNzksNiArMTE4Nyw3 IEBAIHN0YXRpYyBpbnQgbXRrX2RzaV9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKPiAgCj4gIAltdGtfb3V0cHV0X2RzaV9kaXNhYmxlKGRzaSk7Cj4gIAljb21wb25lbnRfZGVs KCZwZGV2LT5kZXYsICZtdGtfZHNpX2NvbXBvbmVudF9vcHMpOwo+ICsJbWlwaV9kc2lfaG9zdF91 bnJlZ2lzdGVyKCZkc2ktPmhvc3QpOwo+ICAKPiAgCXJldHVybiAwOwo+ICB9CgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs