* [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list
@ 2019-12-09 10:19 Eugen.Hristev
2019-12-09 10:20 ` [PATCH v3 2/4] i2c: at91: fix clk_offset for sam9x60 Eugen.Hristev
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Eugen.Hristev @ 2019-12-09 10:19 UTC (permalink / raw)
To: robh, Ludovic.Desroches, wsa
Cc: peda, linux-i2c, devicetree, linux-arm-kernel, linux-kernel,
Codrin.Ciubotariu, Eugen.Hristev
From: Eugen Hristev <eugen.hristev@microchip.com>
Format the list of compatibles with one compatible per line.
Suggested-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
---
Documentation/devicetree/bindings/i2c/i2c-at91.txt | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
index 2210f43..d35cd63 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-at91.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
@@ -1,10 +1,16 @@
I2C for Atmel platforms
Required properties :
-- compatible : Must be "atmel,at91rm9200-i2c", "atmel,at91sam9261-i2c",
- "atmel,at91sam9260-i2c", "atmel,at91sam9g20-i2c", "atmel,at91sam9g10-i2c",
- "atmel,at91sam9x5-i2c", "atmel,sama5d4-i2c", "atmel,sama5d2-i2c" or
- "microchip,sam9x60-i2c"
+- compatible : Must be one of:
+ "atmel,at91rm9200-i2c",
+ "atmel,at91sam9261-i2c",
+ "atmel,at91sam9260-i2c",
+ "atmel,at91sam9g20-i2c",
+ "atmel,at91sam9g10-i2c",
+ "atmel,at91sam9x5-i2c",
+ "atmel,sama5d4-i2c",
+ "atmel,sama5d2-i2c",
+ "microchip,sam9x60-i2c".
- reg: physical base address of the controller and length of memory mapped
region.
- interrupts: interrupt number to the cpu.
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 2/4] i2c: at91: fix clk_offset for sam9x60
2019-12-09 10:19 [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Eugen.Hristev
@ 2019-12-09 10:20 ` Eugen.Hristev
2020-01-06 14:35 ` Wolfram Sang
2019-12-09 10:20 ` [PATCH v3 3/4] i2c: at91: remote default value initialization Eugen.Hristev
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Eugen.Hristev @ 2019-12-09 10:20 UTC (permalink / raw)
To: robh, Ludovic.Desroches, wsa
Cc: peda, linux-i2c, devicetree, linux-arm-kernel, linux-kernel,
Codrin.Ciubotariu, Eugen.Hristev
From: Eugen Hristev <eugen.hristev@microchip.com>
In SAM9X60 datasheet, FLEX_TWI_CWGR register description mentions clock
offset of 3 cycles (compared to 4 in eg. SAMA5D3).
This is the same offset as in SAMA5D2.
Fixes: b00277923743 ("i2c: at91: add new platform support for sam9x60")
Suggested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---
Changes in v3:
- fixed typo in commit description
Changes in v2:
- Sorry, wrong subject line. Modified to SAM9X60 .
drivers/i2c/busses/i2c-at91-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c
index e13af48..5137e62 100644
--- a/drivers/i2c/busses/i2c-at91-core.c
+++ b/drivers/i2c/busses/i2c-at91-core.c
@@ -174,7 +174,7 @@ static struct at91_twi_pdata sama5d2_config = {
static struct at91_twi_pdata sam9x60_config = {
.clk_max_div = 7,
- .clk_offset = 4,
+ .clk_offset = 3,
.has_unre_flag = true,
.has_alt_cmd = true,
.has_hold_field = true,
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 3/4] i2c: at91: remote default value initialization
2019-12-09 10:19 [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Eugen.Hristev
2019-12-09 10:20 ` [PATCH v3 2/4] i2c: at91: fix clk_offset for sam9x60 Eugen.Hristev
@ 2019-12-09 10:20 ` Eugen.Hristev
2020-01-06 14:35 ` Wolfram Sang
2019-12-09 10:20 ` [PATCH v3 4/4] dt-bindings: i2c: at91: fix i2c-sda-hold-time-ns documentation for sam9x60 Eugen.Hristev
2019-12-18 21:37 ` [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Rob Herring
3 siblings, 1 reply; 10+ messages in thread
From: Eugen.Hristev @ 2019-12-09 10:20 UTC (permalink / raw)
To: robh, Ludovic.Desroches, wsa
Cc: peda, linux-i2c, devicetree, linux-arm-kernel, linux-kernel,
Codrin.Ciubotariu, Eugen.Hristev
From: Eugen Hristev <eugen.hristev@microchip.com>
Platform data structs are initialized by default with zero values.
Thus it becomes redundant to initialize them manually to zero (false).
Remove extra false initialization for field members in structs.
Suggested-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Reviewed-by: Ludovic Desroches <ludovic.desroches@microchip.com>
---
drivers/i2c/busses/i2c-at91-core.c | 39 --------------------------------------
1 file changed, 39 deletions(-)
diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c
index 5137e62..3da1a8a 100644
--- a/drivers/i2c/busses/i2c-at91-core.c
+++ b/drivers/i2c/busses/i2c-at91-core.c
@@ -66,55 +66,26 @@ static struct at91_twi_pdata at91rm9200_config = {
.clk_max_div = 5,
.clk_offset = 3,
.has_unre_flag = true,
- .has_alt_cmd = false,
- .has_hold_field = false,
- .has_dig_filtr = false,
- .has_adv_dig_filtr = false,
- .has_ana_filtr = false,
};
static struct at91_twi_pdata at91sam9261_config = {
.clk_max_div = 5,
.clk_offset = 4,
- .has_unre_flag = false,
- .has_alt_cmd = false,
- .has_hold_field = false,
- .has_dig_filtr = false,
- .has_adv_dig_filtr = false,
- .has_ana_filtr = false,
};
static struct at91_twi_pdata at91sam9260_config = {
.clk_max_div = 7,
.clk_offset = 4,
- .has_unre_flag = false,
- .has_alt_cmd = false,
- .has_hold_field = false,
- .has_dig_filtr = false,
- .has_adv_dig_filtr = false,
- .has_ana_filtr = false,
};
static struct at91_twi_pdata at91sam9g20_config = {
.clk_max_div = 7,
.clk_offset = 4,
- .has_unre_flag = false,
- .has_alt_cmd = false,
- .has_hold_field = false,
- .has_dig_filtr = false,
- .has_adv_dig_filtr = false,
- .has_ana_filtr = false,
};
static struct at91_twi_pdata at91sam9g10_config = {
.clk_max_div = 7,
.clk_offset = 4,
- .has_unre_flag = false,
- .has_alt_cmd = false,
- .has_hold_field = false,
- .has_dig_filtr = false,
- .has_adv_dig_filtr = false,
- .has_ana_filtr = false,
};
static const struct platform_device_id at91_twi_devtypes[] = {
@@ -142,23 +113,13 @@ static const struct platform_device_id at91_twi_devtypes[] = {
static struct at91_twi_pdata at91sam9x5_config = {
.clk_max_div = 7,
.clk_offset = 4,
- .has_unre_flag = false,
- .has_alt_cmd = false,
- .has_hold_field = false,
- .has_dig_filtr = false,
- .has_adv_dig_filtr = false,
- .has_ana_filtr = false,
};
static struct at91_twi_pdata sama5d4_config = {
.clk_max_div = 7,
.clk_offset = 4,
- .has_unre_flag = false,
- .has_alt_cmd = false,
.has_hold_field = true,
.has_dig_filtr = true,
- .has_adv_dig_filtr = false,
- .has_ana_filtr = false,
};
static struct at91_twi_pdata sama5d2_config = {
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 4/4] dt-bindings: i2c: at91: fix i2c-sda-hold-time-ns documentation for sam9x60
2019-12-09 10:19 [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Eugen.Hristev
2019-12-09 10:20 ` [PATCH v3 2/4] i2c: at91: fix clk_offset for sam9x60 Eugen.Hristev
2019-12-09 10:20 ` [PATCH v3 3/4] i2c: at91: remote default value initialization Eugen.Hristev
@ 2019-12-09 10:20 ` Eugen.Hristev
2019-12-18 21:37 ` Rob Herring
2020-01-06 14:35 ` Wolfram Sang
2019-12-18 21:37 ` [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Rob Herring
3 siblings, 2 replies; 10+ messages in thread
From: Eugen.Hristev @ 2019-12-09 10:20 UTC (permalink / raw)
To: robh, Ludovic.Desroches, wsa
Cc: peda, linux-i2c, devicetree, linux-arm-kernel, linux-kernel,
Codrin.Ciubotariu, Eugen.Hristev
From: Eugen Hristev <eugen.hristev@microchip.com>
SAM9X60 also supports i2c-sda-hold-time-ns. Fix the documentation accordingly.
Fixes: 2034e3f4c9a5 ("dt-bindings: i2c: at91: add new compatible")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
Changes in v3:
- new patch
Documentation/devicetree/bindings/i2c/i2c-at91.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
index d35cd63..d4bad86 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-at91.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
@@ -24,8 +24,10 @@ Optional properties:
- dma-names: should contain "tx" and "rx".
- atmel,fifo-size: maximum number of data the RX and TX FIFOs can store for FIFO
capable I2C controllers.
-- i2c-sda-hold-time-ns: TWD hold time, only available for "atmel,sama5d4-i2c"
- and "atmel,sama5d2-i2c".
+- i2c-sda-hold-time-ns: TWD hold time, only available for:
+ "atmel,sama5d4-i2c",
+ "atmel,sama5d2-i2c",
+ "microchip,sam9x60-i2c".
- Child nodes conforming to i2c bus binding
Examples :
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list
2019-12-09 10:19 [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Eugen.Hristev
` (2 preceding siblings ...)
2019-12-09 10:20 ` [PATCH v3 4/4] dt-bindings: i2c: at91: fix i2c-sda-hold-time-ns documentation for sam9x60 Eugen.Hristev
@ 2019-12-18 21:37 ` Rob Herring
2020-01-06 14:35 ` Wolfram Sang
3 siblings, 1 reply; 10+ messages in thread
From: Rob Herring @ 2019-12-18 21:37 UTC (permalink / raw)
To: Eugen.Hristev
Cc: robh, Ludovic.Desroches, wsa, peda, linux-i2c, devicetree,
linux-arm-kernel, linux-kernel, Codrin.Ciubotariu, Eugen.Hristev
On Mon, 9 Dec 2019 10:19:59 +0000, <Eugen.Hristev@microchip.com> wrote:
>
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> Format the list of compatibles with one compatible per line.
>
> Suggested-by: Peter Rosin <peda@axentia.se>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-at91.txt | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 4/4] dt-bindings: i2c: at91: fix i2c-sda-hold-time-ns documentation for sam9x60
2019-12-09 10:20 ` [PATCH v3 4/4] dt-bindings: i2c: at91: fix i2c-sda-hold-time-ns documentation for sam9x60 Eugen.Hristev
@ 2019-12-18 21:37 ` Rob Herring
2020-01-06 14:35 ` Wolfram Sang
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2019-12-18 21:37 UTC (permalink / raw)
To: Eugen.Hristev
Cc: robh, Ludovic.Desroches, wsa, peda, linux-i2c, devicetree,
linux-arm-kernel, linux-kernel, Codrin.Ciubotariu, Eugen.Hristev
On Mon, 9 Dec 2019 10:20:07 +0000, <Eugen.Hristev@microchip.com> wrote:
>
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> SAM9X60 also supports i2c-sda-hold-time-ns. Fix the documentation accordingly.
>
> Fixes: 2034e3f4c9a5 ("dt-bindings: i2c: at91: add new compatible")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> Changes in v3:
> - new patch
>
> Documentation/devicetree/bindings/i2c/i2c-at91.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 2/4] i2c: at91: fix clk_offset for sam9x60
2019-12-09 10:20 ` [PATCH v3 2/4] i2c: at91: fix clk_offset for sam9x60 Eugen.Hristev
@ 2020-01-06 14:35 ` Wolfram Sang
0 siblings, 0 replies; 10+ messages in thread
From: Wolfram Sang @ 2020-01-06 14:35 UTC (permalink / raw)
To: Eugen.Hristev
Cc: robh, Ludovic.Desroches, peda, linux-i2c, devicetree,
linux-arm-kernel, linux-kernel, Codrin.Ciubotariu
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Mon, Dec 09, 2019 at 10:20:02AM +0000, Eugen.Hristev@microchip.com wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> In SAM9X60 datasheet, FLEX_TWI_CWGR register description mentions clock
> offset of 3 cycles (compared to 4 in eg. SAMA5D3).
> This is the same offset as in SAMA5D2.
>
> Fixes: b00277923743 ("i2c: at91: add new platform support for sam9x60")
> Suggested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 3/4] i2c: at91: remote default value initialization
2019-12-09 10:20 ` [PATCH v3 3/4] i2c: at91: remote default value initialization Eugen.Hristev
@ 2020-01-06 14:35 ` Wolfram Sang
0 siblings, 0 replies; 10+ messages in thread
From: Wolfram Sang @ 2020-01-06 14:35 UTC (permalink / raw)
To: Eugen.Hristev
Cc: robh, Ludovic.Desroches, peda, linux-i2c, devicetree,
linux-arm-kernel, linux-kernel, Codrin.Ciubotariu
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
On Mon, Dec 09, 2019 at 10:20:05AM +0000, Eugen.Hristev@microchip.com wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> Platform data structs are initialized by default with zero values.
> Thus it becomes redundant to initialize them manually to zero (false).
> Remove extra false initialization for field members in structs.
>
> Suggested-by: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> Reviewed-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 4/4] dt-bindings: i2c: at91: fix i2c-sda-hold-time-ns documentation for sam9x60
2019-12-09 10:20 ` [PATCH v3 4/4] dt-bindings: i2c: at91: fix i2c-sda-hold-time-ns documentation for sam9x60 Eugen.Hristev
2019-12-18 21:37 ` Rob Herring
@ 2020-01-06 14:35 ` Wolfram Sang
1 sibling, 0 replies; 10+ messages in thread
From: Wolfram Sang @ 2020-01-06 14:35 UTC (permalink / raw)
To: Eugen.Hristev
Cc: robh, Ludovic.Desroches, peda, linux-i2c, devicetree,
linux-arm-kernel, linux-kernel, Codrin.Ciubotariu
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
On Mon, Dec 09, 2019 at 10:20:07AM +0000, Eugen.Hristev@microchip.com wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> SAM9X60 also supports i2c-sda-hold-time-ns. Fix the documentation accordingly.
>
> Fixes: 2034e3f4c9a5 ("dt-bindings: i2c: at91: add new compatible")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list
2019-12-18 21:37 ` [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Rob Herring
@ 2020-01-06 14:35 ` Wolfram Sang
0 siblings, 0 replies; 10+ messages in thread
From: Wolfram Sang @ 2020-01-06 14:35 UTC (permalink / raw)
To: Rob Herring
Cc: Eugen.Hristev, Ludovic.Desroches, peda, linux-i2c, devicetree,
linux-arm-kernel, linux-kernel, Codrin.Ciubotariu
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On Wed, Dec 18, 2019 at 03:37:16PM -0600, Rob Herring wrote:
> On Mon, 9 Dec 2019 10:19:59 +0000, <Eugen.Hristev@microchip.com> wrote:
> >
> > From: Eugen Hristev <eugen.hristev@microchip.com>
> >
> > Format the list of compatibles with one compatible per line.
> >
> > Suggested-by: Peter Rosin <peda@axentia.se>
> > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> > Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-01-06 14:35 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 10:19 [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Eugen.Hristev
2019-12-09 10:20 ` [PATCH v3 2/4] i2c: at91: fix clk_offset for sam9x60 Eugen.Hristev
2020-01-06 14:35 ` Wolfram Sang
2019-12-09 10:20 ` [PATCH v3 3/4] i2c: at91: remote default value initialization Eugen.Hristev
2020-01-06 14:35 ` Wolfram Sang
2019-12-09 10:20 ` [PATCH v3 4/4] dt-bindings: i2c: at91: fix i2c-sda-hold-time-ns documentation for sam9x60 Eugen.Hristev
2019-12-18 21:37 ` Rob Herring
2020-01-06 14:35 ` Wolfram Sang
2019-12-18 21:37 ` [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Rob Herring
2020-01-06 14:35 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).