devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5 0/4] IT6505 cover letter
@ 2019-12-10  5:53 allen
  2019-12-10  5:53 ` [PATCH v5 1/4] dt-bindings: Add vendor prefix for ITE Tech. Inc allen
  2019-12-10  5:53 ` [PATCH v5 3/4] dt-bindings: Add binding for IT6505 allen
  0 siblings, 2 replies; 6+ messages in thread
From: allen @ 2019-12-10  5:53 UTC (permalink / raw)
  Cc: Allen Chen, Pi-Hsun Shih, Jau-Chih Tseng,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:DRM DRIVERS, Heiko Stuebner, Icenowy Zheng,
	Jarkko Sakkinen, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
	Laurent Pinchart, moderated list:ARM/Mediatek SoC support,
	open list, moderated list:ARM/Mediatek SoC support,
	open list:DRM DRIVERS FOR NVIDIA TEGRA, Maxime Ripard,
	Rob Herring, Shawn Guo

The IT6505 is a high-performance DisplayPort 1.1a transmitter, fully compliant
with DisplayPort 1.1a, HDCP 1.3 specifications. The IT6505 supports color depth
of up to 36 bits (12 bits/color) and ensures robust transmission of high-quality
uncompressed video content, along with uncompressed and compressed digital audio
content.

This series contains document bindings, revert commit, add vendor prefix,
Kconfig to control the function enable or not.

Allen Chen (1):
  WIP: drm/bridge: add it6505 driver

allen (3):
  dt-bindings: Add vendor prefix for ITE Tech. Inc.
  Revert "drm/tegra: Move drm_dp_link helpers to Tegra DRM"
  WIP: dt-bindings: Add binding for IT6505.

 .../bindings/display/bridge/ite,it6505.yaml        |   99 +
 .../devicetree/bindings/vendor-prefixes.yaml       |    2 +
 drivers/gpu/drm/bridge/Kconfig                     |    7 +
 drivers/gpu/drm/bridge/Makefile                    |    1 +
 drivers/gpu/drm/bridge/ite-it6505.c                | 2753 ++++++++++++++++++++
 drivers/gpu/drm/drm_dp_helper.c                    |  128 +
 drivers/gpu/drm/tegra/Makefile                     |    1 -
 drivers/gpu/drm/tegra/dp.c                         |  876 -------
 drivers/gpu/drm/tegra/dp.h                         |  177 --
 drivers/gpu/drm/tegra/dpaux.c                      |    1 -
 drivers/gpu/drm/tegra/sor.c                        |    1 -
 include/drm/drm_dp_helper.h                        |   16 +
 12 files changed, 3006 insertions(+), 1056 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
 create mode 100644 drivers/gpu/drm/bridge/ite-it6505.c
 delete mode 100644 drivers/gpu/drm/tegra/dp.c
 delete mode 100644 drivers/gpu/drm/tegra/dp.h

-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v5 1/4] dt-bindings: Add vendor prefix for ITE Tech. Inc.
  2019-12-10  5:53 [PATCH v5 0/4] IT6505 cover letter allen
@ 2019-12-10  5:53 ` allen
  2019-12-18 20:24   ` Rob Herring
  2019-12-10  5:53 ` [PATCH v5 3/4] dt-bindings: Add binding for IT6505 allen
  1 sibling, 1 reply; 6+ messages in thread
From: allen @ 2019-12-10  5:53 UTC (permalink / raw)
  Cc: Allen Chen, Pi-Hsun Shih, Jau-Chih Tseng, Rob Herring,
	Mark Rutland, Maxime Ripard, Shawn Guo, Heiko Stuebner,
	Hans Verkuil, Icenowy Zheng, Laurent Pinchart,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

ITE Tech. Inc. (abbreviated as ITE ) is a professional fabless IC
design house. ITE's core technology includes PC and NB Controller chips,
Super I/O, High Speed Serial Interface, Video Codec, Touch Sensing,
Surveillance, OFDM, Sensor Fusion, and so on.

more information on: http://www.ite.com.tw/

Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 6046f45..552f5ef 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -463,6 +463,8 @@ patternProperties:
     description: Intersil
   "^issi,.*":
     description: Integrated Silicon Solutions Inc.
+  "^ite,.*":
+    description: ITE Tech. Inc.
   "^itead,.*":
     description: ITEAD Intelligent Systems Co.Ltd
   "^iwave,.*":
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v5 3/4] dt-bindings: Add binding for IT6505.
  2019-12-10  5:53 [PATCH v5 0/4] IT6505 cover letter allen
  2019-12-10  5:53 ` [PATCH v5 1/4] dt-bindings: Add vendor prefix for ITE Tech. Inc allen
@ 2019-12-10  5:53 ` allen
  2019-12-14  8:21   ` Sam Ravnborg
  1 sibling, 1 reply; 6+ messages in thread
From: allen @ 2019-12-10  5:53 UTC (permalink / raw)
  Cc: Allen Chen, Pi-Hsun Shih, Jau-Chih Tseng, David Airlie,
	Daniel Vetter, Rob Herring, Mark Rutland, open list:DRM DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

Add a DT binding documentation for IT6505.

Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
---
 .../bindings/display/bridge/ite,it6505.yaml        | 99 ++++++++++++++++++++++
 1 file changed, 99 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml

diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
new file mode 100644
index 00000000..23a106a
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
@@ -0,0 +1,99 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/ite,it6505.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ITE it6505 Device Tree Bindings
+
+maintainers:
+  - Allen Chen <allen.chen@ite.com.tw>
+
+description: |
+  The IT6505 is a high-performance DisplayPort 1.1a transmitter,
+fully compliant with DisplayPort 1.1a, HDCP 1.3 specifications.
+The IT6505 supports color depth of up to 36 bits (12 bits/color)
+and ensures robust transmission of high-quality uncompressed video
+content, along with uncompressed and compressed digital audio content.
+
+  Aside from the various video output formats supported, the IT6505
+also encodes and transmits up to 8 channels of I2S digital audio,
+with sampling rate up to 192kHz and sample size up to 24 bits.
+In addition, an S/PDIF input port takes in compressed audio of up to
+192kHz frame rate.
+
+  Each IT6505 chip comes preprogrammed with an unique HDCP key,
+in compliance with the HDCP 1.3 standard so as to provide secure
+transmission of high-definition content. Users of the IT6505 need not
+purchase any HDCP keys or ROMs.
+
+properties:
+  compatible:
+    const: ite,it6505
+
+  reg:
+    - maxItems: 1
+    - description: i2c address of the bridge
+
+  ovdd-supply:
+    - maxItems: 1
+    - description: I/O voltage
+
+  pwr18-supply:
+    - maxItems: 1
+    - description: core voltage
+
+  interrupts:
+    - maxItems: 1
+    - description: interrupt specifier of INT pin
+
+  reset-gpios:
+    - maxItems: 1
+    - description: gpio specifier of RESET pin
+
+  hpd-gpios:
+    - maxItems: 1
+    - description:
+        - Hotplug detect GPIO
+        - Indicates which GPIO should be used for hotplug detection
+
+  extcon:
+    - maxItems: 1
+    - description: extcon specifier for the Power Delivery
+
+  port:
+    - type: object
+    - description: A port node pointing to DPI host port node
+
+required:
+  - compatible
+  - reg
+  - ovdd-supply
+  - pwr18-supply
+  - interrupts
+  - reset-gpios
+  - hpd-gpios
+  - extcon
+
+examples:
+  - |
+    dp-bridge@5c {
+        compatible = "ite,it6505";
+        interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>;
+        reg = <0x5c>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&it6505_pins>;
+        ovdd-supply = <&mt6358_vsim1_reg>;
+        pwr18-supply = <&it6505_pp18_reg>;
+        reset-gpios = <&pio 179 1>;
+        hpd-gpios = <&pio 9 0>;
+        extcon = <&usbc_extcon>;
+
+        port {
+            it6505_in: endpoint {
+                remote-endpoint = <&dpi_out>;
+            };
+        };
+    };
+
+---
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v5 3/4] dt-bindings: Add binding for IT6505.
  2019-12-10  5:53 ` [PATCH v5 3/4] dt-bindings: Add binding for IT6505 allen
@ 2019-12-14  8:21   ` Sam Ravnborg
  2019-12-18 20:29     ` Rob Herring
  0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2019-12-14  8:21 UTC (permalink / raw)
  To: allen
  Cc: Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Pi-Hsun Shih, Jau-Chih Tseng, David Airlie, open list,
	open list:DRM DRIVERS, Rob Herring

Hi Allen.

On Tue, Dec 10, 2019 at 01:53:41PM +0800, allen wrote:
> Add a DT binding documentation for IT6505.
> 
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> ---
>  .../bindings/display/bridge/ite,it6505.yaml        | 99 ++++++++++++++++++++++
>  1 file changed, 99 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> new file mode 100644
> index 00000000..23a106a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -0,0 +1,99 @@
> +# SPDX-License-Identifier: GPL-2.0
Please dual license new bindings like this:

(GPL-2.0-only OR BSD-2-Clause)


> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/ite,it6505.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ITE it6505 Device Tree Bindings
> +
> +maintainers:
> +  - Allen Chen <allen.chen@ite.com.tw>
> +
> +description: |
> +  The IT6505 is a high-performance DisplayPort 1.1a transmitter,
> +fully compliant with DisplayPort 1.1a, HDCP 1.3 specifications.
> +The IT6505 supports color depth of up to 36 bits (12 bits/color)
> +and ensures robust transmission of high-quality uncompressed video
> +content, along with uncompressed and compressed digital audio content.
Can we get consistent indent of the text here.
With this fixed:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> +
> +  Aside from the various video output formats supported, the IT6505
> +also encodes and transmits up to 8 channels of I2S digital audio,
> +with sampling rate up to 192kHz and sample size up to 24 bits.
> +In addition, an S/PDIF input port takes in compressed audio of up to
> +192kHz frame rate.
> +
> +  Each IT6505 chip comes preprogrammed with an unique HDCP key,
> +in compliance with the HDCP 1.3 standard so as to provide secure
> +transmission of high-definition content. Users of the IT6505 need not
> +purchase any HDCP keys or ROMs.
> +
> +properties:
> +  compatible:
> +    const: ite,it6505
> +
> +  reg:
> +    - maxItems: 1
> +    - description: i2c address of the bridge
> +
> +  ovdd-supply:
> +    - maxItems: 1
> +    - description: I/O voltage
> +
> +  pwr18-supply:
> +    - maxItems: 1
> +    - description: core voltage
> +
> +  interrupts:
> +    - maxItems: 1
> +    - description: interrupt specifier of INT pin
> +
> +  reset-gpios:
> +    - maxItems: 1
> +    - description: gpio specifier of RESET pin
> +
> +  hpd-gpios:
> +    - maxItems: 1
> +    - description:
> +        - Hotplug detect GPIO
> +        - Indicates which GPIO should be used for hotplug detection
> +
> +  extcon:
> +    - maxItems: 1
> +    - description: extcon specifier for the Power Delivery
> +
> +  port:
> +    - type: object
> +    - description: A port node pointing to DPI host port node
> +
> +required:
> +  - compatible
> +  - reg
> +  - ovdd-supply
> +  - pwr18-supply
> +  - interrupts
> +  - reset-gpios
> +  - hpd-gpios
> +  - extcon
> +
> +examples:
> +  - |
> +    dp-bridge@5c {
> +        compatible = "ite,it6505";
> +        interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>;
> +        reg = <0x5c>;
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&it6505_pins>;
> +        ovdd-supply = <&mt6358_vsim1_reg>;
> +        pwr18-supply = <&it6505_pp18_reg>;
> +        reset-gpios = <&pio 179 1>;
> +        hpd-gpios = <&pio 9 0>;
> +        extcon = <&usbc_extcon>;
> +
> +        port {
> +            it6505_in: endpoint {
> +                remote-endpoint = <&dpi_out>;
> +            };
> +        };
> +    };
> +
> +---

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v5 1/4] dt-bindings: Add vendor prefix for ITE Tech. Inc.
  2019-12-10  5:53 ` [PATCH v5 1/4] dt-bindings: Add vendor prefix for ITE Tech. Inc allen
@ 2019-12-18 20:24   ` Rob Herring
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2019-12-18 20:24 UTC (permalink / raw)
  To: allen
  Cc: Allen Chen, Pi-Hsun Shih, Jau-Chih Tseng, Heiko Stuebner,
	Hans Verkuil, Icenowy Zheng, Laurent Pinchart,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

On Tue, 10 Dec 2019 13:53:39 +0800, allen wrote:
> ITE Tech. Inc. (abbreviated as ITE ) is a professional fabless IC
> design house. ITE's core technology includes PC and NB Controller chips,
> Super I/O, High Speed Serial Interface, Video Codec, Touch Sensing,
> Surveillance, OFDM, Sensor Fusion, and so on.
> 
> more information on: http://www.ite.com.tw/
> 
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v5 3/4] dt-bindings: Add binding for IT6505.
  2019-12-14  8:21   ` Sam Ravnborg
@ 2019-12-18 20:29     ` Rob Herring
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2019-12-18 20:29 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: allen, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Pi-Hsun Shih, Jau-Chih Tseng, David Airlie, open list,
	open list:DRM DRIVERS

On Sat, Dec 14, 2019 at 09:21:45AM +0100, Sam Ravnborg wrote:
> Hi Allen.
> 
> On Tue, Dec 10, 2019 at 01:53:41PM +0800, allen wrote:
> > Add a DT binding documentation for IT6505.
> > 
> > Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> > Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> > ---
> >  .../bindings/display/bridge/ite,it6505.yaml        | 99 ++++++++++++++++++++++
> >  1 file changed, 99 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> > new file mode 100644
> > index 00000000..23a106a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> > @@ -0,0 +1,99 @@
> > +# SPDX-License-Identifier: GPL-2.0
> Please dual license new bindings like this:
> 
> (GPL-2.0-only OR BSD-2-Clause)
> 
> 
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/ite,it6505.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ITE it6505 Device Tree Bindings
> > +
> > +maintainers:
> > +  - Allen Chen <allen.chen@ite.com.tw>
> > +
> > +description: |
> > +  The IT6505 is a high-performance DisplayPort 1.1a transmitter,
> > +fully compliant with DisplayPort 1.1a, HDCP 1.3 specifications.
> > +The IT6505 supports color depth of up to 36 bits (12 bits/color)
> > +and ensures robust transmission of high-quality uncompressed video
> > +content, along with uncompressed and compressed digital audio content.
> Can we get consistent indent of the text here.

Pretty sure that's not even valid YAML.

> With this fixed:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> 
> > +
> > +  Aside from the various video output formats supported, the IT6505
> > +also encodes and transmits up to 8 channels of I2S digital audio,
> > +with sampling rate up to 192kHz and sample size up to 24 bits.
> > +In addition, an S/PDIF input port takes in compressed audio of up to
> > +192kHz frame rate.
> > +
> > +  Each IT6505 chip comes preprogrammed with an unique HDCP key,
> > +in compliance with the HDCP 1.3 standard so as to provide secure
> > +transmission of high-definition content. Users of the IT6505 need not
> > +purchase any HDCP keys or ROMs.
> > +
> > +properties:
> > +  compatible:
> > +    const: ite,it6505
> > +
> > +  reg:
> > +    - maxItems: 1
> > +    - description: i2c address of the bridge

And this is not valid json-schema. The '-' means list and properties 
aren't lists.

Run 'make dt_binding_check' and fix all the errors. See 
Documentation/devicetree/bindings/writing-schema.rst.

> > +
> > +  ovdd-supply:
> > +    - maxItems: 1
> > +    - description: I/O voltage
> > +
> > +  pwr18-supply:
> > +    - maxItems: 1
> > +    - description: core voltage
> > +
> > +  interrupts:
> > +    - maxItems: 1
> > +    - description: interrupt specifier of INT pin
> > +
> > +  reset-gpios:
> > +    - maxItems: 1
> > +    - description: gpio specifier of RESET pin
> > +
> > +  hpd-gpios:

Is HPD attached to the DP bridge or the DP connector. For the latter, 
then this property goes in a connector node.

> > +    - maxItems: 1
> > +    - description:
> > +        - Hotplug detect GPIO
> > +        - Indicates which GPIO should be used for hotplug detection
> > +
> > +  extcon:

Don't use extcon. Deprecated.

> > +    - maxItems: 1
> > +    - description: extcon specifier for the Power Delivery
> > +
> > +  port:
> > +    - type: object
> > +    - description: A port node pointing to DPI host port node
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - ovdd-supply
> > +  - pwr18-supply
> > +  - interrupts
> > +  - reset-gpios
> > +  - hpd-gpios
> > +  - extcon
> > +
> > +examples:
> > +  - |
> > +    dp-bridge@5c {
> > +        compatible = "ite,it6505";
> > +        interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>;
> > +        reg = <0x5c>;
> > +        pinctrl-names = "default";
> > +        pinctrl-0 = <&it6505_pins>;
> > +        ovdd-supply = <&mt6358_vsim1_reg>;
> > +        pwr18-supply = <&it6505_pp18_reg>;
> > +        reset-gpios = <&pio 179 1>;
> > +        hpd-gpios = <&pio 9 0>;
> > +        extcon = <&usbc_extcon>;
> > +
> > +        port {
> > +            it6505_in: endpoint {
> > +                remote-endpoint = <&dpi_out>;
> > +            };
> > +        };
> > +    };
> > +
> > +---

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-12-18 20:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10  5:53 [PATCH v5 0/4] IT6505 cover letter allen
2019-12-10  5:53 ` [PATCH v5 1/4] dt-bindings: Add vendor prefix for ITE Tech. Inc allen
2019-12-18 20:24   ` Rob Herring
2019-12-10  5:53 ` [PATCH v5 3/4] dt-bindings: Add binding for IT6505 allen
2019-12-14  8:21   ` Sam Ravnborg
2019-12-18 20:29     ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).