From: CK Hu <ck.hu@mediatek.com>
To: <matthias.bgg@kernel.org>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<p.zabel@pengutronix.de>, <airlied@linux.ie>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<ulrich.hecht+renesas@gmail.com>,
<laurent.pinchart@ideasonboard.com>,
<enric.balletbo@collabora.com>, <devicetree@vger.kernel.org>,
<rdunlap@infradead.org>, <frank-w@public-files.de>,
<sean.wang@mediatek.com>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <sean.wang@kernel.org>,
<wens@csie.org>, <drinkcat@chromium.org>,
<linux-mediatek@lists.infradead.org>, <mbrugger@suse.com>,
<hsinyi@chromium.org>, <linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-media@vger.kernel.org>
Subject: Re: [resend PATCH v6 00/12] arm/arm64: mediatek: Fix mmsys device probing
Date: Thu, 13 Feb 2020 10:57:53 +0800 [thread overview]
Message-ID: <1581562673.24120.3.camel@mtksdaap41> (raw)
In-Reply-To: <20191207224740.24536-1-matthias.bgg@kernel.org>
Hi, Matthias:
Would you work on this series in a short time? Some Yongqiang's patches
[1] also modify mmsys driver, and now it depend on your patch to prevent
conflicts. If you would not work on this series in a short time, I would
like to apply Yongqiang's patch without this series.
[1]
https://patchwork.kernel.org/project/linux-mediatek/list/?series=223221
Regards,
CK
On Sat, 2019-12-07 at 23:47 +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> [reseding due to wrong mail of Stephen]
>
> This is version five of the series. It's a long time this wasn't worked on, so
> as a reminder, version four can be found here:
> https://patchwork.kernel.org/cover/10686247/
>
> The biggest changes this new version does, is to implement the clock probing
> through a platform driver. The corresponding platform device get's created in
> the DRM driver. I converted all the clock drivers to platform drivers and tested
> the approach on the Acer Chromebook R13 (mt8173 based).
> Apart from that I reordered the patches so that the DT bindings update are the first
> patches.
>
> Changes since v5:
> - re-arrange the patch order
> - generate platform_device for mmsys clock driver inside the DRM driver
> - fix DTS binding accordingly
> - switch all mmsys clock driver to platform probing
> - fix mt8173 platform driver remove function
> - fix probe defer path in HDMI driver
> - fix probe defer path in mtk_mdp_comp
> - fix identation of error messages
>
> Changes since v4:
> - fix missing regmap accessors in drm diver (patch 1)
> - omit probe deffered warning on all drivers (patch 5)
> - update drm and clk bindings (patch 6 and 7)
> - put mmsys clock part in dts child node of mmsys. Only done
> for HW where no dts backport compatible breakage is expected
> (either DRM driver not yet implemented or no HW available to
> the public) (patch 9 to 12)
>
> Changes since v3:
> - use platform device to probe clock driver
> - add Acked-by CK Hu for the probe deferred patch
>
> Changes since v2:
> - fix kconfig typo (shame on me)
> - delete __initconst from mm_clocks as converted to a platform driver
>
> Changes since v1:
> - add binding documentation
> - ddp: use regmap_update_bits
> - ddp: ignore EPROBE_DEFER on clock probing
> - mfd: delete mmsys_private
> - add Reviewed-by and Acked-by tags
>
> MMSYS in Mediatek SoCs has some registers to control clock gates (which is
> used in the clk driver) and some registers to set the routing and enable
> the differnet blocks of the display subsystem.
>
> Up to now both drivers, clock and drm are probed with the same device tree
> compatible. But only the first driver get probed, which in effect breaks
> graphics on mt8173 and mt2701.
>
> This patch uses a platform device registration in the DRM driver, which
> will trigger the probe of the corresponding clock driver. It was tested on the
> bananapi-r2 and the Acer R13 Chromebook.
>
>
> Matthias Brugger (12):
> dt-bindings: display: mediatek: Add mmsys binding description
> dt-bindings: mediatek: Add compatible for mt7623
> drm/mediatek: Use regmap for register access
> drm: mediatek: Omit warning on probe defers
> media: mtk-mdp: Check return value of of_clk_get
> clk: mediatek: mt2701: switch mmsys to platform device probing
> clk: mediatek: mt2712e: switch to platform device probing
> clk: mediatek: mt6779: switch mmsys to platform device probing
> clk: mediatek: mt6797: switch to platform device probing
> clk: mediatek: mt8183: switch mmsys to platform device probing
> clk: mediatek: mt8173: switch mmsys to platform device probing
> drm/mediatek: Add support for mmsys through a pdev
>
> .../display/mediatek/mediatek,disp.txt | 30 ++++++-----
> drivers/clk/mediatek/clk-mt2701-mm.c | 41 +++++++++-----
> drivers/clk/mediatek/clk-mt2712-mm.c | 39 +++++++++-----
> drivers/clk/mediatek/clk-mt6779-mm.c | 41 +++++++++-----
> drivers/clk/mediatek/clk-mt6797-mm.c | 43 ++++++++++-----
> drivers/clk/mediatek/clk-mt8173.c | 51 +++++++++++++++---
> drivers/clk/mediatek/clk-mt8183-mm.c | 39 +++++++++-----
> drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 +-
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 +-
> drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 5 +-
> drivers/gpu/drm/mediatek/mtk_dpi.c | 12 +++--
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +-
> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 54 +++++++++----------
> drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 4 +-
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 35 +++++++++---
> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 4 +-
> drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++-
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 +-
> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 +++
> 19 files changed, 295 insertions(+), 135 deletions(-)
>
prev parent reply other threads:[~2020-02-13 3:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 22:47 [resend PATCH v6 00/12] arm/arm64: mediatek: Fix mmsys device probing matthias.bgg
2019-12-07 22:47 ` [resend PATCH v6 01/12] dt-bindings: display: mediatek: Add mmsys binding description matthias.bgg
2019-12-09 5:12 ` CK Hu
2019-12-09 8:48 ` Enric Balletbo i Serra
2020-02-13 18:17 ` Matthias Brugger
2019-12-18 16:39 ` Rob Herring
2019-12-07 22:47 ` [resend PATCH v6 02/12] dt-bindings: mediatek: Add compatible for mt7623 matthias.bgg
2019-12-09 8:51 ` Enric Balletbo i Serra
2019-12-18 17:02 ` Rob Herring
2019-12-07 22:47 ` [resend PATCH v6 03/12] drm/mediatek: Use regmap for register access matthias.bgg
2019-12-09 5:16 ` CK Hu
2019-12-07 22:47 ` [resend PATCH v6 04/12] drm: mediatek: Omit warning on probe defers matthias.bgg
2019-12-09 5:19 ` CK Hu
2019-12-09 9:39 ` Enric Balletbo i Serra
2020-02-13 18:58 ` Matthias Brugger
2019-12-07 22:47 ` [resend PATCH v6 05/12] media: mtk-mdp: Check return value of of_clk_get matthias.bgg
2019-12-09 9:50 ` Enric Balletbo i Serra
2019-12-07 22:47 ` [resend PATCH v6 06/12] clk: mediatek: mt2701: switch mmsys to platform device probing matthias.bgg
2019-12-09 9:58 ` Enric Balletbo i Serra
2020-02-13 19:11 ` Matthias Brugger
2019-12-07 22:47 ` [resend PATCH v6 07/12] clk: mediatek: mt2712e: switch " matthias.bgg
2019-12-09 9:59 ` Enric Balletbo i Serra
2019-12-07 22:47 ` [resend PATCH v6 08/12] clk: mediatek: mt6779: switch mmsys " matthias.bgg
2019-12-09 10:01 ` Enric Balletbo i Serra
2019-12-07 22:47 ` [resend PATCH v6 09/12] clk: mediatek: mt6797: switch " matthias.bgg
2019-12-07 22:47 ` [resend PATCH v6 10/12] clk: mediatek: mt8183: switch mmsys " matthias.bgg
2019-12-09 8:51 ` CK Hu
2020-02-13 19:35 ` Matthias Brugger
2019-12-07 22:47 ` [resend PATCH v6 11/12] clk: mediatek: mt8173: " matthias.bgg
2019-12-07 22:47 ` [resend PATCH v6 12/12] drm/mediatek: Add support for mmsys through a pdev matthias.bgg
2019-12-09 5:34 ` CK Hu
2020-02-13 19:46 ` Matthias Brugger
2019-12-09 10:15 ` Enric Balletbo i Serra
2020-02-13 2:57 ` CK Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581562673.24120.3.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=frank-w@public-files.de \
--cc=hsinyi@chromium.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).