From: Paul Cercueil <paul@crapouillou.net>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Paul Boddie <paul@boddie.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paulburton@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Andi Kleen <ak@linux.intel.com>,
Kees Cook <keescook@chromium.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
kernel@pyra-handheld.com
Subject: Re: [PATCH v3 5/6] MIPS: DTS: CI20: multiple DTS improvements
Date: Fri, 28 Feb 2020 11:36:08 -0300 [thread overview]
Message-ID: <1582900568.3.2@crapouillou.net> (raw)
In-Reply-To: <01795b270ad025ffffbf80e115b3b2d138a20ffe.1581884459.git.hns@goldelico.com>
Hi Nikolaus,
Le dim., févr. 16, 2020 at 21:20, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> a) add DT node for SW1 as Enter button
>
> The SW1 button can be used as a simple one-button keyboard
> and is connected to PD17.
>
> Note: SW1 has a second meaning to change the boot sequence
> when pressed while powering on.
>
> b) give eth0_power a defined voltage.
>
> This is a 3.3V power switch (DVNET3.3V ).
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 1ab55be707af..4bacefa2cfce 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -4,6 +4,7 @@
> #include "jz4780.dtsi"
> #include <dt-bindings/clock/ingenic,tcu.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
>
> / {
> compatible = "img,ci20", "ingenic,jz4780";
> @@ -25,6 +26,17 @@
> 0x30000000 0x30000000>;
> };
>
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + sw1 {
> + label = "ci20:sw1";
> + linux,code = <KEY_ENTER>;
Why KEY_ENTER? It would make it impossible for applications to know
that it's actually the switch that has been pressed an not the keyboard.
> + gpios = <&gpd 17 GPIO_ACTIVE_HIGH>;
> + wakeup-source;
> + };
> + };
> +
> leds {
> compatible = "gpio-leds";
>
> @@ -56,6 +68,8 @@
> eth0_power: fixedregulator@0 {
> compatible = "regulator-fixed";
> regulator-name = "eth0_power";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> gpio = <&gpb 25 GPIO_ACTIVE_LOW>;
> enable-active-high;
> };
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-02-28 14:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 20:20 [PATCH v3 0/6] MIPS: Fixes and improvements for CI20 board (JZ4780) H. Nikolaus Schaller
2020-02-16 20:20 ` [PATCH v3 1/6] MIPS: DTS: jz4780: add #includes for irq.h and gpio.h H. Nikolaus Schaller
2020-02-28 14:33 ` Paul Cercueil
2020-02-16 20:20 ` [PATCH v3 2/6] MIPS: DTS: CI20: add DT node for IR sensor H. Nikolaus Schaller
2020-02-16 20:20 ` [PATCH v3 3/6] MIPS: DTS: CI20: fix PMU definitions for ACT8600 H. Nikolaus Schaller
2020-02-28 14:34 ` Paul Cercueil
2020-02-28 14:40 ` H. Nikolaus Schaller
2020-02-16 20:20 ` [PATCH v3 4/6] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC H. Nikolaus Schaller
2020-02-16 20:20 ` [PATCH v3 5/6] MIPS: DTS: CI20: multiple DTS improvements H. Nikolaus Schaller
2020-02-28 14:36 ` Paul Cercueil [this message]
2020-02-28 14:42 ` H. Nikolaus Schaller
2020-02-28 14:50 ` Paul Cercueil
2020-02-16 20:21 ` [PATCH v3 6/6] MIPS: CI20: defconfig: multiple improvements H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582900568.3.2@crapouillou.net \
--to=paul@crapouillou.net \
--cc=ak@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=keescook@chromium.org \
--cc=kernel@pyra-handheld.com \
--cc=krzk@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=paul@boddie.org.uk \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).