From: CK Hu <ck.hu@mediatek.com>
To: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
"David Airlie" <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <wsd_upstream@mediatek.com>,
<dri-devel@lists.freedesktop.org>,
Bibby Hsieh <bibby.hsieh@mediatek.com>,
Houlong Wei <houlong.wei@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
HS Liao <hs.liao@mediatek.com>
Subject: Re: [PATCH v4 02/13] mailbox: cmdq: variablize address shift in platform
Date: Wed, 4 Mar 2020 10:32:50 +0800 [thread overview]
Message-ID: <1583289170.32049.1.camel@mtksdaap41> (raw)
In-Reply-To: <1583233125-7827-3-git-send-email-dennis-yc.hsieh@mediatek.com>
Hi, Dennis:
On Tue, 2020-03-03 at 18:58 +0800, Dennis YC Hsieh wrote:
> Some gce hardware shift pc and end address in register to support
> large dram addressing.
> Implement gce address shift when write or read pc and end register.
> And add shift bit in platform definition.
>
> Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 61 ++++++++++++++++++------
> drivers/soc/mediatek/mtk-cmdq-helper.c | 3 +-
> include/linux/mailbox/mtk-cmdq-mailbox.h | 2 +
> 3 files changed, 50 insertions(+), 16 deletions(-)
>
[snip]
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index de20e6cba83b..2e1bc513569b 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -291,7 +291,8 @@ static int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
>
> /* JUMP to end */
> inst.op = CMDQ_CODE_JUMP;
> - inst.value = CMDQ_JUMP_PASS;
> + inst.value = CMDQ_JUMP_PASS >>
> + cmdq_mbox_shift(((struct cmdq_client *)pkt->cl)->chan);
Why not just cmdq_mbox_shift(pkt->cl->chan) ?
Regards,
CK
> err = cmdq_pkt_append_command(pkt, inst);
>
> return err;
> diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h
> index a4dc45fbec0a..dfe5b2eb85cc 100644
> --- a/include/linux/mailbox/mtk-cmdq-mailbox.h
> +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h
> @@ -88,4 +88,6 @@ struct cmdq_pkt {
> void *cl;
> };
>
> +u8 cmdq_mbox_shift(struct mbox_chan *chan);
> +
> #endif /* __MTK_CMDQ_MAILBOX_H__ */
next prev parent reply other threads:[~2020-03-04 2:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 10:58 [PATCH v4 00/13] support gce on mt6779 platform Dennis YC Hsieh
2020-03-03 10:58 ` [PATCH v4 01/13] dt-binding: gce: add gce header file for mt6779 Dennis YC Hsieh
2020-03-03 14:05 ` Rob Herring
2020-03-03 10:58 ` [PATCH v4 02/13] mailbox: cmdq: variablize address shift in platform Dennis YC Hsieh
2020-03-04 2:32 ` CK Hu [this message]
2020-03-04 2:59 ` CK Hu
2020-03-03 10:58 ` [PATCH v4 03/13] mailbox: cmdq: support mt6779 gce platform definition Dennis YC Hsieh
2020-03-03 10:58 ` [PATCH v4 04/13] mailbox: mediatek: cmdq: clear task in channel before shutdown Dennis YC Hsieh
2020-03-04 2:36 ` CK Hu
2020-03-03 10:58 ` [PATCH v4 05/13] soc: mediatek: cmdq: return send msg error code Dennis YC Hsieh
2020-03-04 2:38 ` CK Hu
2020-03-03 10:58 ` [PATCH v4 06/13] soc: mediatek: cmdq: add assign function Dennis YC Hsieh
2020-03-03 10:58 ` [PATCH v4 07/13] soc: mediatek: cmdq: add write_s function Dennis YC Hsieh
2020-03-03 10:58 ` [PATCH v4 08/13] soc: mediatek: cmdq: add read_s function Dennis YC Hsieh
2020-03-03 10:58 ` [PATCH v4 09/13] soc: mediatek: cmdq: add write_s value function Dennis YC Hsieh
2020-03-03 10:58 ` [PATCH v4 10/13] soc: mediatek: cmdq: export finalize function Dennis YC Hsieh
2020-03-04 2:41 ` CK Hu
2020-03-03 10:58 ` [PATCH v4 11/13] soc: mediatek: cmdq: add jump function Dennis YC Hsieh
2020-03-04 2:57 ` CK Hu
2020-03-05 0:49 ` Dennis-YC Hsieh
2020-03-03 10:58 ` [PATCH v4 12/13] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api Dennis YC Hsieh
2020-03-04 3:05 ` CK Hu
2020-03-05 0:49 ` Dennis-YC Hsieh
2020-03-03 10:58 ` [PATCH v4 13/13] soc: mediatek: cmdq: add set event function Dennis YC Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583289170.32049.1.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=airlied@linux.ie \
--cc=bibby.hsieh@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=houlong.wei@mediatek.com \
--cc=hs.liao@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).