From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <broonie@kernel.org>, <tiwai@suse.com>, <matthias.bgg@gmail.com>,
<p.zabel@pengutronix.de>, <tzungbi@google.com>,
<alsa-devel@alsa-project.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <shane.chien@mediatek.com>,
<kuninori.morimoto.gx@renesas.com>, <maowenan@huawei.com>
Subject: Re: [PATCH 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document
Date: Mon, 12 Oct 2020 14:20:53 +0800 [thread overview]
Message-ID: <1602483653.8921.20.camel@mhfsdcap03> (raw)
In-Reply-To: <20201006204344.GA2791644@bogus>
On Tue, 2020-10-06 at 15:43 -0500, Rob Herring wrote:
> On Fri, Oct 02, 2020 at 03:35:42PM +0800, Jiaxin Yu wrote:
> > This patch adds document for the machine board with mt6358, rt1015 and rt5682.
> >
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> > ---
> > .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 44 +++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > new file mode 100644
> > index 0000000000000..dff5004cd0368
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> Dual license new bindings:
>
> (GPL-2.0-only OR BSD-2-Clause)
>
Ok, got it.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver
> > +
> > +maintainers:
> > + - Jiaxin Yu <jiaxin.yu@mediatek.com>
> > + - Shane Chien <shane.chien@mediatek.com>
> > +
> > +description:
> > + This binding describes the MT8192 sound card.
> > +
> > +properties:
> > + compatible:
> > + contains:
>
> Drop this. Other strings shouldn't be allowed.
>
Should I need to remove "contains"?
> > + const: mediatek,mt8192_mt6359_rt1015_rt5682
>
> Just a list of part numbers? A different codec would be a different
> compatible and driver? You should have a link to the codec and you can
> read it's compatible to get what codec you have.
>
THis bindings is dedicated to the mt8192 with mt6359, rt1015 and rt5682.
We are not ready to configure dai-link in DTS. Is this mandatory now?
> > +
> > + mediatek,platform:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > + description: |
> > + The DT/OF node which is used to specify the link's platform driver.
>
> What's "link's platform driver"? A DT doesn't have drivers.
>
There's something wrong with my description. "mediatek,platform" is the
phandle of MT8192 ASoC platform.
> > +
> > +additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - mediatek,platform
> > +
> > +examples:
> > + - |
> > +
> > + sound: mt8192-sound {
> > + compatible = "mediatek,mt8192-mt6359-rt1015-rt5682";
> > + mediatek,platform = <&afe>;
> > + pinctrl-names = "aud_clk_mosi_off",
> > + "aud_clk_mosi_on";
> > + pinctrl-0 = <&aud_clk_mosi_off>;
> > + pinctrl-1 = <&aud_clk_mosi_on>;
> > + };
> > +
> > +...
> > --
> > 2.18.0
next prev parent reply other threads:[~2020-10-12 6:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 7:35 [PATCH 0/5] ASoC: Mediatek: Add support for MT8192 SoC Jiaxin Yu
2020-10-02 7:35 ` [PATCH 1/5] ASoC: mediatek: mt6359: add the calibration functions Jiaxin Yu
2020-10-02 7:35 ` [PATCH 3/5] dt-bindings: mediatek: mt8192: add audio afe document Jiaxin Yu
2020-10-05 13:55 ` Rob Herring
2020-10-12 5:47 ` Jiaxin Yu
2020-10-05 13:57 ` Rob Herring
2020-10-12 5:56 ` Jiaxin Yu
2020-10-02 7:35 ` [PATCH 4/5] ASoC: mediatek: mt8192: add machine driver with mt6359, rt1015 and rt5682 Jiaxin Yu
2020-10-02 7:35 ` [PATCH 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document Jiaxin Yu
2020-10-06 20:43 ` Rob Herring
2020-10-12 6:20 ` Jiaxin Yu [this message]
[not found] ` <1601624142-18991-3-git-send-email-jiaxin.yu@mediatek.com>
2020-10-02 7:59 ` [PATCH 2/5] ASoC: mediatek: mt8192: add platform driver Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1602483653.8921.20.camel@mhfsdcap03 \
--to=jiaxin.yu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maowenan@huawei.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=shane.chien@mediatek.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).