From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA693C433E0 for ; Tue, 12 Jan 2021 02:11:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E91B22E03 for ; Tue, 12 Jan 2021 02:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727324AbhALCLA (ORCPT ); Mon, 11 Jan 2021 21:11:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbhALCLA (ORCPT ); Mon, 11 Jan 2021 21:11:00 -0500 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EFB3C061786 for ; Mon, 11 Jan 2021 18:10:14 -0800 (PST) Received: by mail-pg1-x530.google.com with SMTP id z21so407082pgj.4 for ; Mon, 11 Jan 2021 18:10:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=TAJh0CkOrXTXuHNR+ubOQwQXwNopqM57rV369+EEx9I=; b=H0BN8Do4ZOVCh0kCJo4fmcVJyxFptlqv/+SoSFu0R0fIYGkg9268aT+PCfdeNGQkzT mc6dKyPiyUW2lr+LqtaDcBb51Ei0nUnS1Y5YU3zKv5/TG9XUCnuwHxQ2lhlggEUr55iQ 245R4Hn6TY7JOIbl5Cx3gA1YSIxH8atOA31C0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=TAJh0CkOrXTXuHNR+ubOQwQXwNopqM57rV369+EEx9I=; b=W2I8Qbc+sGzHLq9m0+LaZ9WYUkCuFhaElTC3kl6vwqvFfffdE2pIw+p4uziDk47T7g +g/eiT9JmNKt+1UE/m69kJzEE8iMd1rs9PjXP+ZMGjkGpjUXTgN94utUV4mz7QhECdvw 1TAPAwXz9z+2vhE25lK2r0NplMm8FmZtXAlpJ/ylr3Fy42ONt1j+LP254orKfr2I551X tE3VNTtusOOnOS4mGHrEuL3pQ6WKouPo22xlttB9Bpn9MhaEIzu3MeVNzD5mqiNqs/zK AJeaHjKUp0gSuuX32fEM+ApXeM75AWmPuGu6kt1loSJ/81Q89ecU8PuEuEHAOvd4Bk43 6rAA== X-Gm-Message-State: AOAM530bgnmnPuojD84xtjduYN1L9egRgVpkDZcmal+pZBULLJARHIIJ SDcw2MG+uyfQz1wXyIibBsptTg== X-Google-Smtp-Source: ABdhPJy6riOnrTb3lEU4Mio4h9HV53BnD1tKRzK4N1IjCjvt4GdjfeyJeipmC5FWCwkCLczZ1Nq8+A== X-Received: by 2002:a62:c1c4:0:b029:1a7:efe9:163c with SMTP id i187-20020a62c1c40000b02901a7efe9163cmr2216781pfg.47.1610417413913; Mon, 11 Jan 2021 18:10:13 -0800 (PST) Received: from chromium.org ([2620:15c:202:201:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id f29sm1110404pgm.76.2021.01.11.18.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 18:10:13 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210107154200.v4.1.I025fb861cd5fa0ef5286b7dce514728e9df7ae74@changeid> References: <20210107154200.v4.1.I025fb861cd5fa0ef5286b7dce514728e9df7ae74@changeid> Subject: Re: [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property From: Stephen Boyd Cc: dianders@chromium.org, Philip Chen , Benson Leung , Enric Balletbo i Serra , Guenter Roeck , Rob Herring , Simon Glass , devicetree@vger.kernel.org, linux-input@vger.kernel.org To: LKML , Philip Chen , dmitry.torokhov@gmail.com Date: Mon, 11 Jan 2021 18:10:11 -0800 Message-ID: <161041741167.3661239.13546059654424804588@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Philip Chen (2021-01-07 15:42:08) > This patch adds a new property `function-row-physmap` to the >From Documentation/process/submitting-patches.rst Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour. > device tree for the custom keyboard top row design. >=20 > The property describes the rows/columns of the top row keys > from left to right. >=20 > Signed-off-by: Philip Chen > --- > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.= yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > index 8e50c14a9d778..7acdb33781d30 100644 > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > @@ -31,6 +31,16 @@ properties: > if the EC does not have its own logic or hardware for this. > type: boolean > =20 > + function-row-physmap: Is there any minimum/maximum number of elements possible? > + $ref: '/schemas/types.yaml#/definitions/uint32-array' > + description: | > + An ordered u32 array describing the rows/columns (in the scan matr= ix) > + of top row keys from physical left (KEY_F1) to right. Each entry > + encodes the row/column as: > + (((row) & 0xFF) << 24) | (((column) & 0xFF) << 16) > + where the lower 16 bits are reserved. This property is specified o= nly > + when the keyboard has a custom design for the top row keys. > +