From: Kalyan Thota <kalyan_t@codeaurora.org>
To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org
Cc: Kalyan Thota <kalyan_t@codeaurora.org>,
linux-kernel@vger.kernel.org, robdclark@gmail.com,
dianders@chromium.org, mkrishn@codeaurora.org
Subject: [RFC] Inline rotation support in dpu driver
Date: Sat, 3 Jul 2021 04:32:42 -0700 [thread overview]
Message-ID: <1625311962-14185-1-git-send-email-kalyan_t@codeaurora.org> (raw)
This change adds support for inline rotation in the dpu driver.
When inline rotation is enabled the VIG pipes will directly fetch the image
from memory in a rotated fashion
Inline rotation has following restrictions
1) Supported only with compressed formats
2) max pre rotated height is 1088
3) restrictions with downscaling ratio
Queries:
1) Since inline rotation works for fewer pixel formats with specific modifier, how can we provide this information to the compositor so that
chrome compositor can choose between overlaying or falling back to GPU. In the patch it fails in the atomic check.
2) If a display composition fails in atomic check due to any of the restrictions in overlays
can chrome compositor switch it back to the GPU and re trigger the commit ?
posting it as RFC as validation is not complete, please share early comments on this.
Kalyan Thota (1):
drm/msm/disp/dpu1: add support for inline rotation in dpu driver
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 47 +++++++++----
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 20 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 93 ++++++++++++++++++++------
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 +
4 files changed, 128 insertions(+), 34 deletions(-)
--
2.7.4
next reply other threads:[~2021-07-03 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 11:32 Kalyan Thota [this message]
2021-07-03 18:26 ` [RFC] Inline rotation support in dpu driver Rob Clark
2021-07-04 8:25 ` Dmitry Baryshkov
2021-07-04 18:17 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1625311962-14185-1-git-send-email-kalyan_t@codeaurora.org \
--to=kalyan_t@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrishn@codeaurora.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).