From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Anand Gore <anand.gore@broadcom.com>,
Linux ARM List <linux-arm-kernel@lists.infradead.org>
Cc: joel.peshkin@broadcom.com, kursad.oney@broadcom.com,
samyon.furman@broadcom.com,
William Zhang <william.zhang@broadcom.com>,
dan.beygelman@broadcom.com, tomer.yacoby@broadcom.com,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
florian.fainelli@broadcom.com,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] [PATCH] dt-bindings: arm: add BCM6878 soc to binding document
Date: Sun, 29 May 2022 16:00:01 +0200 [thread overview]
Message-ID: <169e0f68-d352-6be3-516b-82c22d6fd743@linaro.org> (raw)
In-Reply-To: <20220527100904.2.I383a14e417ffde9d8180ee578abbafdf09141c29@changeid>
On 27/05/2022 19:09, Anand Gore wrote:
> Add BCM6878 SOC device tree description to bcmbca binding document.
>
> Signed-off-by: Anand Gore <anand.gore@broadcom.com>
Your subject is corrupted. Anyway you made it a bit over-complicated. No
need to say "to binding document" as the prefix explains it. So this
should be (don't forget the actual subarch prefix):
dt-bindings: arm: brcm: add BCM6878 soc
Same applies to your other patches.
> ---
>
> .../devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> index a63e355ba8f9..4b4af2b1f277 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> @@ -43,6 +43,14 @@ properties:
> - const: brcm,bcmbca
>
>
> + - description: BCM6878 based boards
> + items:
> + - enum:
> + - brcm,bcm96878
> + - const: brcm,bcm6878
> + - const: brcm,bcmbca
> +
> +
Same as before - no need for two blank lines.
> additionalProperties: true
>
> ...
Best regards,
Krzysztof
prev parent reply other threads:[~2022-05-29 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 17:09 [PATCH 0/3] arm: bcmbca: add bcm6878 soc support Anand Gore
2022-05-27 17:09 ` [PATCH 1/3] ARM: dts: add dts files for bcmbca soc 6878 Anand Gore
2022-05-27 17:09 ` [PATCH 2/3] [PATCH] dt-bindings: arm: add BCM6878 soc to binding document Anand Gore
2022-05-29 14:00 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169e0f68-d352-6be3-516b-82c22d6fd743@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=joel.peshkin@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samyon.furman@broadcom.com \
--cc=tomer.yacoby@broadcom.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).