From: vgarodia@codeaurora.org
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Dikshita Agarwal <dikshita@codeaurora.org>,
linux-media@vger.kernel.org, stanimir.varbanov@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: sc7180: Add Venus video codec DT node
Date: Thu, 02 Jan 2020 13:24:08 +0530 [thread overview]
Message-ID: <17bc9ed78316f483fea273849d39d6a8@codeaurora.org> (raw)
In-Reply-To: <20191229031853.GL3755841@builder>
Hi Bjorn,
Thanks for your review comments.
On 2019-12-29 08:48, Bjorn Andersson wrote:
> On Thu 19 Dec 23:59 PST 2019, Dikshita Agarwal wrote:
>
>> This adds Venus video codec DT node for sc7180.
>>
>> Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 36
>> ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 36 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index 6876aae2..42c70f5 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -10,6 +10,7 @@
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/phy/phy-qcom-qusb2.h>
>> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>> +#include <dt-bindings/clock/qcom,videocc-sc7180.h>
>>
>> / {
>> interrupt-parent = <&intc>;
>> @@ -66,6 +67,11 @@
>> compatible = "qcom,cmd-db";
>> no-map;
>> };
>> +
>> + venus_mem: memory@8F600000 {
>> + reg = <0 0x8F600000 0 0x500000>;
>> + no-map;
>> + };
>> };
>>
>> cpus {
>> @@ -1042,6 +1048,36 @@
>> };
>> };
>>
>> + venus: video-codec@aa00000 {
>> + compatible = "qcom,sc7180-venus";
>> + reg = <0 0x0aa00000 0 0xff000>;
>> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>> + power-domains = <&videocc VENUS_GDSC>,
>
> Should this be aligned with the DT refactoring done for sdm845, where
> the GDSC is moved into the *-core subnodes etc?
This is already aligned to new refactored design i.e clocks/GDSCs are no
more
core specific.
> Regards,
> Bjorn
>
>> + <&videocc VCODEC0_GDSC>;
>> + power-domain-names = "venus", "vcodec0";
>> + clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
>> + <&videocc VIDEO_CC_VENUS_AHB_CLK>,
>> + <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>,
>> + <&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
>> + <&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
>> + clock-names = "core", "iface", "bus",
>> + "vcodec0_core", "vcodec0_bus";
>> + iommus = <&apps_smmu 0x0C00 0x60>;
>> + memory-region = <&venus_mem>;
>> +
>> + video-core0 {
>> + compatible = "venus-decoder";
>> + };
>> +
>> + video-core1 {
>> + compatible = "venus-encoder";
>> + };
>> +
>> + video-firmware {
>> + iommus = <&apps_smmu 0x0C42 0x0>;
>> + };
>> + };
>> +
>> pdc: interrupt-controller@b220000 {
>> compatible = "qcom,sc7180-pdc", "qcom,pdc";
>> reg = <0 0x0b220000 0 0x30000>;
>> --
>> 1.9.1
>>
next prev parent reply other threads:[~2020-01-02 7:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 7:59 [PATCH v2,0/3] Enable video on sc7180 Dikshita Agarwal
2019-12-20 7:59 ` [PATCH 1/3] arm64: dts: sc7180: Add Venus video codec DT node Dikshita Agarwal
2019-12-20 9:34 ` Stanimir Varbanov
2019-12-23 9:50 ` dikshita
2019-12-24 12:12 ` Sai Prakash Ranjan
2019-12-24 13:24 ` Sai Prakash Ranjan
2019-12-29 3:18 ` Bjorn Andersson
2020-01-02 7:54 ` vgarodia [this message]
2019-12-20 7:59 ` [PATCH 2/3] dt-bindings: media: venus: Add sc7180 DT schema Dikshita Agarwal
2019-12-20 9:37 ` Stanimir Varbanov
2019-12-23 10:56 ` dikshita
2019-12-20 7:59 ` [PATCH 3/3] venus: core: add sc7180 DT compatible and resource struct Dikshita Agarwal
2019-12-20 9:33 ` Stanimir Varbanov
2019-12-23 10:04 ` dikshita
2019-12-23 10:43 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17bc9ed78316f483fea273849d39d6a8@codeaurora.org \
--to=vgarodia@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).