From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jernej =?utf-8?B?xaBrcmFiZWM=?= Subject: Re: Re: [PATCH v4] ARM: sun8i: h2+: add support for Banana Pi M2 Zero board Date: Thu, 08 Feb 2018 10:28:32 +0100 Message-ID: <1836483.rFXKcXDauj@jernej-laptop> References: <20180206131647.41700-1-icenowy@aosc.io> <20180208090042.364is5ctofhuao4i@flea> <9e77487f83b226ad7700715251178ce8@aosc.io> Reply-To: jernej.skrabec-gGgVlfcn5nU@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <9e77487f83b226ad7700715251178ce8-h8G6r0blFSE@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, icenowy-h8G6r0blFSE@public.gmane.org Cc: Maxime Ripard , Chen-Yu Tsai , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Dne =C4=8Detrtek, 08. februar 2018 ob 10:15:35 CET je Icenowy Zheng napisal= (a): > =E5=9C=A8 2018-02-08 17:00=EF=BC=8CMaxime Ripard =E5=86=99=E9=81=93=EF=BC= =9A >=20 > > On Tue, Feb 06, 2018 at 09:16:47PM +0800, Icenowy Zheng wrote: > >> Banana Pi M2 Zero board is a H2+-based board by Sinovoip, with a form > >> factor and GPIO holes similar to Raspberry Pi Zero. > >>=20 > >> It features: > >> - Allwinner H2+ SoC > >> - Single-chip (16-bit) 512MiB DDR3 DRAM > >> - Ampak AP6212 Wi-Fi/Bluetooth module > >> - MicroSD slot > >> - Two MicroUSB Type-B ports (one can only be used to power the board > >> and > >>=20 > >> the other features OTG functionality) > >>=20 > >> - Two keys, a reset and a GPIO-connected key. > >> - HDMI Type-C (miniHDMI) connector connected to the HDMI part of H2+. > >> - CSI connector to connect the camera sensor provided by Sinovoip. > >>=20 > >> Signed-off-by: Icenowy Zheng > >> --- > >> Changes in v4: > >> - Use SPDX license identifier. > >>=20 > >> Changes in v3: > >> - Add comments about Vbus problem in &usbphy node. > >>=20 > >> Changes in v2: > >> - Use high active SD card detect on the production batch. > >>=20 > >> arch/arm/boot/dts/Makefile | 1 + > >> .../boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 126 > >>=20 > >> +++++++++++++++++++++ > >>=20 > >> 2 files changed, 127 insertions(+) > >> create mode 100644 > >>=20 > >> arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > >>=20 > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > >> index ade7a38543dc..d5a17e6e8b0f 100644 > >> --- a/arch/arm/boot/dts/Makefile > >> +++ b/arch/arm/boot/dts/Makefile > >> @@ -974,6 +974,7 @@ dtb-$(CONFIG_MACH_SUN8I) +=3D \ > >>=20 > >> sun8i-a83t-cubietruck-plus.dtb \ > >> sun8i-a83t-tbs-a711.dtb \ > >> sun8i-h2-plus-orangepi-r1.dtb \ > >>=20 > >> + sun8i-h2-plus-bananapi-m2-zero.dtb \ > >>=20 > >> sun8i-h2-plus-orangepi-zero.dtb \ > >> sun8i-h3-bananapi-m2-plus.dtb \ > >> sun8i-h3-beelink-x2.dtb \ > >>=20 > >> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > >> b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > >> new file mode 100644 > >> index 000000000000..e2ee65a5bf92 > >> --- /dev/null > >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > >> @@ -0,0 +1,126 @@ > >> +/* > >> + * Copyright (C) 2017 Icenowy Zheng > >> + * > >> + * Based on sun8i-h3-bananapi-m2-plus.dts, which is: > >> + * Copyright (C) 2016 Chen-Yu Tsai > >> + * > >> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >=20 > > Sorry to be a bit picky about this, but this should be your very first > > line, see arch/arm/boot/dts/sun7i-a20-olimex-som204-evb.dts for > > example. >=20 > I think it's also OK here, see > arch/arm/boot/dts/sun8i-h3-libretech-all-h3-cc.dts. Lincesing rules [1] says it should be in first possible line which can cont= ain=20 comment. [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tre= e/ Documentation/process/license-rules.rst#n57 >=20 > > Thanks! > > Maxime >=20 > -- > You received this message because you are subscribed to the Google Groups > "linux-sunxi" group. To unsubscribe from this group and stop receiving > emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org= . > For more options, visit https://groups.google.com/d/optout. --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.