devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Brian Norris <briannorris@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Chris Zhong <zyw@rock-chips.com>
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: add cdn-dp node for rk3399.
Date: Tue, 13 Feb 2018 12:52:06 +0100	[thread overview]
Message-ID: <1953673.4ODsl89y1u@diego> (raw)
In-Reply-To: <CAFqH_52NtRib_nLrGnacdGK=cHOeh8Lfaa=38X1OA8gnu1r=hQ@mail.gmail.com>

Hi Enric,

Am Dienstag, 13. Februar 2018, 12:36:47 CET schrieb Enric Balletbo Serra:
> 2018-02-13 11:42 GMT+01:00 Enric Balletbo i Serra
> 
> <enric.balletbo@collabora.com>:
> > Hi Heiko,
> > 
> > On 10/02/18 17:16, Heiko Stuebner wrote:
> >> Hi Enric,
> >> 
> >> Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i 
Serra:
> >>> From: Chris Zhong <zyw@rock-chips.com>
> >>> 
> >>> Add a node for the cdn DP controller which is embedded in the rk3399
> >>> SoC.
> >>> 
> >>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> >>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >>> ---
> >>> 
> >>>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50
> >>>  ++++++++++++++++++++++++++++++++>> 
> >> It looks like there is no binding document at all for cdn-dp? At least
> >> I couldn't find one and the original series also didn't seem to include
> >> one.
> >> 
> >> And while I don't see anything problematic right with the used properties
> >> right now, I'd think we should really have a binding and give
> >> dt-maintainers a chance to complain, before adding devicetree nodes
> >> based on it.
> >> 
> >> I'd guess a mostly usable binding doc should already sit in the chromeos
> >> tree, which you could base a v2 of this series on?
> > 
> > Sure, I'll send a v2 for this series. Thanks.
> > 
> >   Enric
> 
> So seems that the binding was already discussed and accepted here [1]
> but for some reason never landed. So I think that I'll send v2 just
> including the binding patch so all can land together. Sounds good?
> 
> [1] https://patchwork.kernel.org/patch/9278077/

Nice find and yep, just resending binding + your patches 2+3
is enough then :-)


Heiko

  reply	other threads:[~2018-02-13 11:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 16:31 [PATCH 1/3] arm64: dts: rockchip: introduce pclk_vio_grf in eDP device node Enric Balletbo i Serra
     [not found] ` <20180207163150.16332-1-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-02-07 16:31   ` [PATCH 2/3] arm64: dts: rockchip: add cdn-dp node for rk3399 Enric Balletbo i Serra
     [not found]     ` <20180207163150.16332-2-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-02-10 16:16       ` Heiko Stuebner
2018-02-13 10:42         ` Enric Balletbo i Serra
2018-02-13 11:36           ` Enric Balletbo Serra
2018-02-13 11:52             ` Heiko Stübner [this message]
2018-02-07 16:31   ` [PATCH 3/3] arm64: dts: rockchip: enable DP for gru Enric Balletbo i Serra
2018-02-09  9:45   ` [PATCH 1/3] arm64: dts: rockchip: introduce pclk_vio_grf in eDP device node Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1953673.4ODsl89y1u@diego \
    --to=heiko@sntech.de \
    --cc=briannorris@chromium.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eballetbo@gmail.com \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).