From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v5 4/5] drm: xlnx: DRM KMS driver for Xilinx ZynqMP DisplayPort
Date: Thu, 22 Feb 2018 02:18:35 +0200 [thread overview]
Message-ID: <1979079.CDeAWn4OqI@avalon> (raw)
In-Reply-To: <1517967400-16993-4-git-send-email-hyun.kwon@xilinx.com>
Hi Hyun,
Thank you for the patch.
On Wednesday, 7 February 2018 03:36:39 EET Hyun Kwon wrote:
> This driver creates DRM encoder and connector for ZynqMP DisplayPort.
>
> Signed-off-by: Hyun Kwon <hyun.kwon@xilinx.com>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Before I go and review the code, shouldn't this be implemented as a drm_bridge
driver ?
> ---
> v2
> - Change the SPDX identifier format
> - Split drm properties into a separate patch
> ---
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 1738 +++++++++++++++++++++++++++++++++++
> drivers/gpu/drm/xlnx/zynqmp_dp.h | 37 +
> 2 files changed, 1775 insertions(+)
> create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dp.c
> create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dp.h
[snip]
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-22 0:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 1:36 [PATCH v5 1/5] drm: xlnx: Xilinx DRM KMS module Hyun Kwon
[not found] ` <1517967400-16993-1-git-send-email-hyun.kwon-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2018-02-07 1:36 ` [PATCH v5 2/5] dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings Hyun Kwon
2018-02-22 14:23 ` Laurent Pinchart
2018-02-23 2:27 ` Hyun Kwon
2018-02-07 1:36 ` [PATCH v5 3/5] drm: xlnx: DRM KMS driver for Xilinx ZynqMP DP subsystem display Hyun Kwon
2018-02-07 1:36 ` [PATCH v5 4/5] drm: xlnx: DRM KMS driver for Xilinx ZynqMP DisplayPort Hyun Kwon
2018-02-22 0:18 ` Laurent Pinchart [this message]
2018-02-22 2:51 ` Hyun Kwon
2018-02-07 1:36 ` [PATCH v5 5/5] drm: xlnx: ZynqMP DP subsystem DRM KMS driver Hyun Kwon
2018-02-19 9:43 ` [PATCH v5 1/5] drm: xlnx: Xilinx DRM KMS module Daniel Vetter
2018-02-20 17:11 ` hyun.kwon
2018-02-21 23:22 ` Laurent Pinchart
2018-02-22 2:51 ` Hyun Kwon
2018-02-21 23:17 ` Laurent Pinchart
2018-02-22 2:50 ` Hyun Kwon
2018-02-22 13:40 ` Laurent Pinchart
2018-02-23 2:23 ` Hyun Kwon
2018-02-28 2:15 ` Hyun Kwon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1979079.CDeAWn4OqI@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel.vetter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hyun.kwon@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).