From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v4 1/8] arm64: dts: rockchip: Clean up /memory nodes Date: Tue, 12 Apr 2016 07:24:31 +0200 Message-ID: <1991772.fLocq5xWEX@phil> References: <1458136727-32075-1-git-send-email-afaerber@suse.de> <1776429.KtRq374vTa@phil> <11405116.V0u286Y0bM@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <11405116.V0u286Y0bM@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Andreas =?ISO-8859-1?Q?F=E4rber?= Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Pawel Moll , Ian Campbell , Catalin Marinas , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Kumar Gala , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Am Donnerstag, 31. M=E4rz 2016, 22:45:52 schrieb Heiko Stuebner: > Am Donnerstag, 31. M=E4rz 2016, 19:15:43 schrieb Heiko Stuebner: > > Am Samstag, 19. M=E4rz 2016, 09:04:08 schrieb Heiko Stuebner: > > > Am Mittwoch, 16. M=E4rz 2016, 14:58:39 schrieb Andreas F=E4rber: > > > > A dtc update results in warnings for nodes with reg property but > > > > without > > > > unit address in the node name, so rename /memory to /memory@0. > > > > = > > > > Signed-off-by: Andreas F=E4rber > > > = > > > applied to a dts64-fixes branch for 4.6, after changing the commit > > > message to ---- > > > A dtc update results in warnings for nodes with reg property but > > > without > > > unit address in the node name, so rename /memory to > > > /memory@startaddress > > > (memory starts at 0 in the case of the rk3368). > > > ---- > > > = > > > To clarify that the @0 is not arbitary chosen. > > = > > This dtc update in question hasn't landed in v4.6-rc1 and from what I > > gathered will need some changes. The patch is obviously still correct, > > but I have now moved it from v4.6-fixes to the regular v4.7 64bit dts > > changes. > = > also it seems "memory" is special and memory without unitname will stay > allowed [0], especially as uboot or other bootloaders may expect such a > node to insert the actual amount of memory into it. > = > Looking at uboot, fdt_fixup_memory_banks seems to look explicitly for a > "memory" node, so I'm actually not sure, if this is safe to keep at all. so after pondering this some more, I decided to drop this change again. /memory will stay allowed and might produce less issues with bootloaders = touching the memory values. > [0] http://www.spinics.net/lists/arm-kernel/msg494038.html