From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D760CC433EF for ; Fri, 17 Dec 2021 15:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237903AbhLQPIO (ORCPT ); Fri, 17 Dec 2021 10:08:14 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:57450 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237916AbhLQPIK (ORCPT ); Fri, 17 Dec 2021 10:08:10 -0500 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 49AA93F1C0 for ; Fri, 17 Dec 2021 15:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1639753689; bh=EscRM3zeuMe4QRAvQ51JRRs9n/Wn3urOySWDrMNRXHw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=rjcQdHWjkK5f2b7QhVLPgWOOpytka38cEeOVd74xB1aZWmrQbV3DYJqMShr7WtcvV kpcI4ZK+YBRzRicYT/ldazDJTzgOuVzyk9CY6b9Dp3J3iJLmOgY0BlknvDDVKH2iZw P0Rg+KTz+RSfjuin295ah3G+k7wpvffPVoMfSKMve02S8Ic8NeuRVf3wHTasTtiVEd AmBwsJCfLMTua9KV6KqLZiDoSI1A/UNd9gHZEElsLbsBDTAbuvfIt3dtnNFdz0Ed1g 4+PaFGXrNXrwtcSFhRk510XTJn19pSm6bIxi4pzQAszEfGX2RfFO+oB6B7ctlswzVu B11PTQGvjb2Zw== Received: by mail-ed1-f71.google.com with SMTP id d13-20020a056402516d00b003e7e67a8f93so2232061ede.0 for ; Fri, 17 Dec 2021 07:08:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=EscRM3zeuMe4QRAvQ51JRRs9n/Wn3urOySWDrMNRXHw=; b=auOgu0sEQXZ9ZKAYJr39shdi61BtN0bhLcyobn4lHsQEfTD0J8MkGx70JNlYl9PO74 ARsDLROY6xJers+Zlanu/Om7+FsynX/4CHoO41cs7oNcKx8YuzD6I+GB1O9HVh+2gdqa Y1hOnxfoso7Po0uGvnuAR2G39W9Bt243le6Udr1FuTwZEeAYxHXSArazcCPkx9Ugu0aB VBJ4Ia0DU8QrQPP+6AJ65TirEBuGy8JEqAdpKqVTncs5byuwDh8bu8spYTBUXlF+gJHW nbwC1e9jDVMmuzzxSmZ2QoB9HuIF7yfnTDC3T7cZ9Z1RH+lyV3xLWAjCWcvOPgJrXb6a Q+Pg== X-Gm-Message-State: AOAM53113/6G7815qTv/QFp5efgdrkdxGcQirbol5fcNytu72RWYiISH +cV7+Hx444jjbRykzQ4WYMJfse/C46bPRecvtii0aSuBQ1takiLnX1XjRMFEFrRuHDj/pb5PVD0 rw4Z56o5Sa6Dd39KRhEKYf+s1IB8mbYAauHrEoy0= X-Received: by 2002:a05:6512:368a:: with SMTP id d10mr3057498lfs.476.1639753678783; Fri, 17 Dec 2021 07:07:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjit/KxYQojMyrYyqg3tppu8lupjtyMuTl3o4zZeCjXmcoayEWshoXqKAPpfREvzZOsoCa7Q== X-Received: by 2002:a05:6512:368a:: with SMTP id d10mr3057453lfs.476.1639753678217; Fri, 17 Dec 2021 07:07:58 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id 18sm1764464ljr.17.2021.12.17.07.07.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 07:07:57 -0800 (PST) Message-ID: <19cbe2ba-7df5-7c7c-289f-6dc419d9f477@canonical.com> Date: Fri, 17 Dec 2021 16:07:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v2 06/17] dt-bindings: rng: add bindings for microchip mpfs rng Content-Language: en-US From: Krzysztof Kozlowski To: conor.dooley@microchip.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, robh+dt@kernel.org, jassisinghbrar@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, a.zummo@towertech.it, alexandre.belloni@bootlin.com, broonie@kernel.org, gregkh@linuxfoundation.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, lee.jones@linaro.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-crypto@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Cc: geert@linux-m68k.org, bin.meng@windriver.com, heiko@sntech.de, lewis.hanly@microchip.com, daire.mcnamara@microchip.com, ivan.griffin@microchip.com, atish.patra@wdc.com References: <20211217093325.30612-1-conor.dooley@microchip.com> <20211217093325.30612-7-conor.dooley@microchip.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/12/2021 15:53, Krzysztof Kozlowski wrote: > On 17/12/2021 10:33, conor.dooley@microchip.com wrote: >> From: Conor Dooley >> >> Add device tree bindings for the hardware rng device accessed via >> the system services on the Microchip PolarFire SoC. >> >> Signed-off-by: Conor Dooley >> --- >> .../bindings/rng/microchip,mpfs-rng.yaml | 29 +++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml >> >> diff --git a/Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml b/Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml >> new file mode 100644 >> index 000000000000..32cbc37c9292 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml >> @@ -0,0 +1,29 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/rng/microchip,mpfs-rng.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Microchip MPFS random number generator >> + >> +maintainers: >> + - Conor Dooley >> + >> +description: | >> + The hardware random number generator on the Polarfire SoC is >> + accessed via the mailbox interface provided by the system controller >> + >> +properties: >> + compatible: >> + const: microchip,mpfs-rng >> + >> +required: >> + - compatible >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + hwrandom: hwrandom { > > Three topics: > 1. Node name (as most of others are using): rng > 2. skip the label, not helping in example. > 3. This looks very simple, so I wonder if the bindings are complete. No > IO space/address... How is it going to be instantiated? > OK, now I saw the usage in DTS. I have doubts this makes sense as separate bindings. It looks like integrated part of syscontroller, so maybe make it part of that binding? Or at least add ref to syscontroller bindings that such child is expected. Best regards, Krzysztof