From: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
To: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
Cc: devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"open list:BLUETOOTH DRIVERS"
<linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Gustavo F. Padovan"
<gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org>,
Johan Hedberg
<johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/3] Bluetooth: hci_ll: add support for setting public address
Date: Fri, 8 Dec 2017 13:21:17 -0600 [thread overview]
Message-ID: <1a106ed6-1408-4d0b-9c9d-5a3058d6df2d@lechnology.com> (raw)
In-Reply-To: <8B6C3CFA-35C6-4A9B-90AB-22834B9AE2C4-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
On 12/08/2017 02:07 AM, Marcel Holtmann wrote:
> Hi David,
>
>> This adds support for setting the public address on Texas Instruments
>> Bluetooth chips using a vendor-specific command.
>>
>> This has been tested on a CC2560A. The TI wiki also indicates that this
>> command should work on TI WL17xx/WL18xx Bluetooth chips.
>>
>> Signed-off-by: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
>> ---
>>
>> v2 changes:
>> * This is a new patch in v2
>>
>> drivers/bluetooth/hci_ll.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
>> index 974a788..b732004 100644
>> --- a/drivers/bluetooth/hci_ll.c
>> +++ b/drivers/bluetooth/hci_ll.c
>> @@ -57,6 +57,7 @@
>> #include "hci_uart.h"
>>
>> /* Vendor-specific HCI commands */
>> +#define HCI_VS_WRITE_BD_ADDR 0xfc06
>> #define HCI_VS_UPDATE_UART_HCI_BAUDRATE 0xff36
>>
>> /* HCILL commands */
>> @@ -662,6 +663,20 @@ static int download_firmware(struct ll_device *lldev)
>> return err;
>> }
>>
>> +static int ll_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr)
>> +{
>> + bdaddr_t bdaddr_swapped;
>> + struct sk_buff *skb;
>> +
>> + baswap(&bdaddr_swapped, bdaddr);
>> + skb = __hci_cmd_sync(hdev, HCI_VS_WRITE_BD_ADDR, sizeof(bdaddr_t),
>> + &bdaddr_swapped, HCI_INIT_TIMEOUT);
>> + if (!IS_ERR(skb))
>> + kfree_skb(skb);
>> +
>
> You have a trailing whitespace here.
>
> Does the HCI command really expect the BD_ADDR in the swapped order. The caller of hdev->set_bdaddr while provide it in the same order as the HCI Read BD Address command and everything in HCI. So it seems odd that you have to swap it for the vendor command.
>
> So have you actually tested this with btmgmt public-add <xx:xx..> and checked that the address comes out correctly. I think ll_set_bdaddr should function correctly for the mgmt interface. And if needed any other caller outside of mgmt has to do the swapping.
>
I did test using btmgmt public-address 00:11:22:33:44:55, which is how I
found out that the order needed to be swapped. Like you, I was
surprised. I couldn't find any documentation from TI saying what the
order is supposed to be, so I can only assume that because this works,
it is indeed correct as-is.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-08 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 2:57 [PATCH v2 0/3] Bluetooth: hci_ll: Get BD address from NVMEM (was "bluetooth: hci_ll: Get MAC address from NVMEM") David Lechner
2017-12-08 2:57 ` [PATCH v2 1/3] Bluetooth: hci_ll: add support for setting public address David Lechner
[not found] ` <1512701860-8321-2-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-12-08 8:07 ` Marcel Holtmann
[not found] ` <8B6C3CFA-35C6-4A9B-90AB-22834B9AE2C4-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-12-08 19:21 ` David Lechner [this message]
[not found] ` <1a106ed6-1408-4d0b-9c9d-5a3058d6df2d-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-12-08 19:24 ` Marcel Holtmann
2017-12-08 2:57 ` [PATCH v2 2/3] dt-bindings: Add optional nvmem BD address bindings to ti,wlink-st David Lechner
[not found] ` <1512701860-8321-3-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-12-08 8:08 ` Marcel Holtmann
2017-12-12 20:09 ` Rob Herring
2017-12-08 2:57 ` [PATCH v2 3/3] Bluetooth: hci_ll: Add optional nvmem BD address source David Lechner
[not found] ` <1512701860-8321-4-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-12-08 8:14 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a106ed6-1408-4d0b-9c9d-5a3058d6df2d@lechnology.com \
--to=david-nq/r/kbu++upp/zk7jdf2g@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org \
--cc=johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).