From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Saalim Quadri <danascape@gmail.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, daniel.baluta@nxp.com
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: alc5632: Convert to dtschema
Date: Thu, 23 Mar 2023 16:15:04 +0100 [thread overview]
Message-ID: <1a2e0f7a-771f-5590-fc54-b9dbf059a925@linaro.org> (raw)
In-Reply-To: <20230323130511.16367-1-danascape@gmail.com>
On 23/03/2023 14:05, Saalim Quadri wrote:
> Convert the ALC5632 audio codec bindings to DT schema.
>
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
Thank you for your patch. There is something to discuss/improve.
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ALC5632 audio CODEC
> +
> +description: |
> + Pins on the device (for linking into audio routes):
> + * SPK_OUTP
> + * SPK_OUTN
> + * HP_OUT_L
> + * HP_OUT_R
> + * AUX_OUT_P
> + * AUX_OUT_N
> + * LINE_IN_L
> + * LINE_IN_R
> + * PHONE_P
> + * PHONE_N
> + * MIC1_P
> + * MIC1_N
> + * MIC2_P
> + * MIC2_N
> + * MICBIAS1
> + * DMICDAT
> +
> +maintainers:
> + - Liam Girdwood <lgirdwood@gmail.com>
This should not be subsystem maintainer but someone related to the
device. It's maintainer or interested contributor. Unless that's the
case here?
> +
> +properties:
> + compatible:
> + const: realtek,alc5632
> +
> + reg:
> + maxItems: 1
> +
> + '#gpio-cells':
> + const: 2
> +
> + gpio-controller: true
> +
> +required:
> + - compatible
> + - reg
> + - '#gpio-cells'
> + - gpio-controller
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + alc5632: alc5632@1a {
Node name: codec
and drop alc5632 label
> + compatible = "realtek,alc5632";
> + reg = <0x1a>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-23 15:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 13:05 [PATCH] ASoC: dt-bindings: alc5632: Convert to dtschema Saalim Quadri
2023-03-23 15:15 ` Krzysztof Kozlowski [this message]
2023-03-23 17:11 ` Saalim Quadri
2023-03-23 19:08 ` Krzysztof Kozlowski
2023-03-23 19:17 ` Mark Brown
2023-03-23 19:37 ` [PATCH v2] " Saalim Quadri
2023-03-24 0:03 ` Mark Brown
2023-03-24 8:43 ` Krzysztof Kozlowski
2023-03-24 8:45 ` Krzysztof Kozlowski
2023-03-24 8:45 ` [PATCH] " Krzysztof Kozlowski
2023-03-25 16:36 ` [PATCH v2] " Saalim Quadri
2023-03-26 13:10 ` [PATCH v3] " Saalim Quadri
2023-03-26 14:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a2e0f7a-771f-5590-fc54-b9dbf059a925@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=danascape@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).