devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stefan Riedmüller" <s.riedmueller@phytec.de>
To: Marco Felsch <m.felsch@pengutronix.de>,
	robh+dt@kernel.org, shawnguo@kernel.org
Cc: festevam@gmail.com, linux-imx@nxp.com, m.podolszki@phytec.de,
	devicetree@vger.kernel.org, kernel@pengutronix.de,
	c.hemp@phytec.de, j.remmet@phytec.de
Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: add Phytec Nunki boards
Date: Wed, 14 Oct 2020 09:07:24 +0200	[thread overview]
Message-ID: <1bf364fd-6530-ca5a-06f2-25c3c9dd684a@phytec.de> (raw)
In-Reply-To: <20201007133450.rx7jrqb3euxstjiw@pengutronix.de>

Hi Marco,

On 07.10.20 15:34, Marco Felsch wrote:
> Add missing Phytec developers to Cc.
> 
> Regards,
>    Marco
> 
> On 20-10-07 15:30, Marco Felsch wrote:
>> Add bindings for the Phytec PhyBOARD-Nunki evalboards.
>>
>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>> ---
>> Hi,
>>
>> I copied the imx6q-phytec-nunki-rdk-nand.dts and
>> imx6qdl-phytec-nunki.dtsi from the phytec downstream kernel repo and
>> added support for the imx6qp-phytec-nunki-rdk-nand.dts.
>>
>> @Phytec
>> I adapted the "phytec,imx6q-pbac11-nand" to "phytec,imx6qp-pbac11-nand"
>> and "phytec,imx6q-pbac11" to "phytec,imx6qp-pbac11". Can you verify that
>> since I have no knowledge about the internal naming scheme, thanks.

Yes, that is correct.

>>
>> Regards,
>>    Marco
>>
>>   Documentation/devicetree/bindings/arm/fsl.yaml | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 6da9d734cdb7..26410a42c411 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -156,6 +156,13 @@ properties:
>>             - const: gw,ventana
>>             - const: fsl,imx6q
>>   
>> +      - description: i.MX6Q Phytec PhyBOARD-Nunki Board

Please use all caps for PHYTEC and start phyBOARD with a lower case p.

>> +        items:
>> +          - const: phytec,imx6q-pbac11-nand
>> +          - const: phytec,imx6q-pbac11
>> +          - const: phytec,imx6qdl-pcm058
>> +          - const: fsl,imx6q
>> +
>>         - description: i.MX6QP based Boards
>>           items:
>>             - enum:
>> @@ -163,6 +170,13 @@ properties:
>>                 - fsl,imx6qp-sabresd        # i.MX6 Quad Plus SABRE Smart Device Board
>>             - const: fsl,imx6qp
>>   
>> +      - description: i.MX6QP Phytec PhyBOARD-Nunki Board

Same here.

With these changes you can add my
Reviewed-by: Stefan Riedmueller <s.riedmueller@phytec.de>

Thanks,
Stefan

>> +        items:
>> +          - const: phytec,imx6qp-pbac11-nand
>> +          - const: phytec,imx6qp-pbac11
>> +          - const: phytec,imx6qdl-pcm058
>> +          - const: fsl,imx6qp
>> +
>>         - description: i.MX6DL based Boards
>>           items:
>>             - enum:
>> -- 
>> 2.20.1
>>
>>
>>
> 

  reply	other threads:[~2020-10-14  7:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 13:30 [PATCH 1/2] dt-bindings: arm: fsl: add Phytec Nunki boards Marco Felsch
2020-10-07 13:30 ` [PATCH 2/2] ARM: dts: imx6: Add support for phyBOARD-Nunki Marco Felsch
2020-10-07 13:35   ` Marco Felsch
2020-10-14  7:07     ` Stefan Riedmüller
2020-10-07 13:34 ` [PATCH 1/2] dt-bindings: arm: fsl: add Phytec Nunki boards Marco Felsch
2020-10-14  7:07   ` Stefan Riedmüller [this message]
2020-10-07 16:10 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bf364fd-6530-ca5a-06f2-25c3c9dd684a@phytec.de \
    --to=s.riedmueller@phytec.de \
    --cc=c.hemp@phytec.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=j.remmet@phytec.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=m.felsch@pengutronix.de \
    --cc=m.podolszki@phytec.de \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).