From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E94FEC433EF for ; Tue, 4 Jan 2022 13:42:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233569AbiADNm5 (ORCPT ); Tue, 4 Jan 2022 08:42:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233563AbiADNm4 (ORCPT ); Tue, 4 Jan 2022 08:42:56 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65DE6C061785 for ; Tue, 4 Jan 2022 05:42:56 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id p13so45534779lfh.13 for ; Tue, 04 Jan 2022 05:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CVpeJhNnnVKJagaPYcbOi0NCayI2FL47sRRfcXPZVY0=; b=nGS6WRAzk1GweADb0QgD4jM8kaUNtROiC5ChudlWBAaqc+8BNYezI+kaKnjXP/eWzn jnDE8cgRzdLj1TUlNXLBj3l1dj6WVJV8p/Zf6LSPJQaN+pT/7xh6DyASYDpzUS8Rr7// t1L/YWFa2QiaGMc7na3FbYO7V0fHPNg2e/DxHVfYDKqT8e4NxruZ4JLF/GeubPaKqOQo wnFcxCXASFwWhWupkjJ1oV6jg21umYStFLlDbKSmvy5MW8X/ilW6rSKXfoEoH3EGwOmf IXPQCEtdbx68ONS1BYIwAT4g7NMs00s5pXjm6nZ1F/LddCIZzM6TVIwER8HXefKF1nYR iZxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CVpeJhNnnVKJagaPYcbOi0NCayI2FL47sRRfcXPZVY0=; b=4tKtq+J589TyyjIhVcDABzHu31H3oZ5mJ+mObgS3cmMCMCOyYYv7DvegCfUhSF5OqC RevBA0YU7vL+B80suzAuNb/Lx+BiGu3DYF0LqsJjMuPo3muAp1BdNK7QTgw3kc+BQxEJ 2yp0gYt1AZFGoOLErFNVrrmSw1ZlQKW52Cj+8YMXrSOmvTX0p5vkvysBkz8eN3Fstvop OKCUlwCJN9z45dZLL3CitEDWRzuKWptmBAAWIUEmDfYFSf9UX94z3MbBhCrytkLzk5xZ CjAo3yQXLZ/oEMm5G8u9U2x44865+QMRR0JVz6t4dUUKl6ejqPNYG4V+Z3peq7eeN6kE +7bg== X-Gm-Message-State: AOAM531tKblGcuyI0zcFOb6VnLFSXsGjH3dEDSz5PEUkrVS5V+hxivB+ p7aAL61fkGiUjdWkBDWmwpre2w== X-Google-Smtp-Source: ABdhPJz0WetOli7nYV+1tu6Agc/xaocYrri7GSX5u0JaXCXv71asXwe9UZqJdXYUvIGXJK/jpHUjWg== X-Received: by 2002:ac2:4c54:: with SMTP id o20mr45357532lfk.369.1641303774586; Tue, 04 Jan 2022 05:42:54 -0800 (PST) Received: from [192.168.1.102] (88-113-46-102.elisa-laajakaista.fi. [88.113.46.102]) by smtp.gmail.com with ESMTPSA id i7sm3414551lfu.175.2022.01.04.05.42.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 05:42:54 -0800 (PST) Subject: Re: [PATCH v3 01/19] media: dt-bindings: media: camss: Add qcom,sm8250-camss binding To: Bryan O'Donoghue , Robert Foss Cc: jonathan@marek.ca, andrey.konovalov@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, jgrahsl@snap.com, hfink@snap.com, dmitry.baryshkov@linaro.org, devicetree@vger.kernel.org, Rob Herring , hverkuil@xs4all.nl, mchehab@kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org References: <20211222003751.2461466-1-bryan.odonoghue@linaro.org> <20211222003751.2461466-2-bryan.odonoghue@linaro.org> From: Vladimir Zapolskiy Message-ID: <1d753716-ba3c-8fb6-eeaf-7c68ef0c6e5c@linaro.org> Date: Tue, 4 Jan 2022 15:42:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20211222003751.2461466-2-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Bryan, Robert, On 12/22/21 2:37 AM, Bryan O'Donoghue wrote: > From: Jonathan Marek > > Add bindings for qcom,sm8250-camss in order to support the camera > subsystem for SM8250. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Jonathan Marek > Signed-off-by: Bryan O'Donoghue > Reviewed-by: Rob Herring > --- > .../bindings/media/qcom,sm8250-camss.yaml | 450 ++++++++++++++++++ > 1 file changed, 450 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml > > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml > +required: > + - clock-names > + - clocks > + - compatible > + - interconnects > + - interconnect-names > + - interrupts > + - interrupt-names > + - iommus > + - power-domains > + - reg > + - reg-names > + > +additionalProperties: false I've discovered that there is a noticeable difference between this bindings and all the previous ones, for instance see qcom,sdm845-camss.yaml There is no required 'vdda-supply' property on the list, and fwiw I believe there should be two supply properties for 0p9 and 1p2 supplies in fact. Similarly, two separate supplies should be present in sdm845 camss bindings. At the moment the driver operates with 'vdda' supply only, commit 9e5d1581 introduced undocumented 'vdd_sec' for sdm660, but, if I'm not mistaken, it's unused. In my opinion now it's a convenient moment to add descriptions and support of two vdda regulators, comments are more than welcome. -- Best wishes, Vladimir