From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowjanya Komatineni Subject: Re: [PATCH v7 16/20] arm64: tegra: Enable wake from deep sleep on RTC alarm Date: Thu, 1 Aug 2019 10:56:09 -0700 Message-ID: <1e2e6282-9d94-e322-c4ba-8a1f3b902860@nvidia.com> References: <1564532424-10449-1-git-send-email-skomatineni@nvidia.com> <1564532424-10449-17-git-send-email-skomatineni@nvidia.com> <1233ad49-22eb-a90a-d7cf-5fe133ded177@gmail.com> <4f8b9ee7-5402-6463-d6d2-7b00e274a185@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4f8b9ee7-5402-6463-d6d2-7b00e274a185@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko , thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linus.walleij@linaro.org, stefan@agner.ch, mark.rutland@arm.com Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, jckuo@nvidia.com, josephl@nvidia.com, talho@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, mperttunen@nvidia.com, spatra@nvidia.com, robh+dt@kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 8/1/19 3:43 AM, Dmitry Osipenko wrote: > 01.08.2019 0:08, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On 7/31/19 4:04 AM, Dmitry Osipenko wrote: >>> 31.07.2019 3:20, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> This patch updates device tree for RTC and PMC to allow system wake >>>> from deep sleep on RTC alarm. >>>> >>>> Signed-off-by: Sowjanya Komatineni >>>> --- >>>> =C2=A0 arch/arm64/boot/dts/nvidia/tegra210.dtsi | 5 ++++- >>>> =C2=A0 1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi >>>> b/arch/arm64/boot/dts/nvidia/tegra210.dtsi >>>> index 659753118e96..30a7c48385a2 100644 >>>> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi >>>> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi >>>> @@ -768,7 +768,8 @@ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rtc@7000e000 { >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible =3D= "nvidia,tegra210-rtc", "nvidia,tegra20-rtc"; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reg =3D <0x0 0= x7000e000 0x0 0x100>; >>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 interrupts =3D ; >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 interrupts =3D <16 IRQ_TYP= E_LEVEL_HIGH>; >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 interrupt-parent =3D <&pmc= >; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clocks =3D <&t= egra_car TEGRA210_CLK_RTC>; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clock-names = =3D "rtc"; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }; >>>> @@ -778,6 +779,8 @@ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reg =3D <0x0 0= x7000e400 0x0 0x400>; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clocks =3D <&t= egra_car TEGRA210_CLK_PCLK>, <&clk32k_in>; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clock-names = =3D "pclk", "clk32k_in"; >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #interrupt-cells =3D <2>; >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 interrupt-controller; >>>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 powerga= tes { >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 pd_audio: aud { >>>> >>> Is this a backwards-compatible change? Or it's not really worth to care >>> about the compatibility with older kernel versions, I'm not sure about >>> overall state of T210 in the upstream kernel. >> I don't think its required to be backwards-compatible as SC7 entry/exit >> implementation for T210 is with this patch series onwards.. > The new device tree binary should work with older kernel versions, AFAIK > this is the upstream rule. But if kernel support isn't in a very good > shape and not much people are using it, then obviously it is not very > important. Yes, my response to backwards-compatible was with respect to interrupt=20 parent change as this will not be backward compatible and also there is=20 no Tegra210 suspend/resume earlier. Other functionality wise, it is=20 backward compatible.