From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Li Subject: Re: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU Date: Mon, 22 Jan 2018 09:18:09 +0800 Message-ID: <1f4b3c0d-1414-0012-a072-f4a11f432c21@rock-chips.com> References: <20180118115251.5542-1-jeffy.chen@rock-chips.com> <20180118115251.5542-9-jeffy.chen@rock-chips.com> <5A60AE41.2050101@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5A60AE41.2050101-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: JeffyChen , Robin Murphy , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xxm-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Joerg Roedel , jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Heiko Stuebner List-Id: devicetree@vger.kernel.org On 01/18/2018 10:25 PM, JeffyChen wrote: > Hi Robin, > > On 01/18/2018 08:27 PM, Robin Murphy wrote: >>> >> >> Is it worth using the clk_bulk_*() APIs for this? At a glance, most of >> the code being added here appears to duplicate what those functions >> already do (but I'm no clk API expert, for sure). > right, i think it's doable, the clk_bulk APIs are very helpful. i think > we didn't use that is because this patch were wrote for the chromeos 4.4 > kernel, which doesn't have clk_bulk yet:) > > will do it in the next version, thanks. Also the power domain driver could manage the clocks as well, I would suggest to use pm_runtime_*. >> >> Robin. > > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > -- Randy Li -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html