From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDEFEC43331 for ; Tue, 12 Nov 2019 17:20:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5D3320659 for ; Tue, 12 Nov 2019 17:20:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="ofkdojRw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727178AbfKLRU0 (ORCPT ); Tue, 12 Nov 2019 12:20:26 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:54195 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727415AbfKLRUZ (ORCPT ); Tue, 12 Nov 2019 12:20:25 -0500 Received: by mail-wm1-f68.google.com with SMTP id u18so4110851wmc.3 for ; Tue, 12 Nov 2019 09:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=F9Mi7+/IyXkSUZB/fTNJuaXmyudI2hLv+NhDB5xxcQw=; b=ofkdojRwVgmhNvnCD+2JDgQT0KlK5MBV3Sul2Zn31ERD+BYM+PAXwVySBsJDATt2EO 1sRudy8e9QEsOEj8Zlf/XsDUe52amWr1KBn9SfYRcTP735H727LCNtvI9NrDP1Da2IeA uPdil0WXQHUV90rkK8vK/gt6ConlUrBnhH6mr+6e1TTPpsuRSF1ajrAauWUxfKaqAtm8 xfuOvOpPedqwNWe/JB+uevGYyrgwUHXwtjLyNRsLhTwQTSOBmJBZv0Ku5aLfEXe52zNd 4MYaQ5XfMpNe2tslllZ6kxVJ0iLsHkF6RQMOXlaEWGJvw4ySss2DR6bs87yAoXhkhvkW dyeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=F9Mi7+/IyXkSUZB/fTNJuaXmyudI2hLv+NhDB5xxcQw=; b=Nj5BmL6Ap5x5LvXULGAwaPKLU0EImR4IGFhQ68V2x73xB1h2ofUcg33eA4MFFuS670 css3eTYnPEQhguM2ktPHC3t1gYkLtYDeedzAyUOM4tbF9qFD9eOxeM++ePoVWjuZLY4X Zciwzfe6QWMJKU3IYlgYFFFPj7/fTNyOtQlCQU9/fgSBlu9hUQMuJE4c0TyY+wutRJmY +pL+3v0EuzyTjLqObvtvDBIkBfz9X0Erxwx8IwZNixowKs3FHMGmYzTSHiBUW56oUpFD xA+kXrJLYW2hrlnOeOtF1G0BgG/gWH+DIG4y7z3+x+qgOzVCMhiu8/kkWKPQHXnuliYl w4Cg== X-Gm-Message-State: APjAAAWZzN+17gbVlqWDi83VxfZo1xg0aq/8W8r4fukP6C+A7XLhwX/x 7Nal867XFmrb5OMNXc94EvszokfS8FU= X-Google-Smtp-Source: APXvYqzR2tT3ef66DmAq2qnSk2dUDm/RUEfrwxO4e9F/cIoV/ljD0W55pomXTkbTaTNVd0DASTw0oA== X-Received: by 2002:a7b:c392:: with SMTP id s18mr4515631wmj.61.1573579221902; Tue, 12 Nov 2019 09:20:21 -0800 (PST) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id d18sm18576621wrm.85.2019.11.12.09.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 09:20:21 -0800 (PST) References: <20191027162328.1177402-1-martin.blumenstingl@googlemail.com> <20191027162328.1177402-3-martin.blumenstingl@googlemail.com> <20191108221652.32FA2206C3@mail.kernel.org> User-agent: mu4e 1.3.3; emacs 26.2 From: Jerome Brunet To: Stephen Boyd , Martin Blumenstingl , khilman@baylibre.com, linux-amlogic@lists.infradead.org, narmstrong@baylibre.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 2/5] clk: meson: add a driver for the Meson8/8b/8m2 DDR clock controller In-reply-to: <20191108221652.32FA2206C3@mail.kernel.org> Date: Tue, 12 Nov 2019 18:20:20 +0100 Message-ID: <1jd0dxf1uz.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org >> +static const struct of_device_id meson8_ddr_clkc_match_table[] = { >> + { .compatible = "amlogic,meson8-ddr-clkc" }, >> + { .compatible = "amlogic,meson8b-ddr-clkc" }, >> + { /* sentinel */ }, > > Super nitpick, drop the comma above so that nothing can follow this. I don't think it is worth reposting the series Martin. If it is ok with you, I'll just apply it with Stephen comments In the future, I would prefer if you could separate the series for clock (intended for Neil and myself) and the DT one (intended for Kevin) Thx > >> +}; >> + >> +static struct platform_driver meson8_ddr_clkc_driver = { >> + .probe = meson8_ddr_clkc_probe, >> + .driver = { >> + .name = "meson8-ddr-clkc", >> + .of_match_table = meson8_ddr_clkc_match_table, >> + }, >> +}; >> + >> +builtin_platform_driver(meson8_ddr_clkc_driver); >> -- >> 2.23.0 >>