From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91411C3F2D1 for ; Thu, 5 Mar 2020 08:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62CE32073D for ; Thu, 5 Mar 2020 08:16:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="uvMsy2gF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725937AbgCEIQA (ORCPT ); Thu, 5 Mar 2020 03:16:00 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:42500 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbgCEIP7 (ORCPT ); Thu, 5 Mar 2020 03:15:59 -0500 Received: by mail-wr1-f66.google.com with SMTP id v11so3859318wrm.9 for ; Thu, 05 Mar 2020 00:15:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version; bh=59ResbYkgYYtyGS3yqL1pe7i5n25xfvpTn1SJGZoQcc=; b=uvMsy2gFIQJuGwPQY4jTQZfM443hyAsMpQsWvt61TsBrrNb5+brqKR7fyXH16dpcUG NKHn+FHej/vn1kTGDZAOiT3te05ZccNq2vpP9gefTXD4I8jUaaSMpDCA+puh6P7ugPyN Mq7CTRQp8ON7UQ8wyQBrxWkNHSBgn0GUrhEMx1wbzjnVma9BXBHRHMUXZ0u2P0xEa8lJ DaG2SUbfh2TZLAYPQNjz3QPd8SSGcSHivVrvmeFzY2wnQcFZQVrX8n1b+M7K41fDnb2V eqa2HBw0fdA4F/n4kWCqTVQAxYnxfMrF2BbKv5TCUD4Ge+NID+Dhpu/0B5cPIlHVEg20 VWgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version; bh=59ResbYkgYYtyGS3yqL1pe7i5n25xfvpTn1SJGZoQcc=; b=iPn893909RKrnUltGlyu8f+sf2xyes005zfig4TJ6HgJW//OwgAhSTpvXXU7QsXwEL Lng3egVflXgGrzPoEOZAC09MAW2vtr+DRCrFBQEw1TFvtd8mp+FIKip2l7vIHddP292l 3raxmE+NAlMKu7pkAttujDrZmIXbKkPiedLVH8peGhZm9yZVK9BrT9UsxaTBZlSt4iih PPXWVRoCuecrpInrE89tVjWf06ILZLwC214ti9juW4G3kN+30l+3yjDWzOtFAT/0iCHp Elec17YDzLUVXKwvtWqZsMbaXoPj36Cq67repAL2fInnaaOC1iYyzeNvbUjvqKutUr6Q kCcg== X-Gm-Message-State: ANhLgQ1xOp3E0JfpVMIBVv1VlKSDQ96a6pd8Kr5XjQgLScX59SGsuX0e u9PeY5mAS6YqCaMX/1d2v+Ou0w== X-Google-Smtp-Source: ADFU+vuuoKy23fJWsGIKanNj5vBpIUf8a+/Rb9mL+rPcSl7wR8cgvC2houSQAoG3kJh7HFjBsXemgw== X-Received: by 2002:adf:f70f:: with SMTP id r15mr8903620wrp.269.1583396158372; Thu, 05 Mar 2020 00:15:58 -0800 (PST) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id c2sm8220616wma.39.2020.03.05.00.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 00:15:57 -0800 (PST) References: <1582991214-85209-1-git-send-email-christianshewitt@gmail.com> <1582991214-85209-3-git-send-email-christianshewitt@gmail.com> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Christian Hewitt , Rob Herring , Mark Rutland , Kevin Hilman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: meson-g12a-tanix-tx5max: add initial device tree In-reply-to: <1582991214-85209-3-git-send-email-christianshewitt@gmail.com> Date: Thu, 05 Mar 2020 09:15:56 +0100 Message-ID: <1jh7z3cj43.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat 29 Feb 2020 at 16:46, Christian Hewitt wrote: > The Oranth Tanix TX5 Max is based on the Amlogic U200 reference design > using the S905X2 chipset. Hardware specification: > > - 4GB LPDDR4 RAM > - 32GB eMMC storage > - 10/100/1000 Base-T Ethernet using External RGMII PHY > - 802.11 a/b/g/b/ac + BT 4.1 sdio wireless > - HDMI 2.0 (4k@60p) video > - Composite video + 2-channel audio output on 3.5mm jack > - S/PDIF audio output > - 1x USB 3.0 > - 1x USB 2.0 > - 1x micro SD card slot > > The device tree is based on the higher-spec X96 Max box device. Would you mind pointing out the differences ? Maybe I missed something, but do we really this dts ? Can't this device directly use the x96 dt, or the u200 ? All these boards, for which we don't have any documentation, add up > > Signed-off-by: Christian Hewitt > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../boot/dts/amlogic/meson-g12a-tanix-tx5max.dts | 481 +++++++++++++++++++++ > 2 files changed, 482 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12a-tanix-tx5max.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index eef0045..a1db803 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_MESON) += meson-axg-s400.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-sei510.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-g12a-tanix-tx5max.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-u200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-tanix-tx5max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-tanix-tx5max.dts > new file mode 100644 > index 0000000..c3ef0ee > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-tanix-tx5max.dts > @@ -0,0 +1,481 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2018 BayLibre SAS. All rights reserved. > + */ > + > +/dts-v1/; [...] > +&spdifout_b { > + status = "okay"; > +}; Why do you need this ? This producer is dedicated to HDMI controller which does not support it ATM. Also it is not even used in your sound card Same goes for the x96 BTW. > + > +&tdmif_b { > + status = "okay"; > +}; > + > +&tdmout_b { > + status = "okay"; > +}; > + > +&tohdmitx { > + status = "okay"; > +};