From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH 2/5] firmware: meson_sm: Mark chip struct as static const Date: Tue, 30 Jul 2019 11:05:10 +0200 Message-ID: <1jv9vj28qh.fsf@starbuckisacylon.baylibre.com> References: <20190729183941.18164-1-ccaione@baylibre.com> <20190729183941.18164-3-ccaione@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190729183941.18164-3-ccaione@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: srinivas.kandagatla@linaro.org, khilman@baylibre.com, narmstrong@baylibre.com, robh+dt@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org Cc: Carlo Caione List-Id: devicetree@vger.kernel.org On Mon 29 Jul 2019 at 19:39, Carlo Caione wrote: > No need to be a global struct. > > Signed-off-by: Carlo Caione Reviewed-by: Jerome Brunet > --- > drivers/firmware/meson/meson_sm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c > index 8d908a8e0d20..772ca6726e7b 100644 > --- a/drivers/firmware/meson/meson_sm.c > +++ b/drivers/firmware/meson/meson_sm.c > @@ -35,7 +35,7 @@ struct meson_sm_chip { > struct meson_sm_cmd cmd[]; > }; > > -struct meson_sm_chip gxbb_chip = { > +static const struct meson_sm_chip gxbb_chip = { > .shmem_size = SZ_4K, > .cmd_shmem_in_base = 0x82000020, > .cmd_shmem_out_base = 0x82000021, > -- > 2.20.1