From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v6 1/4] Runtime Interpreted Power Sequences Date: Thu, 13 Sep 2012 16:09:55 +0800 Message-ID: <20120913080953.GC20959@opensource.wolfsonmicro.com> References: <1347443867-18868-1-git-send-email-acourbot@nvidia.com> <1347443867-18868-2-git-send-email-acourbot@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1347443867-18868-2-git-send-email-acourbot@nvidia.com> Sender: linux-doc-owner@vger.kernel.org To: Alexandre Courbot Cc: Stephen Warren , Thierry Reding , Simon Glass , Grant Likely , Rob Herring , Anton Vorontsov , David Woodhouse , Arnd Bergmann , Leela Krishna Amudala , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-pm@vger.kernel.org, linux-doc@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, Sep 12, 2012 at 06:57:44PM +0900, Alexandre Courbot wrote: > Some device drivers (panel backlights especially) need to follow precise > sequences for powering on and off, involving gpios, regulators, PWMs > with a precise powering order and delays to respect between each steps. > These sequences are board-specific, and do not belong to a particular > driver - therefore they have been performed by board-specific hook > functions to far. It does make me a little sad that the DT bindings need to specify the number of steps but otherwise this looks good (modulo the minor comments Stephen had as well): Reviewed-by: Mark Brown I think regardless of the current discussion about some of the applications (like pwm-backlight) there are going to be cases where this is useful even if it ends up being more as library code for drivers than as something that users work with directly.