From: Lee Jones <lee.jones@linaro.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Tony Lindgren <tony@atomide.com>,
Samuel Ortiz <sameo@linux.intel.com>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/7] mfd: menelaus: make vcore and regulator controls internal
Date: Tue, 20 Jan 2015 14:01:43 +0000 [thread overview]
Message-ID: <20150120140143.GQ13701@x1> (raw)
In-Reply-To: <20150120135840.GO13701@x1>
On Tue, 20 Jan 2015, Lee Jones wrote:
> On Sat, 27 Dec 2014, Aaro Koskinen wrote:
>
> > Make vcore and regulator control functions internal to the driver.
> >
> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > ---
> > drivers/mfd/menelaus.c | 13 +++++++++++--
> > include/linux/mfd/menelaus.h | 12 ------------
> > 2 files changed, 11 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
> > index 4a900cc..8660adf 100644
> > --- a/drivers/mfd/menelaus.c
> > +++ b/drivers/mfd/menelaus.c
> > @@ -163,6 +163,15 @@
> > #define MCT_PIN_ST_S1_CD_ST (1 << 0)
> > #define MCT_PIN_ST_S2_CD_ST (1 << 1)
> >
> > +#define EN_VPLL_SLEEP (1 << 7)
> > +#define EN_VMMC_SLEEP (1 << 6)
> > +#define EN_VAUX_SLEEP (1 << 5)
> > +#define EN_VIO_SLEEP (1 << 4)
> > +#define EN_VMEM_SLEEP (1 << 3)
> > +#define EN_DC3_SLEEP (1 << 2)
> > +#define EN_DC2_SLEEP (1 << 1)
> > +#define EN_VC_SLEEP (1 << 0)
>
> Better to use the BIT() macro for this kind of stuff.
>
> Please take this opportunity to use it.
In fact, nevermind. I'll do it from here.
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-20 14:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 17:52 [PATCH 0/7] Menelaus cleanup for DT, phase 1 Aaro Koskinen
2014-12-27 17:52 ` [PATCH 1/7] mfd: menelaus: delete omap_has_menelaus Aaro Koskinen
2015-01-20 13:50 ` Lee Jones
2014-12-27 17:52 ` [PATCH 2/7] mfd: menelaus: drop support for SW controller VCORE Aaro Koskinen
2015-01-20 13:52 ` Lee Jones
2014-12-27 17:52 ` [PATCH 3/7] mfd: menelaus: add initial DT support Aaro Koskinen
2014-12-27 21:25 ` Felipe Balbi
2014-12-28 23:34 ` Aaro Koskinen
2014-12-29 18:12 ` Felipe Balbi
2014-12-27 17:52 ` [PATCH 5/7] mfd: menelaus: delete platform data support Aaro Koskinen
2015-01-20 13:54 ` Lee Jones
2014-12-27 17:52 ` [PATCH 6/7] mfd: menelaus: make vcore and regulator controls internal Aaro Koskinen
2015-01-20 13:58 ` Lee Jones
2015-01-20 14:01 ` Lee Jones [this message]
2014-12-27 17:52 ` [PATCH 7/7] mfd: menelaus: use macro for magic number Aaro Koskinen
[not found] ` <1419702779-16001-8-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2015-01-20 14:01 ` Lee Jones
[not found] ` <1419702779-16001-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2014-12-27 17:52 ` [PATCH 4/7] ARM: OMAP: N8x0: configure menelaus using DT Aaro Koskinen
2015-01-20 17:13 ` [PATCH 0/7] Menelaus cleanup for DT, phase 1 Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120140143.GQ13701@x1 \
--to=lee.jones@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).