From: Rob Herring <robh@kernel.org>
To: Govindraj Raja <Govindraj.Raja@imgtec.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org,
Andrew Bresticker <abrestic@chromium.org>,
linux-mips@linux-mips.org,
James Hartley <James.Hartley@imgtec.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] pinctrl: pistachio: fix mfio84-89 function description and pinmux.
Date: Fri, 4 Mar 2016 22:31:37 -0600 [thread overview]
Message-ID: <20160305043137.GJ13525@rob-hp-laptop> (raw)
In-Reply-To: <1457105302-15070-1-git-send-email-Govindraj.Raja@imgtec.com>
On Fri, Mar 04, 2016 at 03:28:22PM +0000, Govindraj Raja wrote:
> mfio 84 to 89 are described wrongly, fix it to describe
> the right pin and add them to right pin-mux group.
>
> The correct order is:
> pll1_lock => mips_pll -- MFIO_83
> pll2_lock => audio_pll -- MFIO_84
> pll3_lock => rpu_v_pll -- MFIO_85
> pll4_lock => rpu_l_pll -- MFIO_86
> pll5_lock => sys_pll -- MFIO_87
> pll6_lock => wifi_pll -- MFIO_88
> pll7_lock => bt_pll -- MFIO_89
>
> Fixes: cefc03e5995e("pinctrl: Add Pistachio SoC pin control driver")
> Signed-off-by: Govindraj Raja <Govindraj.Raja@imgtec.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Andrew Bresticker <abrestic@chromium.org>
> Cc: linux-mips@linux-mips.org
> Cc: James Hartley <James.Hartley@imgtec.com>
> Cc: <stable@vger.kernel.org> # v4.2+
> ---
> Do I need to split this patch into dt & pinctrl?
> Or can it be picked up through pinctrl subsystem with dt maintainers Ack?
Yes.
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2016-03-05 4:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 15:28 [PATCH] pinctrl: pistachio: fix mfio84-89 function description and pinmux Govindraj Raja
2016-03-04 18:48 ` Andrew Bresticker
2016-03-05 4:31 ` Rob Herring [this message]
2016-03-15 8:58 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305043137.GJ13525@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Govindraj.Raja@imgtec.com \
--cc=James.Hartley@imgtec.com \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).