From: Rob Herring <robh@kernel.org>
To: Grant Grundler <grundler@chromium.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
Grant Likely <grant.likely@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, Hung-yu Wu <hywu@google.com>
Subject: Re: Input: add Atmel Atmegaxx captouch driver
Date: Wed, 4 May 2016 08:51:23 -0500 [thread overview]
Message-ID: <20160504135123.GA4567@rob-hp-laptop> (raw)
In-Reply-To: <1462295611-49684-1-git-send-email-grundler@chromium.org>
On Tue, May 03, 2016 at 10:13:31AM -0700, Grant Grundler wrote:
> Add I2C driver for AtmegaXX capacitive touch device.
>
> Signed-off-by: Hung-yu Wu <hywu@google.com>
> Signed-off-by: Grant Grundler <grundler@chromium.org>
> ---
> .../bindings/input/atmel,atmegaxx_captouch.txt | 34 +++
It is generally preferred that bindings are a separate patch.
> drivers/input/misc/Kconfig | 11 +
> drivers/input/misc/Makefile | 1 +
> drivers/input/misc/atmegaxx_captouch.c | 278 +++++++++++++++++++++
> 4 files changed, 324 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/atmel,atmegaxx_captouch.txt
> create mode 100644 drivers/input/misc/atmegaxx_captouch.c
>
> For those that like to know how sausage is made, ChromeOS code review history here:
> https://chromium-review.googlesource.com/339950
>
> Driver was tested with prototype HW and it reliably reports events correctly.
> Manual testing was just using "evtest /dev/input/event0" and watch for events.
>
> diff --git a/Documentation/devicetree/bindings/input/atmel,atmegaxx_captouch.txt b/Documentation/devicetree/bindings/input/atmel,atmegaxx_captouch.txt
> new file mode 100644
> index 0000000..07a4b0b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/atmel,atmegaxx_captouch.txt
> @@ -0,0 +1,34 @@
> +Device tree bindings for Atmel AtmegaXX capacitive touch sensor
> +
> +The node for this device must be a child of a I2C controller node, as the
> +device communicates via I2C.
> +
> +Required properties:
> +
> + compatible: Must be "atmel,atmegaxx_captouch".
No wildcards in the compatible strings. Use the specific devices.
Also, use hyphen rather than underscore. However, if the device is only
a touch controller, then '_captouch' is not needed. The part number is
sufficient to identify the device.
> + reg: The I2C slave address of the device.
> + interrupts: Property describing the interrupt line the device
> + is connected to. The device only has one interrupt
> + source.
> + linux,keycodes: Specifies an array of numeric keycode values to
> + be used for reporting button presses. The array can
> + contain up to 8 entries.
> +
> +Optional properties:
> +
> + autorepeat: Enables the Linux input system's autorepeat
> + feature on the input device.
> +
> +Example:
> +
> + atmegaxx_captouch@51 {
atmegaxx@51 (with actual part number)
> + compatible = "atmel,atmegaxx_captouch";
> + reg = <0x51>;
> + interrupt-parent = <&tlmm>;
> + interrupts = <67 IRQ_TYPE_EDGE_FALLING>;
> + linux,keycodes = <BTN_0>, <BTN_1>,
> + <BTN_2>, <BTN_3>,
> + <BTN_4>, <BTN_5>,
> + <BTN_6>, <BTN_7>;
> + autorepeat;
> + };
next prev parent reply other threads:[~2016-05-04 13:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 17:13 Input: add Atmel Atmegaxx captouch driver Grant Grundler
2016-05-04 13:51 ` Rob Herring [this message]
2016-05-04 16:43 ` Grant Grundler
2016-05-05 16:04 ` Grant Grundler
2016-05-06 9:19 ` Nicolas Ferre
2016-05-06 15:14 ` Daniel Hung-yu Wu
[not found] ` <CAHHoo-j7145vPFNmJH=CvPu-BRCgRe0WNKH8QDkSc+c3koxHAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-09 16:29 ` Dmitry Torokhov
2016-05-09 16:44 ` Grant Grundler
2016-05-09 16:51 ` Rob Herring
2016-05-09 16:48 ` Rob Herring
[not found] ` <572C61B1.2040508-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2016-05-06 18:29 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504135123.GA4567@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=grundler@chromium.org \
--cc=hywu@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).