From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v2 1/3] of: add common OF-based component functionality Date: Fri, 3 Jun 2016 16:36:30 +0100 Message-ID: <20160603153630.GE1041@n2100.armlinux.org.uk> References: <20160603141548.GC1041@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org To: Rob Herring Cc: "devicetree@vger.kernel.org" , dri-devel , "linux-arm-kernel@lists.infradead.org" , linux-arm-msm , linux-mediatek@lists.infradead.org, "open list:ARM/Rockchip SoC..." , Frank Rowand , Grant Likely List-Id: devicetree@vger.kernel.org On Fri, Jun 03, 2016 at 10:29:40AM -0500, Rob Herring wrote: > On Fri, Jun 3, 2016 at 9:21 AM, Russell King wrote: > > Add common OF-based component functionality for matching devices by > > device node, and releasing the device node at the appropraite time. > > > > Signed-off-by: Russell King > > --- > > drivers/of/Makefile | 2 +- > > drivers/of/of_component.c | 41 +++++++++++++++++++++++++++++++++++++++++ > > include/linux/of_component.h | 14 ++++++++++++++ > > I'd prefer this to go into drivers/base/component.c. That's the > general direction we've been moving. I'd prefer not to, I don't want to turn the component helpers into something OF specific. They aren't OF specific. > I'd expect this would cause some build failures unless the cases you > converted all depend on CONFIG_OF. Okay, I'll stick with v1 then, and the duplication that v1 involves. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.