From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
David Brown <david.brown@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org,
Parth Pancholi <parth.pancholi@einfochips.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: sd_600eval: Fix eMMC lockup issue
Date: Sat, 11 Jun 2016 21:47:36 -0700 [thread overview]
Message-ID: <20160612044736.GS1256@tuxbot> (raw)
In-Reply-To: <1465582795-30266-2-git-send-email-srinivas.kandagatla@linaro.org>
On Fri 10 Jun 11:19 PDT 2016, Srinivas Kandagatla wrote:
> From: Parth Pancholi <parth.pancholi@einfochips.com>
>
> This board locks up if we stress test the eMMC, as the regulator s4 is
> unable to supply enough current for all the peripherials attached to it.
> As this supply is wired up to most of the peripherials including DDR,
> it resulted in such lockup.
>
> This patch fixes this issue by setting s4 regulator correctly with
> Auto power mode.
>
> Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> [Srinivas Kandagatla: rewrote the change log]
> Tested-by: Girish Sharma <girish.sharma@einfochips.com>
> Signed-off-by: Parth Pancholi <parth.pancholi@einfochips.com>
If I read the msm-3.4 tree correctly most (perhaps all) 8064 devices
should have this setup.
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
> index 7df0108..39ae2bc 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
> @@ -1,6 +1,7 @@
> #include "qcom-apq8064-v2.0.dtsi"
> #include "qcom-apq8064-arrow-sd-600eval-pins.dtsi"
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/mfd/qcom-rpm.h>
>
> / {
> model = "Arrow Electronics, APQ8064 SD_600eval";
> @@ -82,7 +83,8 @@
> s4 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - qcom,switch-mode-frequency = <3200000>;
> + qcom,switch-mode-frequency = <1600000>;
> + qcom,force-mode = <QCOM_RPM_FORCE_MODE_AUTO>;
> bias-pull-down;
> regulator-always-on;
> };
> --
> 2.8.3
>
next prev parent reply other threads:[~2016-06-12 4:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 18:19 [PATCH v2 1/2] ARM: dts: apq8064: rename db600c to SD_600eval Srinivas Kandagatla
[not found] ` <1465582795-30266-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-06-10 18:19 ` [PATCH v2 2/2] ARM: dts: sd_600eval: Fix eMMC lockup issue Srinivas Kandagatla
2016-06-12 4:47 ` Bjorn Andersson [this message]
2016-06-13 16:21 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160612044736.GS1256@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=parth.pancholi@einfochips.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).