From: Thierry Reding <thierry.reding@gmail.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Emil Velikov <emil.l.velikov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel
Date: Tue, 14 Jun 2016 10:57:49 +0200 [thread overview]
Message-ID: <20160614085749.GB24442@ulmo.ba.sec> (raw)
In-Reply-To: <CAD=FV=VL0KgZnpjvAvYgK8rzgntKL2N0D6QbG6V0LO8vkaQkig@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2271 bytes --]
On Mon, Jun 13, 2016 at 10:00:45AM -0700, Doug Anderson wrote:
> Yakir,
>
> On Sat, Jun 11, 2016 at 7:56 PM, Yakir Yang <ykk@rock-chips.com> wrote:
> > The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
> > connected using eDP interfaces.
> >
> > Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> > ---
> > Changes in v3:
> > - Correct the size of panel_desc to active area 262mmx164mm (Emil, Stéphane)
> >
> > Changes in v2: None
> >
> > drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 2d40a21..17cc973 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
> > .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > };
> >
> > +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
> > + .clock = 271560,
> > + .hdisplay = 2560,
> > + .hsync_start = 2560 + 48,
> > + .hsync_end = 2560 + 48 + 32,
> > + .htotal = 2560 + 48 + 32 + 80,
> > + .vdisplay = 1600,
> > + .vsync_start = 1600 + 2,
> > + .vsync_end = 1600 + 2 + 5,
> > + .vtotal = 1600 + 2 + 5 + 57,
> > + .vrefresh = 60,
> > +};
> > +
> > +static const struct panel_desc samsung_lsn122dl01_c01 = {
> > + .modes = &samsung_lsn122dl01_c01_mode,
> > + .num_modes = 1,
> > + .size = {
> > + .width = 262,
> > + .height = 164,
>
> Earlier you said that the active area of this panel was:
>
> > Display area 262.656(H) X 164.16(V) (12.2”diagonal)
>
> In other panels I looked at the EDID tended to round numbers, not
> truncate them. For instance the Starry panel that I sent the patch
> for says in the manual "262.7712 (H) x 164.232 (V)" but then the EDID
> says "263 x 164".
>
> That would mean your width should be 263 mm, not 262 mm.
Yes, rounding is what I've also applied to all panels that I added.
While it isn't documented I hope that other panels did round, rather
than truncate, as well.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-14 8:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 2:53 [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang
2016-06-12 2:56 ` [PATCH v3 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel Yakir Yang
2016-06-12 2:56 ` [PATCH v3 3/6] dt-bindings: add Samsung LSN122DL01-C01 panel binding Yakir Yang
2016-06-12 2:56 ` [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel Yakir Yang
2016-06-13 17:00 ` Doug Anderson
2016-06-14 8:57 ` Thierry Reding [this message]
2016-07-08 1:51 ` Yakir Yang
2016-06-12 2:56 ` [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Yakir Yang
2016-06-14 22:06 ` Rob Herring
2016-06-12 2:56 ` [PATCH v3 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel Yakir Yang
2016-07-07 21:55 ` [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Thierry Reding
2016-07-07 21:57 ` Thierry Reding
[not found] ` <20160707215659.GD744-+E7KM1FDEuO2P7RxrfNFTMXXUOn6P5/W@public.gmane.org>
2016-07-19 1:51 ` Yakir Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614085749.GB24442@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).