Hi Stephen, On Mon, Jun 20, 2016 at 06:15:37PM -0700, Stephen Boyd wrote: > On 06/07, Maxime Ripard wrote: > > + > > +#include > > + > > +#include "ccu_common.h" > > + > > +struct ccu_fixed_factor { > > + u16 div; > > + u16 mult; > > + > > + struct ccu_common common; > > Does this use the common structure although we have no usage for > the members of struct ccu_common except struct clk_hw? I suppose > this is done so registering a bunch of clks is easy? Yes, when we discussed this with Mike back at the ELC, he said that he really liked the approach you had the qualcomm clocks where you have a single array with all the clocks, so I tried to follow that as much as possible. Even though it doesn't really make much sense here, indeed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com