From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 1/8] mfd: tps65218: Remove redundant read wrapper
Date: Mon, 27 Jun 2016 13:23:31 +0100 [thread overview]
Message-ID: <20160627122331.GB24377@dell> (raw)
In-Reply-To: <1467025305-13464-2-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
On Mon, 27 Jun 2016, Keerthy wrote:
> Currently read directly calls the repmap read function. Hence
> remove the redundant wrapper and use regmap read wherever
> needed.
>
> Signed-off-by: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
> ---
> drivers/mfd/tps65218.c | 16 +---------------
> drivers/regulator/tps65218-regulator.c | 3 ++-
> include/linux/mfd/tps65218.h | 2 --
> 3 files changed, 3 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
> index 80b9dc3..f20a531 100644
> --- a/drivers/mfd/tps65218.c
> +++ b/drivers/mfd/tps65218.c
> @@ -34,20 +34,6 @@
> #define TPS65218_PASSWORD_REGS_UNLOCK 0x7D
>
> /**
> - * tps65218_reg_read: Read a single tps65218 register.
> - *
> - * @tps: Device to read from.
> - * @reg: Register to read.
> - * @val: Contians the value
> - */
> -int tps65218_reg_read(struct tps65218 *tps, unsigned int reg,
> - unsigned int *val)
> -{
> - return regmap_read(tps->regmap, reg, val);
> -}
> -EXPORT_SYMBOL_GPL(tps65218_reg_read);
> -
What about the calls in the GPIO and Misc drivers?
> -/**
> * tps65218_reg_write: Write a single tps65218 register.
> *
> * @tps65218: Device to write to.
> @@ -93,7 +79,7 @@ static int tps65218_update_bits(struct tps65218 *tps, unsigned int reg,
> int ret;
> unsigned int data;
>
> - ret = tps65218_reg_read(tps, reg, &data);
> + ret = regmap_read(tps->regmap, reg, &data);
> if (ret) {
> dev_err(tps->dev, "Read from reg 0x%x failed\n", reg);
> return ret;
> diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
> index a5e5634..679ab2f 100644
> --- a/drivers/regulator/tps65218-regulator.c
> +++ b/drivers/regulator/tps65218-regulator.c
> @@ -22,6 +22,7 @@
> #include <linux/err.h>
> #include <linux/platform_device.h>
> #include <linux/of_device.h>
> +#include <linux/regmap.h>
> #include <linux/regulator/of_regulator.h>
> #include <linux/regulator/driver.h>
> #include <linux/regulator/machine.h>
> @@ -224,7 +225,7 @@ static int tps65218_pmic_get_current_limit(struct regulator_dev *dev)
> unsigned int index;
> struct tps65218 *tps = rdev_get_drvdata(dev);
>
> - retval = tps65218_reg_read(tps, dev->desc->csel_reg, &index);
> + retval = regmap_read(tps->regmap, dev->desc->csel_reg, &index);
> if (retval < 0)
> return retval;
>
> diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd/tps65218.h
> index d58f3b5..7c9241f 100644
> --- a/include/linux/mfd/tps65218.h
> +++ b/include/linux/mfd/tps65218.h
> @@ -276,8 +276,6 @@ struct tps65218 {
> struct regmap *regmap;
> };
>
> -int tps65218_reg_read(struct tps65218 *tps, unsigned int reg,
> - unsigned int *val);
> int tps65218_reg_write(struct tps65218 *tps, unsigned int reg,
> unsigned int val, unsigned int level);
> int tps65218_set_bits(struct tps65218 *tps, unsigned int reg,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-27 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 11:01 [PATCH v2 0/8] mfd/regulator: tps65218: Clean ups Keerthy
2016-06-27 11:01 ` [PATCH v2 1/8] mfd: tps65218: Remove redundant read wrapper Keerthy
[not found] ` <1467025305-13464-2-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-06-27 11:51 ` kbuild test robot
2016-06-27 12:20 ` kbuild test robot
2016-06-27 12:23 ` Lee Jones [this message]
2016-06-27 14:30 ` Keerthy
2016-06-27 11:01 ` [PATCH v2 2/8] Documentation: regulator: tps65218: Update examples Keerthy
2016-06-27 11:01 ` [PATCH v2 3/8] mfd: tps65218: Use mfd_add_devices instead of of_platform_populate Keerthy
[not found] ` <1467025305-13464-4-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-06-27 12:23 ` Lee Jones
2016-06-27 11:01 ` [PATCH v2 4/8] regulator: tps65218: Remove all the compatibles Keerthy
2016-06-27 11:01 ` [PATCH v2 5/8] ARM: dts: AM437X-GP-EVM: Remove redundant regulator compatibles Keerthy
2016-06-27 11:01 ` [PATCH v2 6/8] ARM: dts: AM437X-SK-EVM: " Keerthy
2016-06-27 11:01 ` [PATCH v2 7/8] ARM: dts: AM437X-CM-T43: " Keerthy
2016-06-27 11:01 ` [PATCH v2 8/8] ARM: dts: AM43X-EPOS-EVM: " Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627122331.GB24377@dell \
--to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=j-keerthy-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).