From: Mark Rutland <mark.rutland@arm.com>
To: Carlo Caione <carlo@caione.org>
Cc: devicetree@vger.kernel.org, narmstrong@baylibre.com,
khilman@baylibre.com, bjdooks@googlemail.com, robh+dt@kernel.org,
srinivas.kandagatla@linaro.org, matthias.bgg@gmail.com,
linux-amlogic@lists.infradead.org,
maxime.ripard@free-electrons.com, linux@endlessm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] firmware: Amlogic: Add secure monitor driver
Date: Tue, 28 Jun 2016 12:29:02 +0100 [thread overview]
Message-ID: <20160628112901.GJ31744@leverpostej> (raw)
In-Reply-To: <20160628081057.GA3171@localhost>
Hi,
On Tue, Jun 28, 2016 at 10:10:57AM +0200, Carlo Caione wrote:
> On 27/06/16 18:28, Mark Rutland wrote:
> > On Sun, Jun 19, 2016 at 02:38:59PM +0200, Carlo Caione wrote:
> > > + np = of_find_matching_node_and_match(NULL, meson_sm_ids, &matched_np);
> > > + if (!np) {
> > > + pr_err("no matching node\n");
> > > + return -EINVAL;
> > > + }
> > > +
> >
> > This is going to be pointlessly noisy on every non-amlogic board out
> > there.
>
> ouch, right
>
> > Please make this a platform driver, such that this is only called when a
> > node is present, avoiding some mess there.
>
> Since Rob required this to be under /firmware (and using no "simple-bus"
> compatible to trigger the automatic creation) making it a platform
> driver just adds a lot of boilerplate code. If this doesn't mean a NACK
> on your side, I still would leave the code as is with the
> device_initcall() calling the init.
Ok. So long as this isn't noisy where the node is not present, that's
fine by me.
Thanks,
Mark.
next prev parent reply other threads:[~2016-06-28 11:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 12:38 [PATCH 0/6] Add Amlogic secure monitor and NVMEM drivers Carlo Caione
[not found] ` <1466339944-602-1-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2016-06-19 12:38 ` [PATCH 1/6] firmware: Amlogic: Add secure monitor driver Carlo Caione
[not found] ` <1466339944-602-2-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2016-06-24 21:05 ` Carlo Caione
2016-06-27 17:28 ` Mark Rutland
2016-06-28 8:10 ` Carlo Caione
2016-06-28 11:29 ` Mark Rutland [this message]
2016-06-19 12:39 ` [PATCH 2/6] documentation: Add secure monitor bindings documentation Carlo Caione
2016-06-20 18:06 ` Rob Herring
2016-06-20 18:08 ` Carlo Caione
2016-06-19 12:39 ` [PATCH 3/6] ARM64: dts: amlogic: gxbb: Enable secure monitor Carlo Caione
2016-06-19 12:39 ` [PATCH 4/6] nvmem: amlogic: Add Amlogic Meson EFUSE driver Carlo Caione
2016-06-20 11:13 ` Srinivas Kandagatla
2016-06-19 12:39 ` [PATCH 5/6] documentation: Add nvmem bindings documentation Carlo Caione
2016-06-20 18:07 ` Rob Herring
2016-06-19 12:39 ` [PATCH 6/6] ARM64: dts: amlogic: gxbb: Enable NVMEM Carlo Caione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628112901.GJ31744@leverpostej \
--to=mark.rutland@arm.com \
--cc=bjdooks@googlemail.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@endlessm.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).