devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Anthony Felice <tony.felice@timesys.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	maitysanchayan@gmail.com, damien.riegel@savoirfairelinux.com,
	linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
	linux@armlinux.org.uk, sre@kernel.org, mwelling@ieee.org,
	geert@linux-m68k.org, dri-devel@lists.freedesktop.org,
	kernel@pengutronix.de, linux-input@vger.kernel.org,
	fabio.estevam@nxp.com, shawnguo@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] input: touchscreen: crtouch_ts: Add driver
Date: Tue, 28 Jun 2016 15:55:44 -0500	[thread overview]
Message-ID: <20160628205544.GH3737@rob-hp-laptop> (raw)
In-Reply-To: <1466797486-31558-3-git-send-email-tony.felice@timesys.com>

On Fri, Jun 24, 2016 at 03:44:44PM -0400, Anthony Felice wrote:
> Add driver for the Vybrid Tower CRTouch-based touchscreen. This is
> required for the touchscreen on the TWR-LCD-RGB to work on the Vybrid
> Tower platform.
> 
> There is a known issue with this driver: rarely, SW1 on the TWR-LCD-RGB
> module needs to be pressed in order for the touchscreen to begin
> functioning.
> 
> Signed-off-by: Anthony Felice <tony.felice@timesys.com>
> ---
>  .../bindings/input/touchscreen/crtouch_ts.txt      |  14 ++
>  drivers/input/touchscreen/Kconfig                  |  10 +
>  drivers/input/touchscreen/Makefile                 |   1 +
>  drivers/input/touchscreen/crtouch_ts.c             | 279 +++++++++++++++++++++
>  4 files changed, 304 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/crtouch_ts.txt
>  create mode 100644 drivers/input/touchscreen/crtouch_ts.c
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/crtouch_ts.txt b/Documentation/devicetree/bindings/input/touchscreen/crtouch_ts.txt
> new file mode 100644
> index 0000000..cfb966c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/crtouch_ts.txt
> @@ -0,0 +1,14 @@
> +* Freescale CRTOUCH based touchscreen
> +
> +Required Properties:
> +- compatible must be fsl,crtouch_ts
> +- reg: I2C address of the touchscreen
> +- irq-gpio: GPIO to use as event IRQ
> +
> +Example:
> +
> +	touch: crtouch@49 {

touchscreen@49

> +		compatible = "fsl,crtouch_ts";

Use '-', not '_'.

> +		reg = <0x49>;
> +		irq-gpio = <&gpio0 21 GPIO_ACTIVE_HIGH>;

As Dmitry said.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-06-28 20:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 19:44 [PATCH 0/4] Enable display and touchscreen for Vybrid Tower Anthony Felice
2016-06-24 19:44 ` [PATCH 1/4] ARM: dts: vf610-twr: Enable display controller Anthony Felice
2016-06-25 20:53   ` Stefan Agner
2016-06-27 17:11     ` Tony Felice
2016-06-24 19:44 ` [PATCH 2/4] input: touchscreen: crtouch_ts: Add driver Anthony Felice
     [not found]   ` <1466797486-31558-3-git-send-email-tony.felice-jEh4hwF5bVhBDgjK7y7TUQ@public.gmane.org>
2016-06-24 22:04     ` Dmitry Torokhov
2016-06-27 18:50       ` Tony Felice
2016-06-25 20:40   ` Stefan Agner
2016-06-28 20:55   ` Rob Herring [this message]
2016-06-24 19:44 ` [PATCH 3/4] ARM: dts: vf610-twr: Add crtouch node and pinmux Anthony Felice
2016-06-24 19:44 ` [PATCH 4/4] ARM: imx_v6_v7_defconfig: enable useful configurations for Vybrid Anthony Felice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160628205544.GH3737@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=damien.riegel@savoirfairelinux.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@nxp.com \
    --cc=geert@linux-m68k.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maitysanchayan@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=mwelling@ieee.org \
    --cc=shawnguo@kernel.org \
    --cc=sre@kernel.org \
    --cc=tony.felice@timesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).