Linux-Devicetree Archive on
 help / color / Atom feed
From: Arnd Bergmann <>
To: Andrew Morton
	Rob Herring <>,
	Frank Rowand
Cc: Arnd Bergmann <>,
	Bjorn Helgaas <>,
	Magnus Damm <>,
	Geert Uytterhoeven
	Ben Dooks <>,,,
	Sakari Ailus
	Mika Westerberg
	Geert Uytterhoeven
Subject: [PATCH 1/2] [RESEND] of: provide of_n_{addr,size}_cells wrappers for !CONFIG_OF
Date: Mon, 11 Sep 2017 22:07:49 +0200
Message-ID: <> (raw)

The pci-rcar driver is enabled for compile tests, and this has
shown that the driver cannot build without CONFIG_OF,
following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
interrupt mapping when possible":

drivers/pci/host/pcie-rcar.c: In function 'pci_dma_range_parser_init':
drivers/pci/host/pcie-rcar.c:1039:2: error: implicit declaration of function 'of_n_addr_cells' [-Werror=implicit-function-declaration]
  parser->pna = of_n_addr_cells(node);
As pointed out by Ben Dooks and Geert Uytterhoeven, this is actually
supposed to build fine, which we can achieve if we make the
declaration of of_irq_parse_and_map_pci conditional on CONFIG_OF
and provide an empty inline function otherwise, as we do for
a lot of other of interfaces.

This lets us build the rcar_pci driver again without CONFIG_OF
for build testing. All platforms using this driver select OF,
so this doesn't change anything for the users.

Cc: Bjorn Helgaas <>
Cc: Magnus Damm <>
Cc: Geert Uytterhoeven <>
Cc: Ben Dooks <>
Acked-by: Geert Uytterhoeven <>
Reviewed-by: Frank Rowand <frank.rowand-7U/>
Fixes: c25da4778803 ("PCI: rcar: Add Renesas R-Car PCIe driver")
Signed-off-by: Arnd Bergmann <>
I originally sent the patch in 2014 when things initially broke
and then forgot about while it was applied in my randconfig patch
stack. I sent it again in 2016 and then in July 2017 without reply.

It's still broken and I think this is the correct fix.
 include/linux/of.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index cfc34117fc92..fb700d1e1fab 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -734,6 +734,9 @@ static inline struct device_node *of_get_cpu_node(int cpu,
 	return NULL;
+static inline int of_n_addr_cells(struct device_node *np) { return 0; }
+static inline int of_n_size_cells(struct device_node *np) { return 0; }
 static inline int of_property_read_u64(const struct device_node *np,
 				       const char *propname, u64 *out_value)

To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to
More majordomo info at

             reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 20:07 Arnd Bergmann [this message]
     [not found] ` <>
2017-09-11 20:07   ` [PATCH 2/2] of: provide inline helper for of_find_device_by_node Arnd Bergmann
2017-09-18 21:28   ` [PATCH 1/2] [RESEND] of: provide of_n_{addr,size}_cells wrappers for !CONFIG_OF Rob Herring
     [not found]     ` <>
2017-09-19  7:02       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \
    --cc=akpm-de/ \ \ \ \ \ \ \ \ \ \ \
    --cc=mika.westerberg-VuQAYsv1563Yd54FQh9/ \ \
    --cc=sakari.ailus-VuQAYsv1563Yd54FQh9/ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Devicetree Archive on

Archives are clonable:
	git clone --mirror linux-devicetree/git/0.git
	git clone --mirror linux-devicetree/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ \
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone