* [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
@ 2017-10-26 16:12 Philippe Cornu
2017-10-27 14:38 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Philippe Cornu @ 2017-10-26 16:12 UTC (permalink / raw)
To: Rob Herring, Arnd Bergmann, Russell King, Mark Rutland,
Archit Taneja, Andrzej Hajda, Laurent Pinchart, David Airlie,
Philippe Cornu, Philipp Zabel, Benjamin Gaignard, Bhumika Goyal,
devicetree, linux-arm-kernel, dri-devel, linux-kernel
Cc: Alexandre Torgue, Fabien Dessenne, Yannick Fertre,
Maxime Coquelin, Mickael Reulier, Vincent Abriou,
Gabriel Fernandez, Ludovic Barre
Add the DPI/RGB input pixel clock in mandatory properties
because it really offers a better preciseness for timing
computations.
Note: Fix also the DSI panel example where "ref" & "pclk"
clocks were swapped.
Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
---
Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
index 0292522..99823fb 100644
--- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
+++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
@@ -28,6 +28,7 @@ Mandatory properties specific to STM32 DSI:
- #size-cells: Should be <0>.
- compatible: "st,stm32-dsi".
- clock-names:
+ - DPI/RGB input pixel clock string name, must be "px_clk".
- phy pll reference clock string name, must be "ref".
- resets: see [5].
- reset-names: see [5].
@@ -97,8 +98,9 @@ Example 2: DSI panel
#size-cells = <0>;
compatible = "st,stm32-dsi";
reg = <0x40016c00 0x800>;
- clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
- clock-names = "ref", "pclk";
+ clocks = <&rcc 1 CLK_F469_DSI>, <&rcc 1 CLK_LCD>,
+ <&clk_hse>;
+ clock-names = "pclk", "px_clk", "ref";
resets = <&rcc STM32F4_APB2_RESET(DSI)>;
reset-names = "apb";
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
2017-10-26 16:12 [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property Philippe Cornu
@ 2017-10-27 14:38 ` Rob Herring
2017-10-27 14:52 ` Philippe CORNU
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2017-10-27 14:38 UTC (permalink / raw)
To: Philippe Cornu
Cc: Mark Rutland, dri-devel, Laurent Pinchart, Mickael Reulier,
Russell King, Fabien Dessenne, linux-arm-kernel, devicetree,
Alexandre Torgue, Arnd Bergmann, Vincent Abriou, Ludovic Barre,
linux-kernel, Yannick Fertre, Maxime Coquelin, Gabriel Fernandez,
Bhumika Goyal
On Thu, Oct 26, 2017 at 06:12:36PM +0200, Philippe Cornu wrote:
> Add the DPI/RGB input pixel clock in mandatory properties
> because it really offers a better preciseness for timing
> computations.
> Note: Fix also the DSI panel example where "ref" & "pclk"
> clocks were swapped.
>
> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> ---
> Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> index 0292522..99823fb 100644
> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> @@ -28,6 +28,7 @@ Mandatory properties specific to STM32 DSI:
> - #size-cells: Should be <0>.
> - compatible: "st,stm32-dsi".
> - clock-names:
> + - DPI/RGB input pixel clock string name, must be "px_clk".
> - phy pll reference clock string name, must be "ref".
Where's pclk?
The new clock should be last to be backwards compatible.
> - resets: see [5].
> - reset-names: see [5].
> @@ -97,8 +98,9 @@ Example 2: DSI panel
> #size-cells = <0>;
> compatible = "st,stm32-dsi";
> reg = <0x40016c00 0x800>;
> - clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
> - clock-names = "ref", "pclk";
> + clocks = <&rcc 1 CLK_F469_DSI>, <&rcc 1 CLK_LCD>,
> + <&clk_hse>;
> + clock-names = "pclk", "px_clk", "ref";
> resets = <&rcc STM32F4_APB2_RESET(DSI)>;
> reset-names = "apb";
>
> --
> 1.9.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
2017-10-27 14:38 ` Rob Herring
@ 2017-10-27 14:52 ` Philippe CORNU
0 siblings, 0 replies; 6+ messages in thread
From: Philippe CORNU @ 2017-10-27 14:52 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, dri-devel, Laurent Pinchart, Mickael REULIER,
Russell King, Fabien DESSENNE, linux-arm-kernel, devicetree,
Alexandre TORGUE, Arnd Bergmann, Vincent ABRIOU, Ludovic BARRE,
linux-kernel, Yannick FERTRE, Maxime Coquelin, Gabriel FERNANDEZ,
Bhumika Goyal
Hi Rob,
On 10/27/2017 04:38 PM, Rob Herring wrote:
> On Thu, Oct 26, 2017 at 06:12:36PM +0200, Philippe Cornu wrote:
>> Add the DPI/RGB input pixel clock in mandatory properties
>> because it really offers a better preciseness for timing
>> computations.
>> Note: Fix also the DSI panel example where "ref" & "pclk"
>> clocks were swapped.
>>
>> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
>> ---
>> Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> index 0292522..99823fb 100644
>> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> @@ -28,6 +28,7 @@ Mandatory properties specific to STM32 DSI:
>> - #size-cells: Should be <0>.
>> - compatible: "st,stm32-dsi".
>> - clock-names:
>> + - DPI/RGB input pixel clock string name, must be "px_clk".
>> - phy pll reference clock string name, must be "ref".
>
> Where's pclk?
pclk is described in the generic part
(Documentation/devicetree/bindings/display/bridge/dw_mipi_dsi.txt) as
mandatory.
In st,stm32-ltdc.txt (specific part), I have documented that "For all
mandatory properties & nodes, please refer to the related documentation
in [5]".
Do you think it is clear enough?
>
> The new clock should be last to be backwards compatible.
>
ok.
Many thanks for your review and your support,
Philippe :-)
>> - resets: see [5].
>> - reset-names: see [5].
>> @@ -97,8 +98,9 @@ Example 2: DSI panel
>> #size-cells = <0>;
>> compatible = "st,stm32-dsi";
>> reg = <0x40016c00 0x800>;
>> - clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
>> - clock-names = "ref", "pclk";
>> + clocks = <&rcc 1 CLK_F469_DSI>, <&rcc 1 CLK_LCD>,
>> + <&clk_hse>;
>> + clock-names = "pclk", "px_clk", "ref";
>> resets = <&rcc STM32F4_APB2_RESET(DSI)>;
>> reset-names = "apb";
>>
>> --
>> 1.9.1
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
2018-01-22 15:38 Philippe Cornu
@ 2018-01-25 16:08 ` Philippe CORNU
0 siblings, 0 replies; 6+ messages in thread
From: Philippe CORNU @ 2018-01-25 16:08 UTC (permalink / raw)
To: Yannick FERTRE, Benjamin Gaignard, Vincent ABRIOU, David Airlie,
Rob Herring, Mark Rutland, Maxime Coquelin, Alexandre TORGUE,
dri-devel, devicetree, linux-arm-kernel, linux-kernel
Cc: Mickael REULIER, Gabriel FERNANDEZ, Ludovic BARRE
Hi,
in short: this patch is "CANCELLED" : )
There is no need to add the pixel clock as a mandatory property because
now the clock value is ajusted in adjusted_mode.
Please have a look to patches:
- drm/stm: ltdc: use crtc_mode_fixup to update adjusted_mode clock
- drm/bridge/synopsys: dsi: use adjusted_mode in mode_set
Hope it is better, comments are welcome
Many thanks,
Philippe :-)
On 01/22/2018 04:38 PM, Philippe Cornu wrote:
> Add the DPI/RGB input pixel clock in mandatory properties
> because it really offers a better preciseness for timing
> computations.
>
> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> ---
> Please apply "dt-bindings: display: stm32: correct clock-names
> in dsi panel example" before this patch.
>
> Changes in v3: remove the note regarding swapped clock names
> (now in a separate patch).
> Changes in v2: put new clock in last position (Rob Herring)
>
> Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> index 3eb1b48b47dd..942b7237ae87 100644
> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> @@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI:
> - compatible: "st,stm32-dsi".
> - clock-names:
> - phy pll reference clock string name, must be "ref".
> + - DPI/RGB input pixel clock string name, must be "px_clk".
> - resets: see [5].
> - reset-names: see [5].
>
> @@ -97,8 +98,9 @@ Example 2: DSI panel
> #size-cells = <0>;
> compatible = "st,stm32-dsi";
> reg = <0x40016c00 0x800>;
> - clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
> - clock-names = "pclk", "ref";
> + clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>,
> + <&rcc 1 CLK_LCD>;
> + clock-names = "pclk", "ref", "px_clk";
> resets = <&rcc STM32F4_APB2_RESET(DSI)>;
> reset-names = "apb";
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
@ 2018-01-22 15:38 Philippe Cornu
2018-01-25 16:08 ` Philippe CORNU
0 siblings, 1 reply; 6+ messages in thread
From: Philippe Cornu @ 2018-01-22 15:38 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou, David Airlie, Rob Herring, Mark Rutland,
Maxime Coquelin, Alexandre Torgue, dri-devel, devicetree,
linux-arm-kernel, linux-kernel
Cc: Mickael Reulier, Gabriel Fernandez, Ludovic Barre
Add the DPI/RGB input pixel clock in mandatory properties
because it really offers a better preciseness for timing
computations.
Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
---
Please apply "dt-bindings: display: stm32: correct clock-names
in dsi panel example" before this patch.
Changes in v3: remove the note regarding swapped clock names
(now in a separate patch).
Changes in v2: put new clock in last position (Rob Herring)
Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
index 3eb1b48b47dd..942b7237ae87 100644
--- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
+++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
@@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI:
- compatible: "st,stm32-dsi".
- clock-names:
- phy pll reference clock string name, must be "ref".
+ - DPI/RGB input pixel clock string name, must be "px_clk".
- resets: see [5].
- reset-names: see [5].
@@ -97,8 +98,9 @@ Example 2: DSI panel
#size-cells = <0>;
compatible = "st,stm32-dsi";
reg = <0x40016c00 0x800>;
- clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
- clock-names = "pclk", "ref";
+ clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>,
+ <&rcc 1 CLK_LCD>;
+ clock-names = "pclk", "ref", "px_clk";
resets = <&rcc STM32F4_APB2_RESET(DSI)>;
reset-names = "apb";
--
2.15.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
@ 2018-01-21 21:13 Philippe Cornu
0 siblings, 0 replies; 6+ messages in thread
From: Philippe Cornu @ 2018-01-21 21:13 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou, David Airlie, Rob Herring, Mark Rutland,
Maxime Coquelin, Alexandre Torgue,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Mickael Reulier, Gabriel Fernandez, Ludovic Barre
Add the DPI/RGB input pixel clock in mandatory properties
because it really offers a better preciseness for timing
computations.
Signed-off-by: Philippe Cornu <philippe.cornu-qxv4g6HH51o@public.gmane.org>
---
Please apply "dt-bindings: display: stm32: correct clock-names
in dsi panel example" before this patch.
Changes in v3: remove the note regarding swapped clock names
(now in a separate patch).
Changes in v2: put new clock in last position (Rob Herring)
Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
index 3eb1b48b47dd..942b7237ae87 100644
--- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
+++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
@@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI:
- compatible: "st,stm32-dsi".
- clock-names:
- phy pll reference clock string name, must be "ref".
+ - DPI/RGB input pixel clock string name, must be "px_clk".
- resets: see [5].
- reset-names: see [5].
@@ -97,8 +98,9 @@ Example 2: DSI panel
#size-cells = <0>;
compatible = "st,stm32-dsi";
reg = <0x40016c00 0x800>;
- clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
- clock-names = "pclk", "ref";
+ clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>,
+ <&rcc 1 CLK_LCD>;
+ clock-names = "pclk", "ref", "px_clk";
resets = <&rcc STM32F4_APB2_RESET(DSI)>;
reset-names = "apb";
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-25 16:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-26 16:12 [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property Philippe Cornu
2017-10-27 14:38 ` Rob Herring
2017-10-27 14:52 ` Philippe CORNU
2018-01-21 21:13 Philippe Cornu
2018-01-22 15:38 Philippe Cornu
2018-01-25 16:08 ` Philippe CORNU
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).