From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH v3 1/1] at24: support eeproms that do not auto-rollover reads. Date: Tue, 5 Dec 2017 09:44:51 +0200 Message-ID: <20171205074451.gpsidrxlwyfo2fu7@paasikivi.fi.intel.com> References: <1512401778-20366-1-git-send-email-svendev@arcx.com> <1512401778-20366-2-git-send-email-svendev@arcx.com> <20171204214023.ml2ujacezsop5ilb@kekkonen.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner@vger.kernel.org To: Sven Van Asbroeck Cc: Sven Van Asbroeck , robh+dt@kernel.org, mark.rutland@arm.com, wsa@the-dreams.de, Bartosz Golaszewski , nsekhar@ti.com, david@lechnology.com, javier@dowhile0.org, divagar.mohandass@intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c , Sven Van Asbroeck List-Id: devicetree@vger.kernel.org On Mon, Dec 04, 2017 at 05:24:33PM -0500, Sven Van Asbroeck wrote: > > If this is truly specific to at24, then vendor prefix would be appropriate, > > plus it'd go to an at24 specific binding file. However if it isn't I'd just > > remove the above sentence. I guess the latter? > > Yes, no-read-rollover is truly specific to at24.c, because it applies only > to i2c multi-address chips. The at25 is spi based so cannot have multiple > addresses. > > So yes, "at24,no-read-rollover" would perhaps be a better name. > > Regarding an at24 specific binding file. You're saying I should create > Documentation/devicetree/bindings/eeprom/at24.txt ? Should I indicate > that at24.txt "inherits from" eeprom.txt? Note that at25.txt does not > currently do this. Hmm. I actually missed we didn't have one to begin with. at25.txt exists and it documents a number of properties specific to at25, so if at24 will have an at24-specific property, then I think it should go to a separate file. Aren't there really other chips which need this? It'd be (a little bit) easier to just remove the sentence. :-) -- Regards, Sakari Ailus sakari.ailus@linux.intel.com