From: Georgi Djakov <georgi.djakov@linaro.org>
To: sboyd@codeaurora.org, jassisinghbrar@gmail.com,
bjorn.andersson@linaro.org
Cc: mturquette@baylibre.com, robh@kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
georgi.djakov@linaro.org
Subject: [PATCH v11 2/6] mailbox: qcom: Create APCS child device for clock controller
Date: Tue, 5 Dec 2017 17:46:57 +0200 [thread overview]
Message-ID: <20171205154701.27730-3-georgi.djakov@linaro.org> (raw)
In-Reply-To: <20171205154701.27730-1-georgi.djakov@linaro.org>
There is a clock controller functionality provided by the APCS hardware
block of msm8916 devices. The device-tree would represent an APCS node
with both mailbox and clock provider properties.
Create a platform child device for the clock controller functionality so
the driver can probe and use APCS as parent.
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index ab344bc6fa63..57bde0dfd12f 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -29,6 +29,7 @@ struct qcom_apcs_ipc {
struct regmap *regmap;
unsigned long offset;
+ struct platform_device *clk;
};
static const struct regmap_config apcs_regmap_config = {
@@ -96,6 +97,14 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
return ret;
}
+ if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
+ apcs->clk = platform_device_register_data(&pdev->dev,
+ "qcom-apcs-msm8916-clk",
+ -1, NULL, 0);
+ if (IS_ERR(apcs->clk))
+ dev_err(&pdev->dev, "failed to register APCS clk\n");
+ }
+
platform_set_drvdata(pdev, apcs);
return 0;
@@ -104,8 +113,10 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
static int qcom_apcs_ipc_remove(struct platform_device *pdev)
{
struct qcom_apcs_ipc *apcs = platform_get_drvdata(pdev);
+ struct platform_device *clk = apcs->clk;
mbox_controller_unregister(&apcs->mbox);
+ platform_device_unregister(clk);
return 0;
}
next prev parent reply other threads:[~2017-12-05 15:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 15:46 [PATCH v11 0/6] Add support for Qualcomm A53 CPU clock Georgi Djakov
2017-12-05 15:46 ` [PATCH v11 1/6] mailbox: qcom: Convert APCS IPC driver to use regmap Georgi Djakov
2017-12-05 15:46 ` Georgi Djakov [this message]
2017-12-23 4:57 ` [PATCH v11 2/6] mailbox: qcom: Create APCS child device for clock controller Jassi Brar
[not found] ` <CABb+yY146ho0gtbUzDv-Z_xESkU2y=UYfBA6i+522+m58LkABQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-24 5:06 ` Bjorn Andersson
2017-12-29 6:14 ` Jassi Brar
2018-01-04 16:56 ` Georgi Djakov
2018-01-27 3:44 ` Jassi Brar
2018-01-31 18:40 ` Georgi Djakov
2018-02-01 6:57 ` Jassi Brar
2018-02-01 8:01 ` Georgi Djakov
2017-12-05 15:46 ` [PATCH v11 3/6] clk: qcom: Add A53 PLL support Georgi Djakov
[not found] ` <20171205154701.27730-4-georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-29 0:01 ` Stephen Boyd
2017-12-05 15:46 ` [PATCH v11 4/6] clk: qcom: Add regmap mux-div clocks support Georgi Djakov
2017-12-29 0:01 ` Stephen Boyd
2017-12-05 15:47 ` [PATCH v11 5/6] dt-bindings: mailbox: qcom: Document the APCS clock binding Georgi Djakov
[not found] ` <20171205154701.27730-1-georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-05 15:47 ` [PATCH v11 6/6] clk: qcom: Add APCS clock controller support Georgi Djakov
[not found] ` <20171205154701.27730-7-georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-05 17:21 ` Bjorn Andersson
2017-12-29 0:00 ` Stephen Boyd
2017-12-06 5:51 ` [PATCH v11 0/6] Add support for Qualcomm A53 CPU clock Amit Kucheria
2017-12-07 16:00 ` Georgi Djakov
2017-12-06 21:08 ` Rob Herring
2017-12-07 16:02 ` Georgi Djakov
2017-12-22 0:49 ` Stephen Boyd
2017-12-22 14:52 ` Georgi Djakov
2017-12-28 23:53 ` Stephen Boyd
2018-01-26 14:30 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205154701.27730-3-georgi.djakov@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).