From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 1/5] extcon: usbc-cros-ec: add support to notify USB type cables. Date: Fri, 15 Dec 2017 11:38:00 +0000 Message-ID: <20171215113800.36vomqjngea5p4dr@dell> References: <20171213103219.1464-1-enric.balletbo@collabora.com> <5A33702D.60004@samsung.com> <20171215081453.6jwjdetwe655imqo@dell> <5A3385D0.2050308@samsung.com> <5A3388E5.9030100@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <5A3388E5.9030100@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Chanwoo Choi Cc: Enric Balletbo i Serra , MyungJoo Ham , Rob Herring , Heiko Stuebner , groeck@chromium.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Benson Leung List-Id: devicetree@vger.kernel.org On Fri, 15 Dec 2017, Chanwoo Choi wrote: > On 2017년 12월 15일 17:20, Chanwoo Choi wrote: > > On 2017년 12월 15일 17:14, Lee Jones wrote: > >>> On 2017년 12월 13일 19:32, Enric Balletbo i Serra wrote: > >>>> From: Benson Leung > >>>> > >>>> Extend the driver to notify host and device type cables and the presence > >>>> of power. > >>>> > >>>> Signed-off-by: Benson Leung > >>>> Signed-off-by: Enric Balletbo i Serra > >>>> Reviewed-by: Chanwoo Choi > >>>> --- > >>>> Changes since v1: > >>>> - Use the BIT macro. Requested by Lee Jones. > >>>> - Add the Reviewed-by: Chanwoo Choi. > >>>> > >>>> drivers/extcon/extcon-usbc-cros-ec.c | 142 ++++++++++++++++++++++++++++++++++- > >>>> include/linux/mfd/cros_ec_commands.h | 17 +++++ > >>>> 2 files changed, 155 insertions(+), 4 deletions(-) > >> > >>> Looks good to me. After reviewing the Lee Jones, > >>> I'll take it on next branch. > >> > >> If you take it, you need to send me a pull-request to an immutable > >> branch. > >> > >> Acked-by: Lee Jones > >> > > > > Sure. I'll send the immutable branch. Thanks. > > > > Dear Lee, > > I make the immutable branch (ib-extcon-mfd-4.16) > and send the following pull request. Nicely done. Pulled, thanks. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog