From: Miquel Raynal <miquel.raynal@free-electrons.com>
To: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Antoine Tenart <antoine.tenart@free-electrons.com>,
Nadav Haklai <nadavh@marvell.com>,
Miquel Raynal <miquel.raynal@free-electrons.com>,
Baruch Siach <baruch@tkos.co.il>,
David Sniatkiwicz <davidsn@marvell.com>
Subject: [PATCH v5 02/11] thermal: armada: Use msleep for long delays
Date: Tue, 19 Dec 2017 14:57:10 +0100 [thread overview]
Message-ID: <20171219135719.9531-3-miquel.raynal@free-electrons.com> (raw)
In-Reply-To: <20171219135719.9531-1-miquel.raynal@free-electrons.com>
From: Baruch Siach <baruch@tkos.co.il>
Use msleep for long (> 10ms) delays, instead of the busy waiting mdelay.
All delays are called from the probe routine, where scheduling is
allowed.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
drivers/thermal/armada_thermal.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 706d74798cbe..6c4af2622d4f 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -113,7 +113,7 @@ static void armada370_init_sensor(struct platform_device *pdev,
reg &= ~PMU_TDC0_START_CAL_MASK;
writel(reg, priv->control);
- mdelay(10);
+ msleep(10);
}
static void armada375_init_sensor(struct platform_device *pdev,
@@ -127,11 +127,11 @@ static void armada375_init_sensor(struct platform_device *pdev,
reg &= ~A375_HW_RESETn;
writel(reg, priv->control + 4);
- mdelay(20);
+ msleep(20);
reg |= A375_HW_RESETn;
writel(reg, priv->control + 4);
- mdelay(50);
+ msleep(50);
}
static void armada380_init_sensor(struct platform_device *pdev,
@@ -143,7 +143,7 @@ static void armada380_init_sensor(struct platform_device *pdev,
if (!(reg & A380_HW_RESET)) {
reg |= A380_HW_RESET;
writel(reg, priv->control);
- mdelay(10);
+ msleep(10);
}
}
--
2.11.0
next prev parent reply other threads:[~2017-12-19 13:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 13:57 [PATCH v5 00/11] Armada thermal: improvements and A7K/A8K SoCs support Miquel Raynal
2017-12-19 13:57 ` [PATCH v5 01/11] dt-bindings: thermal: Describe Armada AP806 and CP110 Miquel Raynal
[not found] ` <20171219135719.9531-2-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-12-20 21:08 ` Rob Herring
2017-12-19 13:57 ` Miquel Raynal [this message]
2017-12-19 13:57 ` [PATCH v5 03/11] thermal: armada: Simplify the check of the validity bit Miquel Raynal
[not found] ` <20171219135719.9531-1-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-12-19 13:57 ` [PATCH v5 04/11] thermal: armada: Clarify control registers accesses Miquel Raynal
2017-12-19 13:57 ` [PATCH v5 05/11] thermal: armada: Use real status register name Miquel Raynal
2017-12-19 13:57 ` [PATCH v5 06/11] thermal: armada: Add support for Armada AP806 Miquel Raynal
[not found] ` <20171219135719.9531-7-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-12-20 10:27 ` Gregory CLEMENT
2017-12-22 9:17 ` Miquel RAYNAL
2017-12-20 10:56 ` Gregory CLEMENT
2017-12-19 13:57 ` [PATCH v5 07/11] thermal: armada: Add support for Armada CP110 Miquel Raynal
2017-12-20 10:56 ` Gregory CLEMENT
2017-12-19 13:57 ` [PATCH v5 08/11] thermal: armada: Update Kconfig and module description Miquel Raynal
2017-12-19 13:57 ` [PATCH v5 10/11] thermal: armada: Wait sensors validity before exiting the init callback Miquel Raynal
2017-12-19 13:57 ` [PATCH v5 11/11] thermal: armada: Give meaningful names to the thermal zones Miquel Raynal
2017-12-19 13:57 ` [PATCH v5 09/11] thermal: armada: Change sensors trim default value Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219135719.9531-3-miquel.raynal@free-electrons.com \
--to=miquel.raynal@free-electrons.com \
--cc=antoine.tenart@free-electrons.com \
--cc=baruch@tkos.co.il \
--cc=davidsn@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).