From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emmanuel Vadot Subject: Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t Date: Thu, 21 Dec 2017 19:09:03 +0100 Message-ID: <20171221190903.56ebae536acf51401c63802c@bidouilliste.com> References: <20171219210523.10428-1-kevans91@ksu.edu> <20171221145512.llxvzkcrjpquhczi@flea.lan> <20171221152630.2vf57x5o2yi5sv3n@flea.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171221152630.2vf57x5o2yi5sv3n@flea.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Maxime Ripard Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , linux-sunxi@googlegroups.com, Rob Herring , Srinivas Kandagatla , Kyle Evans , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Maxime, On Thu, 21 Dec 2017 16:26:30 +0100 Maxime Ripard wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > wrote: > > > Hi Kyle, > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > >> thermal calibration data, add node to describe it. > > >> > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > >> supported in an external driver for FreeBSD. > > >> > > >> Signed-off-by: Kyle Evans > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > the register layout (and access patterns) in the past, so I'd rather > > > have something that works in Linux too if possible. > > > > I have a patch that I think should make it work fine on Linux [1], but > > I'm afraid I have little to no capability to test it myself and so I > > did not add it as well. > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > as is the case with the H3, and that the readout quirk is not needed. > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. Take some time on the Linux driver and do not apply this patch for now you mean ? Cheers, > The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. > > Chen-Yu, what do you think? > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Emmanuel Vadot