From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Chunyan Zhang <zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Chunyan Zhang
<zhang.lyra-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/5] bindings: regulator: added support for suspend states
Date: Thu, 21 Dec 2017 17:26:14 -0600 [thread overview]
Message-ID: <20171221232614.rhrgrpyl2w2lc6bw@rob-hp-laptop> (raw)
In-Reply-To: <1513837506-26543-2-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Thu, Dec 21, 2017 at 02:25:02PM +0800, Chunyan Zhang wrote:
> Documented a few new added properties which are used for supporting
> regulator suspend states.
Your commit message should answer why you need this. What problem do you
have that this solves?
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> Documentation/devicetree/bindings/regulator/regulator.txt | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
> index 378f6dc..618a322 100644
> --- a/Documentation/devicetree/bindings/regulator/regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt
> @@ -42,8 +42,15 @@ Optional properties:
> - regulator-state-[mem/disk] node has following common properties:
> - regulator-on-in-suspend: regulator should be on in suspend state.
> - regulator-off-in-suspend: regulator should be off in suspend state.
> - - regulator-suspend-microvolt: regulator should be set to this voltage
> - in suspend.
> + - regulator-suspend-min-microvolt: minimum voltage may be set in
> + suspend state.
> + - regulator-suspend-max-microvolt: maximum voltage may be set in
> + suspend state.
> + - regulator-suspend-microvolt: the default voltage which regulator
> + should be set in suspend, this can be adjusted among
> + <regulator-suspend-min-microvolt, regulator-suspend-max-microvolt>
Perhaps this should stay a single property with: <target> <min> <max>
Though why would you ever not try to set to the minimum voltage within
the range of <min> to <max>?
> + - regulator-changeable-in-suspend: whether the default voltage and
> + the regulator on/off in suspend can be changed in runtime.
> - regulator-mode: operating mode in the given suspend state.
> The set of possible operating modes depends on the capabilities of
> every hardware so the valid modes are documented on each regulator
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-21 23:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 6:25 [PATCH 0/5] Add regulator suspend and resume support Chunyan Zhang
2017-12-21 6:25 ` [PATCH 3/5] drivers: regulator: leave one item to record whether regulator is enabled Chunyan Zhang
[not found] ` <1513837506-26543-1-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-21 6:25 ` [PATCH 1/5] bindings: regulator: added support for suspend states Chunyan Zhang
[not found] ` <1513837506-26543-2-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-21 23:26 ` Rob Herring [this message]
2017-12-22 6:05 ` Chunyan Zhang
2017-12-22 15:49 ` Mark Brown
2017-12-21 6:25 ` [PATCH 2/5] regulator: make regulator voltage be an array to support more states Chunyan Zhang
2017-12-21 6:25 ` [PATCH 4/5] drivers: regulator: empty the old suspend functions Chunyan Zhang
[not found] ` <1513837506-26543-5-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-25 12:15 ` Applied "regulator: empty the old suspend functions" to the regulator tree Mark Brown
2018-01-26 15:26 ` Mark Brown
2017-12-21 6:25 ` [PATCH 5/5] regulator: add PM suspend and resume hooks Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221232614.rhrgrpyl2w2lc6bw@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=zhang.lyra-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).